From 506bafaeb6f5664423d04f5cef2fea5fec3918b9 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 2 Mar 2023 12:16:13 +0100 Subject: [PATCH] Mark classes as final Static analysis is pointing out callouts from constructor to overridable methods. Mark classes as final to make sure nothing untowards happens. JIRA: CONTROLLER-2071 Change-Id: I9ed90a8919f3fd72374cb5564b8e241e954bce6e Signed-off-by: Robert Varga --- .../atomix/storage/journal/FileChannelJournalSegmentReader.java | 2 +- .../io/atomix/storage/journal/MappedJournalSegmentReader.java | 2 +- .../main/java/io/atomix/storage/journal/SegmentedJournal.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/FileChannelJournalSegmentReader.java b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/FileChannelJournalSegmentReader.java index 8ce9498f6c..98133546cf 100644 --- a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/FileChannelJournalSegmentReader.java +++ b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/FileChannelJournalSegmentReader.java @@ -32,7 +32,7 @@ import java.util.zip.Checksum; * * @author Jordan Halterman */ -class FileChannelJournalSegmentReader implements JournalReader { +final class FileChannelJournalSegmentReader implements JournalReader { private final FileChannel channel; private final int maxEntrySize; private final JournalIndex index; diff --git a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/MappedJournalSegmentReader.java b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/MappedJournalSegmentReader.java index 03d5c7fd87..7ad7c219bc 100644 --- a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/MappedJournalSegmentReader.java +++ b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/MappedJournalSegmentReader.java @@ -29,7 +29,7 @@ import java.util.zip.CRC32; * * @author Jordan Halterman */ -class MappedJournalSegmentReader implements JournalReader { +final class MappedJournalSegmentReader implements JournalReader { private final ByteBuffer buffer; private final int maxEntrySize; private final JournalIndex index; diff --git a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java index 419a67e5fb..ea5944aabd 100644 --- a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java +++ b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java @@ -41,7 +41,7 @@ import static java.util.Objects.requireNonNull; /** * Segmented journal. */ -public class SegmentedJournal implements Journal { +public final class SegmentedJournal implements Journal { /** * Returns a new Raft log builder. -- 2.36.6