From 1466ba2e1c9768365d2cc3dfe72bbc7d26cf943d Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 11 Mar 2015 11:18:33 +0100 Subject: [PATCH] Make logger final The logger should be marked as final and also be called LOG, not _logger. Change-Id: I75f675eec1ee54d659d93aef3e39204a1f7cc920 Signed-off-by: Robert Varga --- .../doc/impl/BaseYangSwaggerGenerator.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/opendaylight/md-sal/sal-rest-docgen/src/main/java/org/opendaylight/controller/sal/rest/doc/impl/BaseYangSwaggerGenerator.java b/opendaylight/md-sal/sal-rest-docgen/src/main/java/org/opendaylight/controller/sal/rest/doc/impl/BaseYangSwaggerGenerator.java index 4d567bdef5..a261f23807 100644 --- a/opendaylight/md-sal/sal-rest-docgen/src/main/java/org/opendaylight/controller/sal/rest/doc/impl/BaseYangSwaggerGenerator.java +++ b/opendaylight/md-sal/sal-rest-docgen/src/main/java/org/opendaylight/controller/sal/rest/doc/impl/BaseYangSwaggerGenerator.java @@ -52,7 +52,7 @@ import org.slf4j.LoggerFactory; public class BaseYangSwaggerGenerator { - private static Logger _logger = LoggerFactory.getLogger(BaseYangSwaggerGenerator.class); + private static final Logger LOG = LoggerFactory.getLogger(BaseYangSwaggerGenerator.class); protected static final String API_VERSION = "1.0.0"; protected static final String SWAGGER_VERSION = "1.2"; @@ -84,19 +84,19 @@ public class BaseYangSwaggerGenerator { List resources = new ArrayList<>(modules.size()); - _logger.info("Modules found [{}]", modules.size()); + LOG.info("Modules found [{}]", modules.size()); for (Module module : modules) { String revisionString = SIMPLE_DATE_FORMAT.format(module.getRevision()); Resource resource = new Resource(); - _logger.debug("Working on [{},{}]...", module.getName(), revisionString); + LOG.debug("Working on [{},{}]...", module.getName(), revisionString); ApiDeclaration doc = getApiDeclaration(module.getName(), revisionString, uriInfo, schemaContext, context); if (doc != null) { resource.setPath(generatePath(uriInfo, module.getName(), revisionString)); resources.add(resource); } else { - _logger.debug("Could not generate doc for {},{}", module.getName(), revisionString); + LOG.debug("Could not generate doc for {},{}", module.getName(), revisionString); } } @@ -158,11 +158,11 @@ public class BaseYangSwaggerGenerator { List apis = new ArrayList(); Collection dataSchemaNodes = m.getChildNodes(); - _logger.debug("child nodes size [{}]", dataSchemaNodes.size()); + LOG.debug("child nodes size [{}]", dataSchemaNodes.size()); for (DataSchemaNode node : dataSchemaNodes) { if ((node instanceof ListSchemaNode) || (node instanceof ContainerSchemaNode)) { - _logger.debug("Is Configuration node [{}] [{}]", node.isConfiguration(), node.getQName().getLocalName()); + LOG.debug("Is Configuration node [{}] [{}]", node.isConfiguration(), node.getQName().getLocalName()); List pathParams = new ArrayList(); String resourcePath = getDataStorePath("/config/", context); @@ -181,7 +181,7 @@ public class BaseYangSwaggerGenerator { addRpcs(rpcDefinition, apis, resourcePath, schemaContext); } - _logger.debug("Number of APIs found [{}]", apis.size()); + LOG.debug("Number of APIs found [{}]", apis.size()); if (!apis.isEmpty()) { doc.setApis(apis); @@ -190,8 +190,8 @@ public class BaseYangSwaggerGenerator { try { models = jsonConverter.convertToJsonSchema(m, schemaContext); doc.setModels(models); - if (_logger.isDebugEnabled()) { - _logger.debug(mapper.writeValueAsString(doc)); + if (LOG.isDebugEnabled()) { + LOG.debug(mapper.writeValueAsString(doc)); } } catch (IOException | JSONException e) { e.printStackTrace(); @@ -240,7 +240,7 @@ public class BaseYangSwaggerGenerator { List pathParams = new ArrayList(parentPathParams); String resourcePath = parentPath + createPath(node, pathParams, schemaContext) + "/"; - _logger.debug("Adding path: [{}]", resourcePath); + LOG.debug("Adding path: [{}]", resourcePath); api.setPath(resourcePath); Iterable childSchemaNodes = Collections. emptySet(); -- 2.36.6