From 1e1f78c242b5da077b2b3f61f2b108ecc2e259db Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 16 Mar 2016 14:48:12 +0100 Subject: [PATCH] Remove duplicate 'return true' statements Instead of having each case return true, make it the default return from the method and use the last else branch to return false. Change-Id: I545d2f2c19ef8a10b693a0e904766141bc5db34e Signed-off-by: Robert Varga --- .../cluster/raft/RaftActorSnapshotMessageSupport.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorSnapshotMessageSupport.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorSnapshotMessageSupport.java index 56f40df758..7750cc8923 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorSnapshotMessageSupport.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorSnapshotMessageSupport.java @@ -65,27 +65,23 @@ class RaftActorSnapshotMessageSupport { } boolean handleSnapshotMessage(Object message, ActorRef sender) { - if(message instanceof ApplySnapshot ) { + if (message instanceof ApplySnapshot ) { onApplySnapshot((ApplySnapshot) message); - return true; } else if (message instanceof SaveSnapshotSuccess) { onSaveSnapshotSuccess((SaveSnapshotSuccess) message); - return true; } else if (message instanceof SaveSnapshotFailure) { onSaveSnapshotFailure((SaveSnapshotFailure) message); - return true; } else if (message instanceof CaptureSnapshotReply) { onCaptureSnapshotReply(((CaptureSnapshotReply) message).getSnapshot()); - return true; } else if (message.equals(COMMIT_SNAPSHOT)) { context.getSnapshotManager().commit(-1, currentBehavior); - return true; } else if (message instanceof GetSnapshot) { onGetSnapshot(sender); - return true; } else { return false; } + + return true; } private void onCaptureSnapshotReply(byte[] snapshotBytes) { -- 2.36.6