From 20b6039420d09aa07fb281f6968277d57fc1bfac Mon Sep 17 00:00:00 2001 From: Giovanni Meo Date: Wed, 25 Sep 2013 10:35:03 +0200 Subject: [PATCH] Silent false positive, and enhance real error message - With gerrit https://git.opendaylight.org/gerrit/#/c/1366/ i have introduced a log error, to spot inconsistent hashcode but indeed it turn out is getting exercised also during a normal code path, basically when: --> --> all the other members when getting the replication from the non-key owner will end up in this case. So that cannot be actually considered an error. Change-Id: Id38b45066164cb4998fdcdbb356bdf7af720b8c5 Signed-off-by: Giovanni Meo --- .../distribution/BaseDistributionInterceptor.java | 4 ++-- .../internal/FlowEntryDistributionOrderFutureTask.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/opendaylight/clustering/services_implementation/src/main/java/org/infinispan/interceptors/distribution/BaseDistributionInterceptor.java b/opendaylight/clustering/services_implementation/src/main/java/org/infinispan/interceptors/distribution/BaseDistributionInterceptor.java index e10563797d..6c6715d220 100644 --- a/opendaylight/clustering/services_implementation/src/main/java/org/infinispan/interceptors/distribution/BaseDistributionInterceptor.java +++ b/opendaylight/clustering/services_implementation/src/main/java/org/infinispan/interceptors/distribution/BaseDistributionInterceptor.java @@ -134,9 +134,9 @@ public abstract class BaseDistributionInterceptor extends ClusteringInterceptor rpcManager.invokeRemotely(recipientGenerator.generateRecipients(), command, rpcManager.getDefaultRpcOptions(isSync)); } else { - log.errorf("Didn't invoke RPC because primaryOwner (%s) didn't match this node (%s)", primaryOwner, + log.tracef("Didn't invoke RPC because primaryOwner (%s) didn't match this node (%s)", primaryOwner, rpcManager.getAddress()); - log.errorf("Hashcode is (%s) for Key (%s) .. it could be inconsistent in the cluster!", + log.tracef("Hashcode is (%s) for Key (%s)", command.getKey().hashCode(), command.getKey()); } return returnValue; diff --git a/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/FlowEntryDistributionOrderFutureTask.java b/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/FlowEntryDistributionOrderFutureTask.java index a51409fc2d..0c105bae1e 100644 --- a/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/FlowEntryDistributionOrderFutureTask.java +++ b/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/FlowEntryDistributionOrderFutureTask.java @@ -87,7 +87,8 @@ final class FlowEntryDistributionOrderFutureTask implements Future { // Return the known status return retStatus; } else { - logger.error("Timing out, the workStatus for order {} has not come back in time!", this.order); + logger.error("Timing out, the workStatus for order {} has not come back in time!, it's hashcode is {}", + this.order, this.order.hashCode()); return new Status(StatusCode.TIMEOUT); } } -- 2.36.6