From 2bc808b02828fde2da3dd9bfabab658156faa3c6 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 21 Apr 2017 15:38:03 +0200 Subject: [PATCH 1/1] Relax visibility on FrontendReadWriteTransaction methods We are invoking these methods from anonymous subclasses, hence keeping them private forces redirection via synthetic accessors: at org.opendaylight.controller.cluster.datastore.FrontendReadWriteTransaction.successfulDirectCanCommit at org.opendaylight.controller.cluster.datastore.FrontendReadWriteTransaction.access$300 at org.opendaylight.controller.cluster.datastore.FrontendReadWriteTransaction$5.onSuccess This patch makes the methods package-private, which will eliminate the accessor, improving the stack trace. Change-Id: Idbd803c43d7ed7333fc392a17edaf61c9721d76f Signed-off-by: Robert Varga (cherry picked from commit abe229278329771993cc6ae09eef2a0a7afc2598) --- .../cluster/datastore/FrontendReadWriteTransaction.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java index ced91b5acd..64aef6838b 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java @@ -199,7 +199,7 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { }); } - private void successfulDirectCanCommit(final RequestEnvelope envelope, final long startTime) { + void successfulDirectCanCommit(final RequestEnvelope envelope, final long startTime) { readyCohort.preCommit(new FutureCallback() { @Override public void onSuccess(final DataTreeCandidate result) { @@ -214,7 +214,7 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { }); } - private void successfulDirectPreCommit(final RequestEnvelope envelope, final long startTime) { + void successfulDirectPreCommit(final RequestEnvelope envelope, final long startTime) { readyCohort.commit(new FutureCallback() { @Override public void onSuccess(final UnsignedLong result) { @@ -229,7 +229,7 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { }); } - private void successfulCommit(final RequestEnvelope envelope, final long startTime) { + void successfulCommit(final RequestEnvelope envelope, final long startTime) { recordAndSendSuccess(envelope, startTime, new TransactionCommitSuccess(readyCohort.getIdentifier(), envelope.getMessage().getSequence())); readyCohort = null; -- 2.36.6