From 2d82d2f4f36d22d24883a0f855e39289603377f8 Mon Sep 17 00:00:00 2001 From: Ed Warnicke Date: Fri, 25 Jul 2014 07:05:21 -0500 Subject: [PATCH] Removed BundleContext from Broker.register{Consumer,Provider} (Part 2) Moved the bodies of the methods around to make the deprecated methods just call throughs to the new methods. Removed extra argument from private method newSessionFor Change-Id: I748662491e6670262ecfad4122bcc7a9f831107d Signed-off-by: Ed Warnicke --- .../controller/sal/dom/broker/BrokerImpl.java | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java index c15582e953..68066778db 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java @@ -62,22 +62,13 @@ public class BrokerImpl implements Broker, RpcProvisionRegistry, AutoCloseable { @Override public ConsumerSession registerConsumer(final Consumer consumer, final BundleContext ctx) { - checkPredicates(consumer); - log.trace("Registering consumer {}", consumer); - final ConsumerContextImpl session = newSessionFor(consumer, ctx); - consumer.onSessionInitiated(session); - sessions.add(session); - return session; + return registerConsumer(consumer); } @Override public ProviderSession registerProvider(final Provider provider, final BundleContext ctx) { - checkPredicates(provider); - final ProviderContextImpl session = newSessionFor(provider, ctx); - provider.onSessionInitiated(session); - providerSessions.add(session); - return session; + return registerProvider(provider); } protected Future> invokeRpcAsync(final QName rpc, @@ -106,14 +97,12 @@ public class BrokerImpl implements Broker, RpcProvisionRegistry, AutoCloseable { } // Private Factory methods - private ConsumerContextImpl newSessionFor(final Consumer provider, - final BundleContext ctx) { + private ConsumerContextImpl newSessionFor(final Consumer provider) { ConsumerContextImpl ret = new ConsumerContextImpl(provider, this); return ret; } - private ProviderContextImpl newSessionFor(final Provider provider, - final BundleContext ctx) { + private ProviderContextImpl newSessionFor(final Provider provider) { ProviderContextImpl ret = new ProviderContextImpl(provider, this); return ret; } @@ -210,14 +199,23 @@ public class BrokerImpl implements Broker, RpcProvisionRegistry, AutoCloseable { @Override - public ConsumerSession registerConsumer(Consumer cons) { - return registerConsumer(cons,null); + public ConsumerSession registerConsumer(Consumer consumer) { + checkPredicates(consumer); + log.trace("Registering consumer {}", consumer); + final ConsumerContextImpl session = newSessionFor(consumer); + consumer.onSessionInitiated(session); + sessions.add(session); + return session; } @Override - public ProviderSession registerProvider(Provider prov) { - return registerProvider(prov,null); + public ProviderSession registerProvider(Provider provider) { + checkPredicates(provider); + final ProviderContextImpl session = newSessionFor(provider); + provider.onSessionInitiated(session); + providerSessions.add(session); + return session; } } -- 2.36.6