From 42ee9884457b948f6e9d2b898a501bbf82f1f453 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 19 Feb 2014 03:55:48 +0100 Subject: [PATCH] Fix comments and remove use of deprecated class This primarily removes SchemaServiceListener, as that is deprecated and implied by SchemaContextListener, which is replacing it. Change-Id: I977e818ff466ab27f6cd213d1e0e255e2f1b59a4 Signed-off-by: Robert Varga --- .../common/api/data/DataCommitHandler.java | 4 +-- .../sal/core/api/RpcImplementation.java | 28 +++++++++---------- .../impl/SchemaAwareDataStoreAdapter.java | 4 --- 3 files changed, 16 insertions(+), 20 deletions(-) diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.java index 939ff95135..30f4fc03cb 100644 --- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.java +++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandler.java @@ -24,8 +24,8 @@ import org.opendaylight.yangtools.yang.common.RpcResult; * this is responsibility of the coordinator (broker or some component of the * broker). * - * The commit handlers are responsible for changing the internal state of the - * provider to reflect the commited changes in data. + * Commit handlers are responsible for changing the internal state of the + * provider to reflect the committed changes in data. * *

Two-phase commit

* diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcImplementation.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcImplementation.java index 0299505cde..6b1030a815 100644 --- a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcImplementation.java +++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcImplementation.java @@ -16,11 +16,11 @@ import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.data.api.CompositeNode; /** - * {@link Provider}'s implementation of rpc. - * - * In order to expose the rpc to other components, the provider MUST register - * concrete implementation of this interface - * + * {@link Provider}'s implementation of an RPC. + * + * In order to expose an RPC to other components, the provider MUST register + * a concrete implementation of this interface. + * * The registration could be done by : * - * + * * The simplified process of the invocation of rpc is following: - * + * *
    *
  1. {@link Consumer} invokes * {@link ConsumerSession#rpc(QName, CompositeNode)} @@ -42,31 +42,31 @@ import org.opendaylight.yangtools.yang.data.api.CompositeNode; * {@link RpcResult} *
  2. {@link Broker} returns the {@link RpcResult} to {@link Consumer} *
- * - * + * + * */ public interface RpcImplementation extends Provider.ProviderFunctionality { /** * A set of rpc types supported by implementation. - * + * * The set of rpc {@link QName}s which are supported by this implementation. * This set is used, when {@link Provider} is registered to the SAL, to * register and expose the implementation of the returned rpcs. - * + * * @return Set of QNames identifying supported RPCs */ Set getSupportedRpcs(); /** * Invokes a implementation of specified rpc. - * - * + * + * * @param rpc * Rpc to be invoked * @param input * Input data for rpc. - * + * * @throws IllegalArgumentException *
    *
  • If rpc is null. diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java index abf822087e..f380c27373 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java @@ -44,9 +44,6 @@ import org.opendaylight.yangtools.yang.model.api.DataSchemaNode; import org.opendaylight.yangtools.yang.model.api.ListSchemaNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.opendaylight.yangtools.yang.model.api.SchemaContextListener; -import org.opendaylight.yangtools.yang.model.api.SchemaServiceListener; -import org.opendaylight.yangtools.yang.model.api.TypeDefinition; -import org.opendaylight.yangtools.yang.model.api.UnknownSchemaNode; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -57,7 +54,6 @@ import com.google.common.collect.ImmutableSet; public class SchemaAwareDataStoreAdapter extends AbstractLockableDelegator implements // DataStore, // - SchemaServiceListener, // SchemaContextListener, // AutoCloseable { -- 2.36.6