From 43f18b836755a1167e831687a674d26611f9d3b2 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 16 May 2017 13:54:24 +0200 Subject: [PATCH] Lower debugging in sal-clustering-commons Since this component is under controller.cluster.datastore, it floods logs with serialization details when we really just want to understand what the data store is doing. Lower the logs to TRACE. Change-Id: Ib9a4735bc439a726452fb98fb5f79d2b7dea2047 Signed-off-by: Robert Varga --- .../AbstractNormalizedNodeDataOutput.java | 4 +-- .../NormalizedNodeInputStreamReader.java | 32 +++++++++---------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java index 2e5b804a99..a057a35a96 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java @@ -211,7 +211,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut throws IOException, IllegalArgumentException { Preconditions.checkNotNull(name, "Node identifier should not be null"); - LOG.debug("Starting a new container node"); + LOG.trace("Starting a new container node"); startNode(name.getNodeType(), NodeTypes.CONTAINER_NODE); } @@ -268,7 +268,7 @@ abstract class AbstractNormalizedNodeDataOutput implements NormalizedNodeDataOut public void startOrderedMapNode(final NodeIdentifier name, final int childSizeHint) throws IOException, IllegalArgumentException { Preconditions.checkNotNull(name, "Node identifier should not be null"); - LOG.debug("Starting a new ordered map node"); + LOG.trace("Starting a new ordered map node"); startNode(name.getNodeType(), NodeTypes.ORDERED_MAP_NODE); } diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/NormalizedNodeInputStreamReader.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/NormalizedNodeInputStreamReader.java index 831c516262..4cc63d06b1 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/NormalizedNodeInputStreamReader.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/NormalizedNodeInputStreamReader.java @@ -117,7 +117,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput byte nodeType = input.readByte(); if (nodeType == NodeTypes.END_NODE) { - LOG.debug("End node reached. return"); + LOG.trace("End node reached. return"); return null; } @@ -126,7 +126,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput YangInstanceIdentifier.AugmentationIdentifier augIdentifier = new YangInstanceIdentifier.AugmentationIdentifier(readQNameSet()); - LOG.debug("Reading augmentation node {} ", augIdentifier); + LOG.trace("Reading augmentation node {} ", augIdentifier); return addDataContainerChildren(Builders.augmentationBuilder() .withNodeIdentifier(augIdentifier)).build(); @@ -140,7 +140,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput Object value = readObject(); NodeWithValue leafIdentifier = new NodeWithValue<>(name, value); - LOG.debug("Reading leaf set entry node {}, value {}", leafIdentifier, value); + LOG.trace("Reading leaf set entry node {}, value {}", leafIdentifier, value); return leafSetEntryBuilder().withNodeIdentifier(leafIdentifier).withValue(value).build(); @@ -148,7 +148,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput NodeIdentifierWithPredicates entryIdentifier = new NodeIdentifierWithPredicates( readQName(), readKeyValueMap()); - LOG.debug("Reading map entry node {} ", entryIdentifier); + LOG.trace("Reading map entry node {} ", entryIdentifier); return addDataContainerChildren(Builders.mapEntryBuilder() .withNodeIdentifier(entryIdentifier)).build(); @@ -182,46 +182,46 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput switch (nodeType) { case NodeTypes.LEAF_NODE : - LOG.debug("Read leaf node {}", identifier); + LOG.trace("Read leaf node {}", identifier); // Read the object value return leafBuilder().withNodeIdentifier(identifier).withValue(readObject()).build(); case NodeTypes.ANY_XML_NODE : - LOG.debug("Read xml node"); + LOG.trace("Read xml node"); return Builders.anyXmlBuilder().withNodeIdentifier(identifier).withValue(readDOMSource()).build(); case NodeTypes.MAP_NODE : - LOG.debug("Read map node {}", identifier); + LOG.trace("Read map node {}", identifier); return addDataContainerChildren(Builders.mapBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.CHOICE_NODE: - LOG.debug("Read choice node {}", identifier); + LOG.trace("Read choice node {}", identifier); return addDataContainerChildren(Builders.choiceBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.ORDERED_MAP_NODE: - LOG.debug("Reading ordered map node {}", identifier); + LOG.trace("Reading ordered map node {}", identifier); return addDataContainerChildren(Builders.orderedMapBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.UNKEYED_LIST: - LOG.debug("Read unkeyed list node {}", identifier); + LOG.trace("Read unkeyed list node {}", identifier); return addDataContainerChildren(Builders.unkeyedListBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.UNKEYED_LIST_ITEM: - LOG.debug("Read unkeyed list item node {}", identifier); + LOG.trace("Read unkeyed list item node {}", identifier); return addDataContainerChildren(Builders.unkeyedListEntryBuilder() .withNodeIdentifier(identifier)).build(); case NodeTypes.CONTAINER_NODE: - LOG.debug("Read container node {}", identifier); + LOG.trace("Read container node {}", identifier); return addDataContainerChildren(Builders.containerBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.LEAF_SET : - LOG.debug("Read leaf set node {}", identifier); + LOG.trace("Read leaf set node {}", identifier); return addLeafSetChildren(identifier.getNodeType(), Builders.leafSetBuilder().withNodeIdentifier(identifier)).build(); case NodeTypes.ORDERED_LEAF_SET: - LOG.debug("Read ordered leaf set node {}", identifier); + LOG.trace("Read ordered leaf set node {}", identifier); ListNodeBuilder> orderedLeafSetBuilder = Builders.orderedLeafSetBuilder().withNodeIdentifier(identifier); orderedLeafSetBuilder = addLeafSetChildren(identifier.getNodeType(), orderedLeafSetBuilder); @@ -421,7 +421,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput private ListNodeBuilder> addLeafSetChildren(final QName nodeType, final ListNodeBuilder> builder) throws IOException { - LOG.debug("Reading children of leaf set"); + LOG.trace("Reading children of leaf set"); lastLeafSetQName = nodeType; @@ -437,7 +437,7 @@ public class NormalizedNodeInputStreamReader implements NormalizedNodeDataInput @SuppressWarnings({ "unchecked", "rawtypes" }) private NormalizedNodeContainerBuilder addDataContainerChildren( final NormalizedNodeContainerBuilder builder) throws IOException { - LOG.debug("Reading data container (leaf nodes) nodes"); + LOG.trace("Reading data container (leaf nodes) nodes"); NormalizedNode child = readNormalizedNodeInternal(); -- 2.36.6