From 48904394c82c33384d9da9f0bf233ca950a832fb Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 26 Jan 2015 15:00:58 +0100 Subject: [PATCH] Make sure QNameFactory cache is constant The cache is constant, there is no reason it should be non-final. Change-Id: I663352473e6a9e6021c3cee56ddf0336e5f8e2ac Signed-off-by: Robert Varga --- .../cluster/datastore/node/utils/QNameFactory.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/QNameFactory.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/QNameFactory.java index 5a8f522861..c63266ff08 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/QNameFactory.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/QNameFactory.java @@ -19,11 +19,12 @@ public class QNameFactory { private static final int MAX_QNAME_CACHE_SIZE = 10000; - private static LoadingCache cache = CacheBuilder.newBuilder() + private static final LoadingCache CACHE = CacheBuilder.newBuilder() .maximumSize(MAX_QNAME_CACHE_SIZE) .softValues() .build( new CacheLoader() { + @Override public QName load(String key) { return QName.create(key); } @@ -32,6 +33,6 @@ public class QNameFactory { public static QName create(String name){ - return cache.getUnchecked(name); + return CACHE.getUnchecked(name); } } -- 2.36.6