From 54629feeca8fcad502cc8b2e8800b51f9b341315 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sun, 14 Dec 2014 18:16:50 +0100 Subject: [PATCH] Do not instantiate FluentIterable We are performing an immediate transformation of the iterrable. Instead of that we can immediately use Collections2.transform(), saving an object. Change-Id: Ie943a0a79e04713427bf6470e06d921412ebb179 Signed-off-by: Robert Varga --- .../impl/connect/dom/DomToBindingRpcForwarder.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DomToBindingRpcForwarder.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DomToBindingRpcForwarder.java index 0f450d10bd..8a5ee087fd 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DomToBindingRpcForwarder.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DomToBindingRpcForwarder.java @@ -3,7 +3,7 @@ package org.opendaylight.controller.sal.binding.impl.connect.dom; import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.base.Preconditions.checkState; import com.google.common.base.Function; -import com.google.common.collect.FluentIterable; +import com.google.common.collect.Collections2; import com.google.common.collect.ImmutableSet; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; @@ -159,8 +159,7 @@ class DomToBindingRpcForwarder implements RpcImplementation, InvocationHandler { public void registerPaths(final Class context, final Class service, final Set> set) { QName ctx = BindingReflections.findQName(context); - for (YangInstanceIdentifier path : FluentIterable.from(set).transform( - toDOMInstanceIdentifier)) { + for (YangInstanceIdentifier path : Collections2.transform(set, toDOMInstanceIdentifier)) { for (org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration reg : registrations) { reg.registerPath(ctx, path); } @@ -185,8 +184,7 @@ class DomToBindingRpcForwarder implements RpcImplementation, InvocationHandler { public void removePaths(final Class context, final Class service, final Set> set) { QName ctx = BindingReflections.findQName(context); - for (YangInstanceIdentifier path : FluentIterable.from(set).transform( - toDOMInstanceIdentifier)) { + for (YangInstanceIdentifier path : Collections2.transform(set, toDOMInstanceIdentifier)) { for (org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration reg : registrations) { reg.unregisterPath(ctx, path); } -- 2.36.6