From 5cef4bb35c193f0965777198d6df63cba7bc6770 Mon Sep 17 00:00:00 2001 From: Flavio Fernandes Date: Mon, 21 Apr 2014 18:52:56 -0400 Subject: [PATCH] Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java Change-Id: Ie8749e5dfcb04042922293ed45e8f06d42de90ab Signed-off-by: Flavio Fernandes --- .../simpleforwarding/internal/SimpleBroadcastHandlerImpl.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/internal/SimpleBroadcastHandlerImpl.java b/opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/internal/SimpleBroadcastHandlerImpl.java index e39ae65693..96e36f413c 100644 --- a/opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/internal/SimpleBroadcastHandlerImpl.java +++ b/opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/internal/SimpleBroadcastHandlerImpl.java @@ -93,6 +93,7 @@ public class SimpleBroadcastHandlerImpl implements IBroadcastHandler, IListenDat lock.readLock().lock(); if (topoManager == null || dataPacketService == null || swMgr == null) { + lock.readLock().unlock(); return false; } @@ -124,6 +125,7 @@ public class SimpleBroadcastHandlerImpl implements IBroadcastHandler, IListenDat log.error("Mode set to " + BroadcastMode.EXTERNAL_QUERY + ", but no external source of broadcast ports was provided."); + lock.readLock().unlock(); return false; } break; -- 2.36.6