From 618db2402a3f95dd7d160ad67ecbb4e7cc42026b Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 9 Mar 2022 19:08:03 +0100 Subject: [PATCH] Remove an unneeded @SuppressFBWarnings The warning is no longer emitted here with our current SpotBugs, hence we can remove the suppression. Change-Id: Id1bb3c87a05f14cba76dc8a1af73740a461a1fc1 Signed-off-by: Robert Varga --- .../cluster/databroker/ConcurrentDOMDataBroker.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/ConcurrentDOMDataBroker.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/ConcurrentDOMDataBroker.java index 28151cc413..1738d1d309 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/ConcurrentDOMDataBroker.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/ConcurrentDOMDataBroker.java @@ -20,7 +20,6 @@ import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.MoreExecutors; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.util.Collection; import java.util.Iterator; import java.util.List; @@ -186,10 +185,6 @@ public class ConcurrentDOMDataBroker extends AbstractDOMBroker { Futures.addCallback(cohortIterator.next().commit(), futureCallback, MoreExecutors.directExecutor()); } - @SuppressFBWarnings(value = "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE", - justification = "Pertains to the assignment of the 'clientException' var. FindBugs flags this as an " - + "uncomfirmed cast but the generic type in TransactionCommitFailedExceptionMapper is " - + "TransactionCommitFailedException and thus should be deemed as confirmed.") private static void handleException(final AsyncNotifyingSettableFuture clientSubmitFuture, final DOMDataTreeWriteTransaction transaction, final Collection cohorts, -- 2.36.6