From 622c0f8064ecd2b06837136864819d1510124df5 Mon Sep 17 00:00:00 2001 From: Tony Tkacik Date: Thu, 11 Sep 2014 16:45:53 +0200 Subject: [PATCH] Fixed test which tested incorrect string formating It turned out, that this test suite tested returned formated string from YANGTools, which format was not part of API Contract. Updated test to test to only for non nulls, which are parts of API Contract. Change-Id: I6e33993928667c6e8b4a830b6d0a9c8d10cd4fa2 Signed-off-by: Tony Tkacik --- .../broker/impl/jmx/CommitStatsMXBeanImplTest.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBeanImplTest.java b/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBeanImplTest.java index d796930302..613b7a60ab 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBeanImplTest.java +++ b/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBeanImplTest.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.md.sal.dom.broker.impl.jmx; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; import org.junit.Test; import org.opendaylight.yangtools.util.DurationStatsTracker; @@ -29,13 +30,9 @@ public class CommitStatsMXBeanImplTest { commitStatsTracker.addDuration(100); - String prefix = "100.0 ns"; assertEquals("getTotalCommits", 1L, bean.getTotalCommits()); - assertEquals("getLongestCommitTime starts with \"" + prefix + "\"", true, - bean.getLongestCommitTime().startsWith("100.0 ns")); - assertEquals("getShortestCommitTime starts with \"" + prefix + "\"", true, - bean.getShortestCommitTime().startsWith(prefix)); - assertEquals("getAverageCommitTime starts with \"" + prefix + "\"", true, - bean.getAverageCommitTime().startsWith(prefix)); + assertNotNull(bean.getLongestCommitTime()); + assertNotNull(bean.getShortestCommitTime()); + assertNotNull(bean.getAverageCommitTime()); } } -- 2.36.6