From 690b4c7632f05f7f1ba23e45ce2d00a2e82d22c1 Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Sat, 23 Sep 2017 02:46:57 +0200 Subject: [PATCH] AsyncWriteTransaction JavaDoc re. retries > instead of < in case of OptimisticLockFailedException, one should do: if (tries - 1 > 0) { // do retry } else { // out of retries and not if (tries - 1 < 0 ). Change-Id: I6a7b681c7e7bd1a9787c640e2cdd5ab7723a74a2 Signed-off-by: Michael Vorburger --- .../md/sal/common/api/data/AsyncWriteTransaction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java index cc22bb91ad..effeabefae 100644 --- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java +++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java @@ -164,7 +164,7 @@ public interface AsyncWriteTransaction

, D> extends AsyncTransa * * public void onFailure( Throwable t ) { * if( t instanceof OptimisticLockFailedException ) { - * if( ( tries - 1 ) < 0 ) { + * if( ( tries - 1 ) > 0 ) { * // do retry * doWrite( tries - 1 ); * } else { -- 2.36.6