From 6dbf8f82cfa9fe8c35e4085213a55cb887cc3aee Mon Sep 17 00:00:00 2001 From: David Suarez Date: Wed, 27 Sep 2017 15:23:16 +0200 Subject: [PATCH] Remove explicit default super-constructor calls The default constructor is called by default (hence its name), no need to call it explicitly. Change-Id: I0f4ac3bf4a1d582b7a9d50beeaa1de6d2f107499 Signed-off-by: David Suarez --- .../java/org/opendaylight/controller/liblldp/Ethernet.java | 1 - .../main/java/org/opendaylight/controller/liblldp/LLDP.java | 1 - .../controller/config/api/ConflictingVersionException.java | 1 - .../opendaylight/controller/config/facade/xml/rpc/Rpcs.java | 1 - .../manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java | 1 - .../yang/netty/threadgroup/NioEventLoopGroupCloseable.java | 1 - .../yangjmxgenerator/plugin/ftl/model/Constructor.java | 1 - .../config/yangjmxgenerator/plugin/ftl/model/Header.java | 1 - .../yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java | 1 - .../controller/config/yangjmxgenerator/AbstractEntry.java | 1 - .../closetracker/impl/CloseTrackedRegistryReportEntry.java | 1 - .../cluster/example/ExampleRoleChangeListener.java | 1 - .../controller/cluster/raft/behaviors/LeaderTest.java | 1 - .../md/sal/binding/api/ForwardingReadOnlyTransaction.java | 1 - .../md/sal/binding/api/ForwardingReadWriteTransaction.java | 1 - .../md/sal/binding/api/ForwardingWriteTransaction.java | 1 - .../controller/sal/binding/api/rpc/RpcContextIdentifier.java | 1 - .../md/sal/binding/impl/BindingDOMAdapterLoader.java | 1 - .../md/sal/binding/impl/BindingDOMRpcServiceAdapter.java | 1 - .../md/sal/binding/impl/LazySerializedDOMNotification.java | 1 - .../binding/test/ConstantSchemaAbstractDataBrokerTest.java | 1 - .../common/impl/util/compat/DataNormalizationOperation.java | 2 -- .../sal/common/util/jmx/QueuedNotificationManagerStats.java | 5 ++--- .../opendaylight/controller/sal/common/util/RpcErrors.java | 1 - .../controller/sal/connector/api/BindingAwareRpcRouter.java | 2 -- .../controller/sal/core/api/RpcRoutingContext.java | 1 - .../sal/dom/broker/impl/SchemaContextProviders.java | 1 - 27 files changed, 2 insertions(+), 31 deletions(-) diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java index 2cdf9a5ae0..a78ff6a1d1 100644 --- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java +++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java @@ -44,7 +44,6 @@ public class Ethernet extends Packet { * Default constructor that creates and sets the HashMap */ public Ethernet() { - super(); fieldValues = new HashMap<>(); hdrFieldCoordMap = fieldCoordinates; hdrFieldsMap = fieldValues; diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java index dfd8ca42e5..7ed1ede781 100644 --- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java +++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java @@ -34,7 +34,6 @@ public class LLDP extends Packet { * Default constructor that creates the tlvList LinkedHashMap */ public LLDP() { - super(); init(); } diff --git a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java index bb0256174c..9e3c5016ce 100644 --- a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java +++ b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java @@ -18,7 +18,6 @@ public class ConflictingVersionException extends Exception { private static final long serialVersionUID = 1L; public ConflictingVersionException() { - super(); } public ConflictingVersionException(final String message, final Throwable cause) { diff --git a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java index 5180ab83e3..f409ee25ea 100644 --- a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java +++ b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java @@ -15,7 +15,6 @@ public class Rpcs { private final Map> mappedRpcs; public Rpcs(Map> mappedRpcs) { - super(); this.mappedRpcs = mappedRpcs; } diff --git a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java index 8abb635755..8b66ad7563 100644 --- a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java +++ b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java @@ -17,7 +17,6 @@ public interface ReadOnlyAtomicBoolean { private final AtomicBoolean atomicBoolean; public ReadOnlyAtomicBooleanImpl(final AtomicBoolean atomicBoolean) { - super(); this.atomicBoolean = atomicBoolean; } diff --git a/opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java b/opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java index 8e8ee64f3e..5f92f943e3 100644 --- a/opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java +++ b/opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java @@ -16,7 +16,6 @@ public class NioEventLoopGroupCloseable extends NioEventLoopGroup implements Aut } private NioEventLoopGroupCloseable() { - super(); } @Override diff --git a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java index 91c1cc3966..915e8c5753 100644 --- a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java +++ b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java @@ -13,7 +13,6 @@ public class Constructor { private final boolean isPublic; public Constructor(String typeName, String body, boolean isPublic) { - super(); this.typeName = typeName; this.body = body; this.isPublic = isPublic; diff --git a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java index b9a628495d..f8f58d073f 100644 --- a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java +++ b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java @@ -11,7 +11,6 @@ public class Header { private final String yangModuleName, yangModuleLocalName; public Header(String yangModuleName, String yangModuleLocalName) { - super(); this.yangModuleName = yangModuleName; this.yangModuleLocalName = yangModuleLocalName; } diff --git a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java index 1c44040708..be917dfdda 100644 --- a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java +++ b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java @@ -17,7 +17,6 @@ public class TypeDeclaration { public TypeDeclaration(String type, String name, List extended, List implemented, boolean isAbstract, boolean isFinal) { - super(); this.type = type; this.name = name; this.extended = extended; diff --git a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java index 0b27218ff3..c61229a80e 100644 --- a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java +++ b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java @@ -16,7 +16,6 @@ public class AbstractEntry { private String yangModuleLocalname; public AbstractEntry() { - super(); } protected void setYangModuleName(String name) { diff --git a/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java b/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java index 1681eb8d1a..2dd161a5ff 100644 --- a/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java +++ b/opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java @@ -24,7 +24,6 @@ public class CloseTrackedRegistryReportEntry> { public CloseTrackedRegistryReportEntry(CloseTracked exampleCloseTracked, long numberAddedNotRemoved, List stackTraceElements) { - super(); this.exampleCloseTracked = requireNonNull(exampleCloseTracked, "closeTracked"); this.numberAddedNotRemoved = requireNonNull(numberAddedNotRemoved, "numberAddedNotRemoved"); this.stackTraceElements = requireNonNull(stackTraceElements, "stackTraceElements"); diff --git a/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java b/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java index 3336ad9b3b..6e89ca7110 100644 --- a/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java +++ b/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java @@ -45,7 +45,6 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A private static final String[] shardsToMonitor = new String[] {"example"}; public ExampleRoleChangeListener(String memberName) { - super(); scheduleRegistrationListener(schedulerDuration); this.memberName = memberName; populateRegistry(memberName); diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java index 00a2fcd9f0..7ad5812f64 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java @@ -2389,7 +2389,6 @@ public class LeaderTest extends AbstractLeaderTest { private final int snapshotChunkSize; MockConfigParamsImpl(final long electionTimeOutIntervalMillis, final int snapshotChunkSize) { - super(); this.electionTimeOutIntervalMillis = electionTimeOutIntervalMillis; this.snapshotChunkSize = snapshotChunkSize; } diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java index bc7d18c8d1..a8fad51560 100644 --- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java +++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java @@ -25,7 +25,6 @@ public class ForwardingReadOnlyTransaction extends ForwardingObject implements R private final ReadOnlyTransaction delegate; protected ForwardingReadOnlyTransaction(ReadOnlyTransaction delegate) { - super(); this.delegate = delegate; } diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java index ae7446b1b2..97a6db6419 100644 --- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java +++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java @@ -29,7 +29,6 @@ public class ForwardingReadWriteTransaction extends ForwardingObject implements private final ReadWriteTransaction delegate; protected ForwardingReadWriteTransaction(ReadWriteTransaction delegate) { - super(); this.delegate = delegate; } diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java index 81193afe50..e6027430ce 100644 --- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java +++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java @@ -28,7 +28,6 @@ public class ForwardingWriteTransaction extends ForwardingObject implements Writ private final WriteTransaction delegate; protected ForwardingWriteTransaction(WriteTransaction delegate) { - super(); this.delegate = delegate; } diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java index e3bedd33f9..b4bd6eb6a7 100644 --- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java +++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java @@ -17,7 +17,6 @@ public final class RpcContextIdentifier implements Immutable{ public final Class routingContext; private RpcContextIdentifier(Class rpcService, Class routingContext) { - super(); this.rpcService = rpcService; this.routingContext = routingContext; } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java index 96108ee1f0..d8afdeb150 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java @@ -33,7 +33,6 @@ public abstract class BindingDOMAdapterLoader extends AdapterLoader impleme } protected DataNormalizationOperation(final T identifier, final SchemaNode schema) { - super(); this.identifier = identifier; if(schema instanceof DataSchemaNode) { this.dataSchemaNode = Optional.of((DataSchemaNode) schema); @@ -328,7 +327,6 @@ public abstract class DataNormalizationOperation impleme private static final class AugmentationNormalization extends DataContainerNormalizationOperation { public AugmentationNormalization(final AugmentationSchema augmentation, final DataNodeContainer schema) { - //super(); super(augmentationIdentifierFrom(augmentation), augmentationProxy(augmentation,schema),null); } diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java index c6e50060a1..1cc62f4065 100644 --- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java +++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java @@ -31,9 +31,8 @@ public class QueuedNotificationManagerStats { private final List currentListenerQueueStats; @ConstructorProperties({"maxListenerQueueSize","currentListenerQueueStats"}) - public QueuedNotificationManagerStats( int maxListenerQueueSize, - List currentListenerQueueStats ) { - super(); + public QueuedNotificationManagerStats(int maxListenerQueueSize, + List currentListenerQueueStats) { this.maxListenerQueueSize = maxListenerQueueSize; this.currentListenerQueueStats = currentListenerQueueStats; } diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java index cacb167f6f..28133c5b69 100644 --- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java +++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java @@ -55,7 +55,6 @@ public class RpcErrors { */ protected RpcErrorTO(String applicationTag, String tag, String info, ErrorSeverity severity, String message, ErrorType errorType, Throwable cause) { - super(); this.applicationTag = applicationTag; this.tag = tag; this.info = info; diff --git a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java index c242e0c967..17221bc0af 100644 --- a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java +++ b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java @@ -23,7 +23,6 @@ public interface BindingAwareRpcRouter extends RpcRouter