From 6dbff3628e4d0e0cde63e69b2aba5ecc79c25e3d Mon Sep 17 00:00:00 2001 From: Anil Vishnoi Date: Mon, 5 Jan 2015 14:12:17 +0530 Subject: [PATCH] Bug 2552 - Fix statistics manager log messages Fixed the log message to spit clear information about the warning message. Change-Id: I9fc064cd8418b9d5ae22b9949fe535cbf4bc33d4 Signed-off-by: Anil Vishnoi --- .../md/statistics/manager/impl/StatRpcMsgManagerImpl.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRpcMsgManagerImpl.java b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRpcMsgManagerImpl.java index 4870223c0f..20341bcc66 100644 --- a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRpcMsgManagerImpl.java +++ b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/impl/StatRpcMsgManagerImpl.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.md.statistics.manager.impl; +import java.util.Arrays; import java.util.List; import java.util.concurrent.BlockingQueue; import java.util.concurrent.CopyOnWriteArrayList; @@ -50,6 +51,7 @@ import org.opendaylight.yangtools.yang.common.RpcResult; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.google.common.base.Joiner; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.cache.Cache; @@ -174,13 +176,15 @@ public class StatRpcMsgManagerImpl implements StatRpcMsgManager { @Override public void onSuccess(final RpcResult result) { final TransactionId id = result.getResult().getTransactionId(); + final NodeKey nodeKey = nodeRef.getValue().firstKeyOf(Node.class, NodeKey.class); if (id == null) { - LOG.warn("No protocol support"); + String[] multipartRequestName = result.getResult().getClass().getSimpleName().split("(?=\\p{Upper})"); + LOG.warn("Node [{}] does not support statistics request type : {}", + nodeKey.getId(),Joiner.on(" ").join(Arrays.copyOfRange(multipartRequestName, 2, multipartRequestName.length-2))); } else { if (resultTransId != null) { resultTransId.set(id); } - final NodeKey nodeKey = nodeRef.getValue().firstKeyOf(Node.class, NodeKey.class); final String cacheKey = buildCacheKey(id, nodeKey.getId()); final TransactionCacheContainer container = new TransactionCacheContainerImpl<>(id, inputObj, nodeKey.getId()); -- 2.36.6