From 73dcd6419a9804de962edafa58fac490e6a270a7 Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Tue, 9 Dec 2014 17:45:50 -0500 Subject: [PATCH] Fix checkstyle if-statements must use braces yang-jmx-generator Change-Id: I2d57b840a80d48d5227651582436b6c78ddf1ad5 Signed-off-by: Thanh Ha --- .../yangjmxgenerator/attribute/Dependency.java | 12 ++++++++---- .../yangjmxgenerator/attribute/JavaAttribute.java | 3 ++- .../plugin/util/FullyQualifiedNameHelper.java | 3 ++- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/Dependency.java b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/Dependency.java index 6ea2ea1724..fd07e269f4 100644 --- a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/Dependency.java +++ b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/Dependency.java @@ -28,17 +28,21 @@ public class Dependency { @Override public boolean equals(Object o) { - if (this == o) + if (this == o) { return true; - if (o == null || getClass() != o.getClass()) + } + if (o == null || getClass() != o.getClass()) { return false; + } Dependency that = (Dependency) o; - if (mandatory != that.mandatory) + if (mandatory != that.mandatory) { return false; - if (!sie.equals(that.sie)) + } + if (!sie.equals(that.sie)) { return false; + } return true; } diff --git a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/JavaAttribute.java b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/JavaAttribute.java index e13c22a2ab..f6ce92d506 100644 --- a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/JavaAttribute.java +++ b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/attribute/JavaAttribute.java @@ -281,8 +281,9 @@ public class JavaAttribute extends AbstractAttribute implements TypedAttribute { // TODO verify private boolean isPrimitive(String innerTypeFullyQName) { - if (innerTypeFullyQName.contains(".")) + if (innerTypeFullyQName.contains(".")) { return false; + } return true; } diff --git a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/util/FullyQualifiedNameHelper.java b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/util/FullyQualifiedNameHelper.java index 966aff96a0..7c3ebb5916 100644 --- a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/util/FullyQualifiedNameHelper.java +++ b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/util/FullyQualifiedNameHelper.java @@ -14,8 +14,9 @@ public class FullyQualifiedNameHelper { public static String getFullyQualifiedName(String packageName, String className) { - if (packageName.isEmpty()) + if (packageName.isEmpty()) { return className; + } return packageName + "." + className; } } -- 2.36.6