From 81b0b9d6fd26b1567bfc6dd80fa1a90bd30bff0b Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 23 Oct 2020 19:31:58 +0200 Subject: [PATCH 1/1] Deprecate common.util.Arguments for removal The method hosted is used only in 6 call sites across all downstreams. Deprecate it for removal, so they can come up with a replacement. Change-Id: Iddfc75ef40710944e8f6e5a420dd0c467d973671 Signed-off-by: Robert Varga --- .../controller/sal/common/util/Arguments.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java index d09024aea0..6d8081edb6 100644 --- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java +++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java @@ -7,8 +7,8 @@ */ package org.opendaylight.controller.sal.common.util; +@Deprecated(forRemoval = true) public final class Arguments { - private Arguments() { throw new UnsupportedOperationException("Utility class"); } @@ -19,12 +19,14 @@ public final class Arguments { * @param value Value to check * @param type Type to check * @return Reference which was checked + * @deprecated This utility is not used in this project, please brew your own or + * use {@code Preconditions.checkArgument()}. */ - @SuppressWarnings("unchecked") - public static T checkInstanceOf(Object value, Class type) { + @Deprecated(forRemoval = true) + public static T checkInstanceOf(final Object value, final Class type) { if (!type.isInstance(value)) { throw new IllegalArgumentException(String.format("Value %s is not of type %s", value, type)); } - return (T) value; + return type.cast(value); } } -- 2.36.6