From 8e25126e8331d586f85e3f6fa64e47d85e97f790 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 12 Apr 2016 14:07:36 +0200 Subject: [PATCH] Make ReplicatedLogImplEntry final This is a simple DTO, make sure it cannot carry a null payload and cannot be subclassed. Change-Id: I6fbe1bfb18b6f1b127b357fc0f40d86cb26a81b7 Signed-off-by: Robert Varga --- .../cluster/raft/ReplicatedLogImplEntry.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplEntry.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplEntry.java index 799e75ebfa..e5bf72233c 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplEntry.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplEntry.java @@ -8,21 +8,24 @@ package org.opendaylight.controller.cluster.raft; +import com.google.common.base.Preconditions; import java.io.Serializable; import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload; -public class ReplicatedLogImplEntry implements ReplicatedLogEntry, Serializable { +/** + * A {@link ReplicatedLogEntry} implementation. + */ +public final class ReplicatedLogImplEntry implements ReplicatedLogEntry, Serializable { private static final long serialVersionUID = -9085798014576489130L; private final long index; private final long term; private final Payload payload; - public ReplicatedLogImplEntry(long index, long term, Payload payload) { - + public ReplicatedLogImplEntry(final long index, final long term, final Payload payload) { this.index = index; this.term = term; - this.payload = payload; + this.payload = Preconditions.checkNotNull(payload); } @Override @@ -47,9 +50,6 @@ public class ReplicatedLogImplEntry implements ReplicatedLogEntry, Serializable @Override public String toString() { - return "Entry{" + - "index=" + index + - ", term=" + term + - '}'; + return "Entry{index=" + index + ", term=" + term + '}'; } } -- 2.36.6