From 90f03193700920e656596d2a2257802cb22a90c7 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 28 Mar 2019 14:32:44 +0100 Subject: [PATCH] Fix logging messages Upgraded spotbugs is finding more violations, fix them up. Change-Id: I8956c5b7a6eef38286f4c2b6fb07ca6a775e6965 Signed-off-by: Robert Varga --- .../controller/cluster/common/actor/MeteredBoundedMailbox.java | 2 +- .../EntityOwnerSelectionStrategyConfigReader.java | 2 +- .../cluster/sharding/DistributedShardChangePublisher.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java index c3f61c66fe..d234532751 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java @@ -74,7 +74,7 @@ public class MeteredBoundedMailbox implements MailboxType, registry.register(fullName, metric); } catch (IllegalArgumentException e) { // already registered - shouldn't happen here since we check above... - LOG.debug("Unable to register '{}' in metrics registry: {}", e); + LOG.debug("Unable to register '{}' in metrics registry", fullName); } } diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java index 4ac28a6719..2d504cd6aa 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java @@ -50,7 +50,7 @@ public final class EntityOwnerSelectionStrategyConfigReader { for (final Entry entry : properties.entrySet()) { final String key = (String) entry.getKey(); if (!key.startsWith(ENTITY_TYPE_PREFIX)) { - LOG.debug("Ignoring non-conforming property key : {}"); + LOG.debug("Ignoring non-conforming property key : {}", key); continue; } diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java index 5d1e4b5cfd..ba061ee400 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java @@ -201,7 +201,7 @@ public class DistributedShardChangePublisher try { DataTreeCandidates.applyToModification(modification, change); } catch (SchemaValidationFailedException e) { - LOG.error("Validation failed {}", e); + LOG.error("Validation failed", e); } } -- 2.36.6