From 9f0d57f4f0c2a0f1c1cf63e65de8915b2a580c76 Mon Sep 17 00:00:00 2001 From: Tomas Olvecky Date: Mon, 2 Jun 2014 13:27:34 +0200 Subject: [PATCH] Fix logging in NetconfDeviceSalFacade Use correct logger name, make RPC warning log more granular. Change-Id: Id9ec5aec64f1037411d2e105309e258aab411e24 Signed-off-by: Tomas Olvecky --- .../connect/netconf/sal/NetconfDeviceSalFacade.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceSalFacade.java b/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceSalFacade.java index f39c4d5792..37b87045d5 100644 --- a/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceSalFacade.java +++ b/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceSalFacade.java @@ -7,11 +7,11 @@ */ package org.opendaylight.controller.sal.connect.netconf.sal; +import com.google.common.collect.Lists; import com.google.common.collect.Maps; import java.util.Collections; import java.util.List; import java.util.Map; - import java.util.concurrent.ExecutorService; import org.opendaylight.controller.sal.binding.api.BindingAwareBroker; import org.opendaylight.controller.sal.connect.api.RemoteDeviceHandler; @@ -29,11 +29,9 @@ import org.osgi.framework.BundleContext; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.google.common.collect.Lists; - public final class NetconfDeviceSalFacade implements AutoCloseable, RemoteDeviceHandler { - private static final Logger logger= LoggerFactory.getLogger(NetconfDeviceTwoPhaseCommitTransaction.class); + private static final Logger logger= LoggerFactory.getLogger(NetconfDeviceSalFacade.class); private static final InstanceIdentifier ROOT_PATH = InstanceIdentifier.builder().toInstance(); private final RemoteDeviceId id; @@ -88,7 +86,11 @@ public final class NetconfDeviceSalFacade implements AutoCloseable, RemoteDevice } if (failedRpcs.isEmpty() == false) { - logger.warn("{}: Some rpcs from netconf device were not registered: {}", id, failedRpcs); + if (logger.isDebugEnabled()) { + logger.warn("{}: Some rpcs from netconf device were not registered: {}", id, failedRpcs); + } else { + logger.warn("{}: Some rpcs from netconf device were not registered: {}", id, failedRpcs.keySet()); + } } } -- 2.36.6