From ada8704dbbc74be7dbd0af241e9fac78108bd83f Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Thu, 22 Sep 2016 18:26:25 +0200 Subject: [PATCH] Mechanical code cleanup (sal-connector-api) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: I7771fe4533469229b319c5d0590d26922a389f9e Signed-off-by: Stephen Kitt --- .../controller/sal/connector/api/BindingAwareRpcRouter.java | 2 +- .../controller/sal/connector/api/RpcRouter.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java index cf59eb4a90..c242e0c967 100644 --- a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java +++ b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java @@ -14,7 +14,7 @@ import org.opendaylight.yangtools.concepts.Immutable; public interface BindingAwareRpcRouter extends RpcRouter { @Override - public Future> sendRpc( + Future> sendRpc( RpcRequest input); class BindingAwareRequest implements RpcRequest, Immutable { diff --git a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/RpcRouter.java b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/RpcRouter.java index fa4c8048fa..f49f7ef5f4 100644 --- a/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/RpcRouter.java +++ b/opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/RpcRouter.java @@ -34,20 +34,20 @@ public interface RpcRouter { * @param Rpc Type * @param Data Type */ - public interface RpcRequest { + interface RpcRequest { RouteIdentifier getRoutingInformation(); D getPayload(); } - public interface RouteIdentifier { + interface RouteIdentifier { C getContext(); // defines a routing table (e.g. NodeContext) T getType(); // rpc type R getRoute(); // e.g. (node identity) } - public interface RpcReply { + interface RpcReply { D getPayload(); } } -- 2.36.6