From b4d30424d8fd2e2a7ae37a9ff169b672e8e43550 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 3 Apr 2023 15:31:47 +0200 Subject: [PATCH] Improve ServerConfigurationPayload.equals() Use pattern matching on instanceof to reduce verbosity while retaining semantics. Change-Id: I2600f35ae6c71c9e235609246f775fdc9f8eb6b2 Signed-off-by: Robert Varga --- .../persisted/ServerConfigurationPayload.java | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/ServerConfigurationPayload.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/ServerConfigurationPayload.java index 4843063647..02cb6fa37e 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/ServerConfigurationPayload.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/ServerConfigurationPayload.java @@ -121,20 +121,8 @@ public final class ServerConfigurationPayload extends Payload implements Persist @Override public boolean equals(final Object obj) { - if (this == obj) { - return true; - } - - if (obj == null) { - return false; - } - - if (getClass() != obj.getClass()) { - return false; - } - - ServerConfigurationPayload other = (ServerConfigurationPayload) obj; - return serverConfig.equals(other.serverConfig); + return this == obj || obj instanceof ServerConfigurationPayload other + && serverConfig.equals(other.serverConfig); } @Override -- 2.36.6