From d57b995265d6d7f5509fa2d6f518f36fe63fc434 Mon Sep 17 00:00:00 2001 From: Dominik Vrbovsky Date: Tue, 14 Sep 2021 16:07:12 +0200 Subject: [PATCH] Add a private modifiers to command arguments in clustering-test-app Change-Id: I29e188d39a7dc507c0f9f61f086e699522757dc5 Signed-off-by: Dominik Vrbovsky --- .../it/karaf/cli/car/RegisterOwnershipCommand.java | 2 +- .../clustering/it/karaf/cli/car/StressTestCommand.java | 4 ++-- .../it/karaf/cli/car/UnregisterOwnershipCommand.java | 2 +- .../it/karaf/cli/car/purchase/BuyCarCommand.java | 4 ++-- .../mdsal/lowlevel/control/AddShardReplicaCommand.java | 2 +- .../control/CheckPublishNotificationsCommand.java | 2 +- .../lowlevel/control/RegisterBoundConstantCommand.java | 4 ++-- .../lowlevel/control/RegisterConstantCommand.java | 2 +- .../control/RegisterDefaultConstantCommand.java | 2 +- .../control/RegisterSingletonConstantCommand.java | 2 +- .../lowlevel/control/RemoveShardReplicaCommand.java | 2 +- .../lowlevel/control/ShutdownShardReplicaCommand.java | 2 +- .../control/StartPublishNotificationsCommand.java | 6 +++--- .../mdsal/lowlevel/control/SubscribeYnlCommand.java | 2 +- .../control/UnregisterBoundConstantCommand.java | 2 +- .../mdsal/lowlevel/control/UnsubscribeYnlCommand.java | 2 +- .../lowlevel/control/WriteTransactionsCommand.java | 8 ++++---- .../it/karaf/cli/people/AddPersonCommand.java | 10 +++++----- 18 files changed, 30 insertions(+), 30 deletions(-) diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/RegisterOwnershipCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/RegisterOwnershipCommand.java index 60cc0989d9..5af5cd66d9 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/RegisterOwnershipCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/RegisterOwnershipCommand.java @@ -24,7 +24,7 @@ public class RegisterOwnershipCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "car-id", required = true) - String carId; + private String carId; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/StressTestCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/StressTestCommand.java index 6b9e64ad73..f3bf816d6f 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/StressTestCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/StressTestCommand.java @@ -26,9 +26,9 @@ public class StressTestCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "rate", required = true) - int rate; + private int rate; @Argument(index = 1, name = "count", required = true) - long count; + private long count; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/UnregisterOwnershipCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/UnregisterOwnershipCommand.java index e699139738..bb8bf0e14a 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/UnregisterOwnershipCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/UnregisterOwnershipCommand.java @@ -25,7 +25,7 @@ public class UnregisterOwnershipCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "car-id", required = true) - String carId; + private String carId; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/purchase/BuyCarCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/purchase/BuyCarCommand.java index f06d71f0db..3290f9de82 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/purchase/BuyCarCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/purchase/BuyCarCommand.java @@ -32,9 +32,9 @@ public class BuyCarCommand extends AbstractRpcAction { @Argument(index = 0, name = "person-ref", required = true) String personRef; @Argument(index = 1, name = "car-id", required = true) - CarId carId; + private CarId carId; @Argument(index = 2, name = "person-id", required = true) - PersonId personId; + private PersonId personId; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/AddShardReplicaCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/AddShardReplicaCommand.java index 3280a5cc50..4169f70de0 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/AddShardReplicaCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/AddShardReplicaCommand.java @@ -24,7 +24,7 @@ public class AddShardReplicaCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "shard-name", required = true) - String shardName; + private String shardName; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/CheckPublishNotificationsCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/CheckPublishNotificationsCommand.java index 818a9f9d55..fe8cf7e1a1 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/CheckPublishNotificationsCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/CheckPublishNotificationsCommand.java @@ -25,7 +25,7 @@ public class CheckPublishNotificationsCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - String id; + private String id; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterBoundConstantCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterBoundConstantCommand.java index 9fc92a3b19..ff9105304c 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterBoundConstantCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterBoundConstantCommand.java @@ -27,9 +27,9 @@ public class RegisterBoundConstantCommand extends AbstractRpcAction { @Reference private InstanceIdentifierSupport iidSupport; @Argument(index = 0, name = "context", required = true) - String context; + private String context; @Argument(index = 1, name = "constant", required = true) - String constant; + private String constant; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterConstantCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterConstantCommand.java index e9a9ce938f..b114949397 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterConstantCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterConstantCommand.java @@ -24,7 +24,7 @@ public class RegisterConstantCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "constant", required = true) - String constant; + private String constant; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterDefaultConstantCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterDefaultConstantCommand.java index 8aac81265d..4095c3c29f 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterDefaultConstantCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterDefaultConstantCommand.java @@ -24,7 +24,7 @@ public class RegisterDefaultConstantCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "constant", required = true) - String constant; + private String constant; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterSingletonConstantCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterSingletonConstantCommand.java index d5054c069c..64be2ed577 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterSingletonConstantCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterSingletonConstantCommand.java @@ -25,7 +25,7 @@ public class RegisterSingletonConstantCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "constant", required = true) - String constant; + private String constant; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RemoveShardReplicaCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RemoveShardReplicaCommand.java index fad24dda02..2565156812 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RemoveShardReplicaCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RemoveShardReplicaCommand.java @@ -24,7 +24,7 @@ public class RemoveShardReplicaCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "shard-name", required = true) - String shardName; + private String shardName; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/ShutdownShardReplicaCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/ShutdownShardReplicaCommand.java index 1a75b5b9f1..f8f025370e 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/ShutdownShardReplicaCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/ShutdownShardReplicaCommand.java @@ -24,7 +24,7 @@ public class ShutdownShardReplicaCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "shard-name", required = true) - String shardName; + private String shardName; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/StartPublishNotificationsCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/StartPublishNotificationsCommand.java index bf17708401..68be7e30be 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/StartPublishNotificationsCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/StartPublishNotificationsCommand.java @@ -26,11 +26,11 @@ public class StartPublishNotificationsCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - String id; + private String id; @Argument(index = 1, name = "seconds", required = true) - long seconds; + private long seconds; @Argument(index = 2, name = "notifications-per-second", required = true) - long notificationsPerSecond; + private long notificationsPerSecond; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/SubscribeYnlCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/SubscribeYnlCommand.java index 523650ec78..00e6fa4c15 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/SubscribeYnlCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/SubscribeYnlCommand.java @@ -24,7 +24,7 @@ public class SubscribeYnlCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - String id; + private String id; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnregisterBoundConstantCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnregisterBoundConstantCommand.java index 76dc4d50f4..3cc086efa6 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnregisterBoundConstantCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnregisterBoundConstantCommand.java @@ -27,7 +27,7 @@ public class UnregisterBoundConstantCommand extends AbstractRpcAction { @Reference private InstanceIdentifierSupport iidSupport; @Argument(index = 0, name = "context", required = true) - String context; + private String context; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnsubscribeYnlCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnsubscribeYnlCommand.java index e9d1104258..cd01e0cc1d 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnsubscribeYnlCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnsubscribeYnlCommand.java @@ -24,7 +24,7 @@ public class UnsubscribeYnlCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - String id; + private String id; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/WriteTransactionsCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/WriteTransactionsCommand.java index 60288cdc19..ad90f8733a 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/WriteTransactionsCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/WriteTransactionsCommand.java @@ -25,13 +25,13 @@ public class WriteTransactionsCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - String id; + private String id; @Argument(index = 1, name = "seconds", required = true) - long seconds; + private long seconds; @Argument(index = 2, name = "trasactions-per-second", required = true) - long transactionsPerSecond; + private long transactionsPerSecond; @Argument(index = 3, name = "chained-transations", required = true) - boolean chainedTransactions; + private boolean chainedTransactions; @Override protected ListenableFuture> invokeRpc() { diff --git a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/people/AddPersonCommand.java b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/people/AddPersonCommand.java index 037b122a83..b6697f5659 100644 --- a/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/people/AddPersonCommand.java +++ b/opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/people/AddPersonCommand.java @@ -26,15 +26,15 @@ public class AddPersonCommand extends AbstractRpcAction { @Reference private RpcConsumerRegistry rpcService; @Argument(index = 0, name = "id", required = true) - PersonId id; + private PersonId id; @Argument(index = 1, name = "gender", required = true) - String gender; + private String gender; @Argument(index = 2, name = "age", required = true) - long age; + private long age; @Argument(index = 3, name = "address", required = true) - String address; + private String address; @Argument(index = 4, name = "contactNo", required = true) - String contactNo; + private String contactNo; @Override protected ListenableFuture> invokeRpc() { -- 2.36.6