From db354f68b25d0ab0cfced6ae01756d6a4f3a4141 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 2 Dec 2014 14:19:49 +0100 Subject: [PATCH] BUG-2459: Reuse SAXTransformerFactory in EXI decoder Rather than allocating the same factory over and over, create a single instance for reuse. Change-Id: Ia615dbd462527addadb03a5f2e54618438fb1612 Signed-off-by: Robert Varga --- .../nettyutil/handler/NetconfEXIToMessageDecoder.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/controller/netconf/nettyutil/handler/NetconfEXIToMessageDecoder.java b/opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/controller/netconf/nettyutil/handler/NetconfEXIToMessageDecoder.java index 0d8f9eeec1..77d33e1831 100644 --- a/opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/controller/netconf/nettyutil/handler/NetconfEXIToMessageDecoder.java +++ b/opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/controller/netconf/nettyutil/handler/NetconfEXIToMessageDecoder.java @@ -17,7 +17,6 @@ import java.io.IOException; import java.io.InputStream; import java.util.List; import javax.xml.transform.TransformerConfigurationException; -import javax.xml.transform.TransformerFactory; import javax.xml.transform.dom.DOMResult; import javax.xml.transform.sax.SAXTransformerFactory; import javax.xml.transform.sax.TransformerHandler; @@ -33,6 +32,7 @@ import org.xml.sax.SAXException; public final class NetconfEXIToMessageDecoder extends ByteToMessageDecoder { private static final Logger LOG = LoggerFactory.getLogger(NetconfEXIToMessageDecoder.class); + private static final SAXTransformerFactory FACTORY = (SAXTransformerFactory) SAXTransformerFactory.newInstance(); private final NetconfEXICodec codec; @@ -60,10 +60,7 @@ public final class NetconfEXIToMessageDecoder extends ByteToMessageDecoder { } final EXIReader r = codec.getReader(); - - final SAXTransformerFactory transformerFactory - = (SAXTransformerFactory) TransformerFactory.newInstance(); - final TransformerHandler handler = transformerFactory.newTransformerHandler(); + final TransformerHandler handler = FACTORY.newTransformerHandler(); r.setContentHandler(handler); final DOMResult domResult = new DOMResult(); -- 2.36.6