From e72ae0ab1513e382e141f70dc544efdd782e439d Mon Sep 17 00:00:00 2001 From: Alessandro Boch Date: Thu, 1 Aug 2013 12:03:51 -0700 Subject: [PATCH] Fix minor bug in FRM proactive flow code path ISSUE: When proactive flows are installed on a switch (as a result of user configuring the forwarding mode of the node to proactive) in case switch fails to install any of these flows, the informational log still reports that the proactive flow was succesfully installed. CHANGE: When calling addStaticFlowInternal() make sure to pass the restore flag as false Change-Id: I7f1e85d40624a145c6d71bb1149b14c825894312 Signed-off-by: Alessandro Boch --- .../forwardingrulesmanager/internal/ForwardingRulesManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManager.java b/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManager.java index 2eaafb6989..cade266688 100644 --- a/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManager.java +++ b/opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManager.java @@ -1915,7 +1915,7 @@ public class ForwardingRulesManager implements IForwardingRulesManager, PortGrou log.info("Forwarding mode for node {} set to {}", node, (proactive ? "proactive" : "reactive")); for (FlowConfig fc : defaultConfigs) { - Status status = (proactive) ? addStaticFlowInternal(fc, true) : removeStaticFlow(fc); + Status status = (proactive) ? addStaticFlowInternal(fc, false) : removeStaticFlow(fc); if (status.isSuccess()) { log.info("{} Proactive Static flow: {}", (proactive ? "Installed" : "Removed"), fc.getName()); } else { -- 2.36.6