From f9125372a33e633d76b6afeb94c98dc72de77106 Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Fri, 12 May 2017 17:33:21 +0200 Subject: [PATCH] netty-event-executor-config: final parameters This automatically-generated patch flags all appropriate parameters as final (including caught exceptions). Change-Id: I53e5803a91a723714f4c9b5a2299c869d81b5a9a Signed-off-by: Stephen Kitt --- .../eventexecutor/AutoCloseableEventExecutor.java | 4 ++-- .../netty/eventexecutor/GlobalEventExecutorModule.java | 10 +++++----- .../GlobalEventExecutorModuleFactory.java | 4 ++-- .../eventexecutor/ImmediateEventExecutorModule.java | 6 +++--- .../ImmediateEventExecutorModuleFactory.java | 4 ++-- .../eventexecutor/GlobalEventExecutorModuleTest.java | 4 ++-- .../ImmediateEventExecutorModuleTest.java | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java index b77126b16d..d4e58db36a 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java @@ -22,7 +22,7 @@ public interface AutoCloseableEventExecutor extends EventExecutor, AutoCloseable public static final int DEFAULT_SHUTDOWN_SECONDS = 1; private final EventExecutor eventExecutor; - public CloseableEventExecutorMixin(EventExecutor eventExecutor) { + public CloseableEventExecutorMixin(final EventExecutor eventExecutor) { this.eventExecutor = eventExecutor; } @@ -36,7 +36,7 @@ public interface AutoCloseableEventExecutor extends EventExecutor, AutoCloseable final CloseableEventExecutorMixin closeableEventExecutorMixin) { return Reflection.newProxy(AutoCloseableEventExecutor.class, new AbstractInvocationHandler() { @Override - protected Object handleInvocation(Object proxy, Method method, Object[] args) throws Throwable { + protected Object handleInvocation(final Object proxy, final Method method, final Object[] args) throws Throwable { if (method.getName().equals("close")) { closeableEventExecutorMixin.close(); return null; diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModule.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModule.java index 476b202921..427cad5c74 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModule.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModule.java @@ -30,14 +30,14 @@ public final class GlobalEventExecutorModule extends org.opendaylight.controller.config.yang.netty.eventexecutor.AbstractGlobalEventExecutorModule { private BundleContext bundleContext; - public GlobalEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, - org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + public GlobalEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, + final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { super(identifier, dependencyResolver); } - public GlobalEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, - org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, - GlobalEventExecutorModule oldModule, java.lang.AutoCloseable oldInstance) { + public GlobalEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, + final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, + final GlobalEventExecutorModule oldModule, final java.lang.AutoCloseable oldInstance) { super(identifier, dependencyResolver, oldModule, oldInstance); } diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleFactory.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleFactory.java index c15d80b15b..d4597d46ac 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleFactory.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleFactory.java @@ -30,7 +30,7 @@ public class GlobalEventExecutorModuleFactory extends org.opendaylight.controlle @Override - public GlobalEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, GlobalEventExecutorModule oldModule, AutoCloseable oldInstance, BundleContext bundleContext) { + public GlobalEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final GlobalEventExecutorModule oldModule, final AutoCloseable oldInstance, final BundleContext bundleContext) { checkArgument(SINGLETON_NAME.equals(instanceName),"Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME); GlobalEventExecutorModule module = super.instantiateModule(instanceName, dependencyResolver, oldModule, oldInstance, bundleContext); @@ -39,7 +39,7 @@ public class GlobalEventExecutorModuleFactory extends org.opendaylight.controlle } @Override - public GlobalEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + public GlobalEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final BundleContext bundleContext) { checkArgument(SINGLETON_NAME.equals(instanceName),"Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME); GlobalEventExecutorModule module = super.instantiateModule(instanceName, dependencyResolver, bundleContext); module.setBundleContext(bundleContext); diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModule.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModule.java index 6163ce0041..6bdef5c1e4 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModule.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModule.java @@ -15,12 +15,12 @@ import org.opendaylight.controller.config.yang.netty.eventexecutor.AutoCloseable @Deprecated public final class ImmediateEventExecutorModule extends org.opendaylight.controller.config.yang.netty.eventexecutor.AbstractImmediateEventExecutorModule { - public ImmediateEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + public ImmediateEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { super(identifier, dependencyResolver); } - public ImmediateEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, - ImmediateEventExecutorModule oldModule, java.lang.AutoCloseable oldInstance) { + public ImmediateEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, + final ImmediateEventExecutorModule oldModule, final java.lang.AutoCloseable oldInstance) { super(identifier, dependencyResolver, oldModule, oldInstance); } diff --git a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleFactory.java b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleFactory.java index f9d6417bdb..814ca21245 100644 --- a/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleFactory.java +++ b/opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleFactory.java @@ -19,13 +19,13 @@ public class ImmediateEventExecutorModuleFactory extends org.opendaylight.contro public static final String SINGLETON_NAME = "singleton"; @Override - public ImmediateEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, ImmediateEventExecutorModule oldModule, AutoCloseable oldInstance, BundleContext bundleContext) { + public ImmediateEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final ImmediateEventExecutorModule oldModule, final AutoCloseable oldInstance, final BundleContext bundleContext) { checkArgument(SINGLETON_NAME.equals(instanceName), "Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME); return super.instantiateModule(instanceName, dependencyResolver, oldModule, oldInstance, bundleContext); } @Override - public ImmediateEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + public ImmediateEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final BundleContext bundleContext) { checkArgument(SINGLETON_NAME.equals(instanceName), "Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME); return super.instantiateModule(instanceName, dependencyResolver, bundleContext); } diff --git a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java index 7d763699ff..2bf7149544 100644 --- a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java +++ b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java @@ -71,7 +71,7 @@ public class GlobalEventExecutorModuleTest extends AbstractConfigTest { try { createInstance(transaction, instanceName + "x"); fail(); - }catch(IllegalArgumentException e){ + }catch(final IllegalArgumentException e){ assertTrue(e.getMessage() + " failure", e.getMessage().contains("only allowed name is singleton")); } } @@ -93,7 +93,7 @@ public class GlobalEventExecutorModuleTest extends AbstractConfigTest { assertStatus(status, 0, 0, 1); } - private ObjectName createInstance(ConfigTransactionJMXClient transaction, String instanceName) + private ObjectName createInstance(final ConfigTransactionJMXClient transaction, final String instanceName) throws InstanceAlreadyExistsException { ObjectName nameCreated = transaction.createModule(factory.getImplementationName(), instanceName); transaction.newMXBeanProxy(nameCreated, GlobalEventExecutorModuleMXBean.class); diff --git a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleTest.java b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleTest.java index d280bcac58..8ab15705e2 100644 --- a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleTest.java +++ b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleTest.java @@ -61,7 +61,7 @@ public class ImmediateEventExecutorModuleTest extends AbstractConfigTest { assertStatus(status, 0, 0, 1); } - private ObjectName createInstance(ConfigTransactionJMXClient transaction, String instanceName) + private ObjectName createInstance(final ConfigTransactionJMXClient transaction, final String instanceName) throws InstanceAlreadyExistsException { ObjectName nameCreated = transaction.createModule(factory.getImplementationName(), instanceName); transaction.newMXBeanProxy(nameCreated, ImmediateEventExecutorModuleMXBean.class); -- 2.36.6