From faba9da80e675b3f093bfd569f496317d92ec893 Mon Sep 17 00:00:00 2001 From: Alissa Bonas Date: Mon, 28 Oct 2013 12:44:28 +0200 Subject: [PATCH] Make existCache more efficient in ClusterManager Allocate cacheName only when it's needed, when manager is null the concatenation of strings is redundant. Change-Id: I031e923d2d725b3e295ed7be53ceba19a6892e96 Signed-off-by: Alissa Bonas --- .../services_implementation/internal/ClusterManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java b/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java index 518bf7b1a8..a9e6948a40 100644 --- a/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java +++ b/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java @@ -398,10 +398,12 @@ public class ClusterManager implements IClusterServices { @Override public boolean existCache(String containerName, String cacheName) { EmbeddedCacheManager manager = this.cm; - String realCacheName = "{" + containerName + "}_{" + cacheName + "}"; + if (manager == null) { return false; } + + String realCacheName = "{" + containerName + "}_{" + cacheName + "}"; return manager.cacheExists(realCacheName); } -- 2.36.6