From 525113ce9397c91f5ca1cbc7c2ff923f5ce3ddc2 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 7 Nov 2014 20:24:40 +0100 Subject: [PATCH] Remove unused warnings suppressions Remove suppressions which do not do anything -- thus fixing eclipse warnings. Change-Id: I846133477235152504bb159b6bf58e58c0455521 Signed-off-by: Robert Varga --- .../internal/DijkstraImplementation.java | 2 +- .../datastore/DataChangeListenerRegistrationProxyTest.java | 2 -- .../controller/cluster/datastore/ShardTransactionTest.java | 1 - .../controller/cluster/datastore/TransactionProxyTest.java | 6 ------ .../topology/manager/FlowCapableTopologyExporterTest.java | 1 - 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/opendaylight/adsal/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementation.java b/opendaylight/adsal/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementation.java index 07f18ff6ab..b68cc0cab2 100644 --- a/opendaylight/adsal/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementation.java +++ b/opendaylight/adsal/routing/dijkstra_implementation/src/main/java/org/opendaylight/controller/routing/dijkstra_implementation/internal/DijkstraImplementation.java @@ -397,7 +397,7 @@ public class DijkstraImplementation implements IRouting, ITopologyManagerCluster * dependencies are satisfied * */ - @SuppressWarnings({ "unchecked", "rawtypes" }) + @SuppressWarnings("unchecked") public void init() { log.debug("Routing init() is called"); this.topologyBWAware = new ConcurrentHashMap>(); diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationProxyTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationProxyTest.java index 9ac30095a5..6f8035e2d1 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationProxyTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationProxyTest.java @@ -66,7 +66,6 @@ public class DataChangeListenerRegistrationProxyTest extends AbstractActorTest { Assert.assertEquals(mockListener, proxy.getInstance()); } - @SuppressWarnings("unchecked") @Test(timeout=10000) public void testSuccessfulRegistration() { new JavaTestKit(getSystem()) {{ @@ -217,7 +216,6 @@ public class DataChangeListenerRegistrationProxyTest extends AbstractActorTest { }}; } - @SuppressWarnings("unchecked") @Test public void testCloseBeforeRegistration() { new JavaTestKit(getSystem()) {{ diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java index 4ccc9430ac..0caad94840 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java @@ -347,7 +347,6 @@ public class ShardTransactionTest extends AbstractActorTest { } - @SuppressWarnings("unchecked") @Test public void testOnReceiveCloseTransaction() throws Exception { new JavaTestKit(getSystem()) {{ diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionProxyTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionProxyTest.java index cdf085e2ff..38254dd01a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionProxyTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionProxyTest.java @@ -807,7 +807,6 @@ public class TransactionProxyTest { } } - @SuppressWarnings("unchecked") @Test public void testReady() throws Exception { ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), READ_WRITE); @@ -842,7 +841,6 @@ public class TransactionProxyTest { verifyCohortFutures(proxy, getSystem().actorSelection(actorRef.path())); } - @SuppressWarnings("unchecked") @Test public void testReadyForwardCompatibility() throws Exception { ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), READ_WRITE, 0); @@ -883,7 +881,6 @@ public class TransactionProxyTest { eq(actorRef.path().toString())); } - @SuppressWarnings("unchecked") @Test public void testReadyWithRecordingOperationFailure() throws Exception { ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), WRITE_ONLY); @@ -920,7 +917,6 @@ public class TransactionProxyTest { MergeDataReply.SERIALIZABLE_CLASS, TestException.class); } - @SuppressWarnings("unchecked") @Test public void testReadyWithReplyFailure() throws Exception { ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), WRITE_ONLY); @@ -977,7 +973,6 @@ public class TransactionProxyTest { verifyCohortFutures(proxy, PrimaryNotFoundException.class); } - @SuppressWarnings("unchecked") @Test public void testReadyWithInvalidReplyMessageType() throws Exception { ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), WRITE_ONLY); @@ -1016,7 +1011,6 @@ public class TransactionProxyTest { assertTrue("Invalid identifier: " + id, id.toString().startsWith(memberName)); } - @SuppressWarnings("unchecked") @Test public void testClose() throws Exception{ ActorRef actorRef = setupActorContextWithInitialCreateTransaction(getSystem(), READ_WRITE); diff --git a/opendaylight/md-sal/topology-manager/src/test/java/org/opendaylight/md/controller/topology/manager/FlowCapableTopologyExporterTest.java b/opendaylight/md-sal/topology-manager/src/test/java/org/opendaylight/md/controller/topology/manager/FlowCapableTopologyExporterTest.java index c3357b7c6c..e1d643cd5b 100644 --- a/opendaylight/md-sal/topology-manager/src/test/java/org/opendaylight/md/controller/topology/manager/FlowCapableTopologyExporterTest.java +++ b/opendaylight/md-sal/topology-manager/src/test/java/org/opendaylight/md/controller/topology/manager/FlowCapableTopologyExporterTest.java @@ -380,7 +380,6 @@ public class FlowCapableTopologyExporterTest { assertEquals("getInventoryNodeRef", new NodeRef(invNodeID), augmentation.getInventoryNodeRef()); } - @SuppressWarnings("rawtypes") @Test public void testOnNodeConnectorUpdated() { -- 2.36.6