apply checkstyle check during build for neutron-ovsdb

[groupbasedpolicy.git] / neutron-ovsdb / src / main / java / org / opendaylight / groupbasedpolicy / neutron / ovsdb / ProviderPhysicalNetworkListener.java

diff --git a/neutron-ovsdb/src/main/java/org/opendaylight/groupbasedpolicy/neutron/ovsdb/ProviderPhysicalNetworkListener.java b/neutron-ovsdb/src/main/java/org/opendaylight/groupbasedpolicy/neutron/ovsdb/ProviderPhysicalNetworkListener.java
index 72233f336abdb1d5b42d5454fd789669e9e4906a..7fbd84b720654f388edf2c8af0d61a5bd4774e5c 100644 (file)
--- a/neutron-ovsdb/src/main/java/org/opendaylight/groupbasedpolicy/neutron/ovsdb/ProviderPhysicalNetworkListener.java
+++ b/neutron-ovsdb/src/main/java/org/opendaylight/groupbasedpolicy/neutron/ovsdb/ProviderPhysicalNetworkListener.java
@@ -7,6 +7,8 @@
  */
 package org.opendaylight.groupbasedpolicy.neutron.ovsdb;
 
+import com.google.common.base.Strings;
+
 import org.opendaylight.controller.md.sal.binding.api.DataBroker;
 import org.opendaylight.controller.md.sal.binding.api.DataObjectModification;
 import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier;
@@ -28,15 +30,13 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.common.base.Strings;
-
 public class ProviderPhysicalNetworkListener extends DataTreeChangeHandler<ProviderPhysicalNetworkAsL2FloodDomain> {
 
     private static final Logger LOG = LoggerFactory.getLogger(ProviderPhysicalNetworkListener.class);
 
     protected ProviderPhysicalNetworkListener(DataBroker dataProvider) {
-        super(dataProvider,
-                new DataTreeIdentifier<>(LogicalDatastoreType.OPERATIONAL,
+        super(dataProvider);
+        registerDataTreeChangeListener(new DataTreeIdentifier<>(LogicalDatastoreType.OPERATIONAL,
                         InstanceIdentifier.builder(Mappings.class)
                             .child(NeutronByGbpMappings.class)
                             .child(ProviderPhysicalNetworksAsL2FloodDomains.class)
@@ -47,27 +47,36 @@ public class ProviderPhysicalNetworkListener extends DataTreeChangeHandler<Provi
     @Override
     protected void onWrite(DataObjectModification<ProviderPhysicalNetworkAsL2FloodDomain> rootNode,
             InstanceIdentifier<ProviderPhysicalNetworkAsL2FloodDomain> rootIdentifier) {
-        L2FloodDomainId l2FdId = rootNode.getDataAfter().getL2FloodDomainId();
-        TenantId tenantId = rootNode.getDataAfter().getTenantId();
-        String segmentationId = rootNode.getDataAfter().getSegmentationId();
-        augmentSegmentationToFloodDomain(tenantId, l2FdId, segmentationId);
+        ProviderPhysicalNetworkAsL2FloodDomain dataAfter = rootNode.getDataAfter();
+        if (dataAfter != null) {
+            L2FloodDomainId l2FdId = dataAfter.getL2FloodDomainId();
+            TenantId tenantId = dataAfter.getTenantId();
+            String segmentationId = dataAfter.getSegmentationId();
+            augmentSegmentationToFloodDomain(tenantId, l2FdId, segmentationId);
+        }
     }
 
     @Override
     protected void onDelete(DataObjectModification<ProviderPhysicalNetworkAsL2FloodDomain> rootNode,
             InstanceIdentifier<ProviderPhysicalNetworkAsL2FloodDomain> rootIdentifier) {
-        L2FloodDomainId l2FdId = rootNode.getDataBefore().getL2FloodDomainId();
-        TenantId tenantId = rootNode.getDataBefore().getTenantId();
-        augmentSegmentationToFloodDomain(tenantId, l2FdId, null);
+        ProviderPhysicalNetworkAsL2FloodDomain dataBefore = rootNode.getDataBefore();
+        if (dataBefore != null) {
+            L2FloodDomainId l2FdId = dataBefore.getL2FloodDomainId();
+            TenantId tenantId = dataBefore.getTenantId();
+            augmentSegmentationToFloodDomain(tenantId, l2FdId, null);
+        }
     }
 
     @Override
     protected void onSubtreeModified(DataObjectModification<ProviderPhysicalNetworkAsL2FloodDomain> rootNode,
             InstanceIdentifier<ProviderPhysicalNetworkAsL2FloodDomain> rootIdentifier) {
-        L2FloodDomainId l2FdId = rootNode.getDataAfter().getL2FloodDomainId();
-        TenantId tenantId = rootNode.getDataAfter().getTenantId();
-        String segmentationId = rootNode.getDataAfter().getSegmentationId();
-        augmentSegmentationToFloodDomain(tenantId, l2FdId, segmentationId);
+        ProviderPhysicalNetworkAsL2FloodDomain dataAfter = rootNode.getDataAfter();
+        if (dataAfter != null) {
+            L2FloodDomainId l2FdId = dataAfter.getL2FloodDomainId();
+            TenantId tenantId = dataAfter.getTenantId();
+            String segmentationId = dataAfter.getSegmentationId();
+            augmentSegmentationToFloodDomain(tenantId, l2FdId, segmentationId);
+        }
     }
 
     private void augmentSegmentationToFloodDomain(TenantId tenantId, L2FloodDomainId l2FdId, String segmentationId) {
@@ -80,10 +89,10 @@ public class ProviderPhysicalNetworkListener extends DataTreeChangeHandler<Provi
             try {
                 Segmentation segmentation =
                         new SegmentationBuilder().setSegmentationId(Integer.valueOf(segmentationId)).build();
-                WriteTransaction wTx = dataProvider.newWriteOnlyTransaction();
-                wTx.merge(LogicalDatastoreType.CONFIGURATION,
+                WriteTransaction writeTx = dataProvider.newWriteOnlyTransaction();
+                writeTx.merge(LogicalDatastoreType.CONFIGURATION,
                         IidFactory.l2FloodDomainIid(tenantId, l2FdId).augmentation(Segmentation.class), segmentation);
-                DataStoreHelper.submitToDs(wTx);
+                DataStoreHelper.submitToDs(writeTx);
             } catch (NumberFormatException e) {
                 LOG.info("Segmentation ID of Neutron Provider Physical Network {} is not a number but is {}.",
                         l2FdId.getValue(), segmentationId);