Add flag to log, or not, in Get_From_URI kw 46/88446/6
authorJamo Luhrsen <jluhrsen@gmail.com>
Mon, 16 Mar 2020 21:53:35 +0000 (14:53 -0700)
committerJamo Luhrsen <jluhrsen@gmail.com>
Tue, 17 Mar 2020 23:25:34 +0000 (16:25 -0700)
commit05408d9fd56ad88a9fb31e9df346f72fb578d71b
tree900e3482566083719da791298b20c88e42a4ca87
parent256bb345eaf2cc08e87e8a01b7c7634310effcd3
Add flag to log, or not, in Get_From_URI kw

the problem fixed here was noticed in the netconf max
device scale job. The GET was retrieving a semi-large
output each time it was checking and looping until
success (which could be minutes) and over hundreds of
devices was causing the logs to grow so large that
robot itself would crash (assuming kernel killed OOM)

Note: some keywords were given an additional argument
${log_response}=True even though the body of the keyword
does not use it. This is because there is a wrapper
keyword that calls other keywords. That wrapper
(Perform_Operation_On_Each_Device) is now passing
this log_response flag every time, even for keywords
that don't need it (e.g., Configure_Device).

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ia9828be85e1fc2a7e4392f58c421f49f507d611b
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
csit/libraries/NetconfKeywords.robot
csit/libraries/TemplatedRequests.robot
csit/suites/netconf/scale/max_devices.robot