Migrate Get Requests invocations(libraries)

The 'Get Request' RequestsLibrary keyword has been deprecated.
'Get Request' has been replaced by 'GET On Session'.

JIRA: INTTEST-141
Change-Id: I2128046b5a97126ad33927b099f605fc92715e81
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Reformat '* On Session' keywords (aaa)

Use a line per argument when the keyword does not fit in a single line
to make the format more consistent across the test suites.

Change-Id: I674441ee2fa639cdad03f5d6da71716cdda79c94
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate 'Get Request' (bgpcep)

There are a couple places in bgpcep test suites where deprecated
'Get Request' RequestsLibrary keyword is used. Replace it with
'GET On Session'.

Also, use 'anything' instead of 'any' and do not remove 'alias=' for
the session argument to make them more consistent across all the test
suites.

JIRA: INTTEST-141
Change-Id: Id8bf71a5477cdfb5d6181016a614bbc8f7dfc083
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate request invocations (netconf)

NetconfCallHome.robot is still using deprecated '* Request' keywords
from RequestsLibrary. Replace them with '* On Session'.

JIRA: INTTEST-141
Change-Id: Ief00e4e55e4b967a47d065063f93f3dbe646eb31
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate 'To Json' (daexim)

There is one place that uses the deprecated 'RequestLibrary.To Json'
keyword. Replace it with 'Utils.Json Parse From String'.

JIRA: INTTEST-141
Change-Id: I2be3445629abbe6e105476ed8f2f99c416ed555e
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate 'Get Request' invocations (l2switch)

'Get Request' has been deprecated. Replace it with 'GET On Session'.
Also, update the RESTCONF URLs to follow the RFC 8040 format.

JIRA: INTTEST-141
Change-Id: Ie391e64a59f9fe950ddfbda2da1f7825351d40c2
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate request invocations (ovsdb)

The '* Request' and 'To Json' RequestsLibrary keywords have been
deprecated. Replace '* Request' keywords with '* On Session'.

'OVSDB.Log Request' is a duplicate of 'Utils.Log Content' - replace
the former with the latter.  'To Json', when pretty_print is false,
is replaced with 'Utils.Json Parse from String'.

JIRA: INTTEST-141
Change-Id: Ia0b98e5f68de460d363464372b59ef0c209c52af
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate request invocations (openflowplugin)

The '* Request' and 'To Json' RequestsLibrary keywords have been
deprecated. Replace '* Request' keywords with '* On Session'.

In the case of 'To Json', replace it with the 'Json Parse from String'
in Utils.robot when the pretty_print is false. When pretty_print is
required, use the Evaulate keyword with the json module to generate
properly formatted JSON string.

JIRA: INTTEST-141
Change-Id: I5a5842bf68870679196824661219be7e62c52d32
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate request invocations (controller)

The '* Request' and 'To Json' RequestsLibrary keywords have been
deprecated. Replace '* Request' keywords with '* On Session' and replace
'To Json' in ClusterManagement.robot with the 'Json Parse from String'
keyword in Utils.robot.

Also, fix some URLs based on RESTCONF Bierman draft.

JIRA: INTTEST-141
Change-Id: I75586bd86678755541ecf9161dac31c6326f63d9
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Use RFC 8040 URL for 'odl-mdsal-lowlevel-*' RPCs

The URLs for odl-mdsal-lowlevel-control-{control,target} module RPCs
have not been updated to RFC 8040 yet. Fix them up.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: I52afc3a94543567ed051d49a187bc1312febfbe8

Migrate request invocations for controller/NETCONF

The '* Request' keywords have been deprecated. Replace '* Request'
keywords with '* On Session'.

Also, covert Bierman URLs to the RFC 8040 format.

JIRA: INTTEST-141
Change-Id: Ie65aaa6a928ceaff0045f676b5cb84c33d2a4262
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate request invocations (aaa)

The '* Request' RequestsLibrary keyword has been deprecated.
'* Request' keywords have been replaced by '* On Session'.

JIRA: INTTEST-141
Change-Id: I00b92feced48fae4bc40ada42795d48f51e60df7
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate GoBgpLib.robot

The 'Get Request' RequestsLibrary keyword has been deprecated.
Migrate it to 'GET On Session'.

Change-Id: Ia520b59076383f3b68f9bd0e692ce8355f909e72
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Fix duplicate keywords

The 'Read_Text_Before_Prompt' keyword in ebgp_peers_basic.robot is
unnecessary since it's already defined in BGPcliKeywords.robot.
Remove the duplicate keyword.

Also, use explicit resource name for the keywords imported from
BGPcliKeywords.robot to make it more consistent and add a missing
resource imported by BGPcliKeywords.robot.

Change-Id: I817a58b04e4adc9e9c2c86b6f14065aa44e88d52
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate 020_bgp_functional_multipath.robot

The 'Get Request' RequestsLibrary keyword has been deprecated.
Migrate it to 'GET On Session' and fix the URL to use the RFC8040 path.

Change-Id: I122004fea42f15436084f00ed7b3b84ab8c1f748
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate ExaBgpLib.robot

The 'Get Request' RequestsLibrary keyword has been deprecated.
Migrate it to 'GET On Session'.

Change-Id: I262a907f8c5528611a62505f08c53490d04d5921
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate BgpOperations.robot

The '* Request' RequestsLibrary keywords have been deprecated.
Migrate to the new '* On Session' keywords.

Change-Id: Ie2341c550de276873719ea2d8b7179cf19832365
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Migrate 030_bgp_functional_evpn.robot

The '* Request' RequestsLibrary keywords have been deprecated.
Migrate to the new '* On Session' keywords.

Change-Id: I64d95352d4aaf003385d6095f3b72688cdb69893
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Fix PcepOperations requests

When 'url' for RequestsLibrary.Post_On_Session starts with a word that
complies with the pattern of URL scheme followed by a colon, e.g.
'network-topology-pcep:add-lsp', then it becomes the entire URL and
the base URL for the session is ignored by 'urljoin':

https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urljoin
https://datatracker.ietf.org/doc/html/rfc3986.html#section-3.1

To avoid this issue remove the common URL base path '/rests/operations'
from the session base URL and add it Post_on_Session.

Change-Id: I88c990788c41ff2772577f0302217e30f55c9fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Fix robot file format issues

There are some file format issues detected by Robotidy. Fix them up.

Change-Id: I12cd644428713cd1d8ff25b2766f27ae44743f64
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Specify url as explicit argument

With RFC8040 uris we end up specifying content=config and similar. This
is tripping up RF warning non-escaped '='s. Rather then escaping all
these, just use url= consistently across all invocations.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ifcf8c00629fc4237911e4fe270e3fab4811f1f91

Correctly space expected_status

The single space we have here gets escaped, leading to a test failure.
Fix that up.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ia1a52820dc728a6ecccc1e989aa05f89a8eac06d

Adapt create-device RPC input credentials

Adapt create-device RPC input to change introduced by: NETCONF-1187.

Now we have to use specific case for credentials. Note that RPC logic
is capable to encrypt provided credentials. Thus is safe to use
login-password case.

Change-Id: Ie962eda311b82173afecfde702139e59da61bb1a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Fix up PrefixCounting warning

RequestsLibrary is warning about missing url, as our url contains an
equality sign. Fix that up by adding an explicit assignment.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I66b2a38f72c3c267f5607975bc3cf7e0f876a2da

Use explicit RequestsLibrary.Create_Session reference

Follow what other parts of the CSIT suite does, which is explicitly
use RequestsLibrary.Create_Session.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I09837fe4d7b423fb4485d812a164d9ae284c76f0

Correct NETCONF device configuration

We are using deprecated leaves, which are now removed. Migrate to their
long-available replacements.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ie9b281e6067f58cdd30d46fc34c09005e9ef7025

Migrate NexusKeywords

Use 'GET On Session' instead of 'Get_Request'.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ib1dcb1c074b9bbd2f9082d8546ad2563cf24ab32

Migrate pcepuser.robot

Use 'GET On Session' instead of 'Get Request'.

Change-Id: I7895d9d0db9ab02518fc3be8ec8adeaedddbbcae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix expected_status types

expected_status needs to be a String, otherwise it leads to:
    InvalidExpectedStatus: 200

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ia95baf7b4bbf0869b466576c25f0527592a9c227

Update DAEXIM's netconf_mount payload

The payload is using legacy username/password leaves, which were removed
in netconf-7. Migrate to their replacements.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ib30cfe03069d3e39b0abc407b60ac1ce6f046ca6

Migrate 030_bgp_functional_evpn

Use POST On Session instead of deprecated Post Request.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I7cb8d21813c87b3214185a3f8599a2d0c85d369f

Do not use Get Request in PrefixCounting.robot

Migrate to use GET On Session instead.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I671a37306fdb4d66a92f02fbbfee6e0f08fb721b

Fix PcepOperations typos

We have two typos from previous patch, fix them up.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I522aa65d0141ba2f8d07cab7a214cd6eb2f7e14a

Fix DAEXIM import data

Test data here uses long-deprecated leaves, which were finally removed.
Migrate to use their replacements.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I0b7b2985971368e3d87379ce590e26b9cfdf57e2

Remove libraries for openstack

Removed librarives related to no more active openstack
project.

JIRA: INTTEST-140
Change-Id: I475a4084aea0929f46e6e4732b65e795abfe4e6f
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Optimize modules-state queries

We know the data is in operational: acquire just nonconfig content,
which is slightly faster, as it does not touch config datastore.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I7d86613748a78334de2681da8155882d1c303d7a

Migrate a few Get Request invocations

We have warnings about needing to migrate, this patch addresses three of
such sources.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I0fbc37c62fd9a9900c6eb329cdfedce8755a4476

Resurrect exceptions library

'Verify Exceptions' is a missing keyword now. Fix that by reverting a
part of c35e89803a9c5593d19215b87da3e305c8293142.

JIRA: INTTEST-140
Change-Id: Ia0bbfdf7225452fbe6969bce777183fe5119c1de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up PcepOperations

Use named arguments. Switch to POST On Session. Add a missing slash.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I042aa9e802721304f09e3a1952c032d3bf7877b9

Remove deployment for openstack

Removed deployment for no more active openstack project.

JIRA: INTTEST-140
Change-Id: Id24bc1f58eeea48aa1c710679ebfc9e8077cd5bf
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans and suites for openstack

Removed testplans and suites for no more active openstack
project.

JIRA: INTTEST-140
Change-Id: I3742f67e948318b5f0457a314b965d7a3138143f
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Define calcium stream

BGPCEP CSIT is failing with:
Dictionary '${Stream_dict}' has no key 'calcium'.

Fix that by defining proper entry.

Also, add the stream keywords and BGPCEP variable files for calcium.

Change-Id: Ib031455a00c0be81c747a4397e1de3f88e32cdb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Remove libraries and cleanup tsdr

Removed libraries and cleanup tsdr project remnants.

JIRA: INTTEST-140
Change-Id: Ic57771fd23b0fd95f629c0738b6aec2dd3353b8b
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables for tsdr

Removed variables for tsdr project.

JIRA: INTTEST-140
Change-Id: I1f0578c234453b288b3dac877ec6e4ce1c50eba5
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans and suites for tsdr

Removed testplans and suites for tsdr project.

JIRA: INTTEST-140
Change-Id: I484c40f47bd822f7b04161b2679917758f86a51e
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove remnants of sfc project

Removed remnants of sfc project.

JIRA: INTTEST-140
Change-Id: I2045d33434b890fb39dbc4491e1ee5c9ae95081b
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables for sfc

Removed variables for sfc project.

JIRA: INTTEST-140
Change-Id: I7918811d2c176cd294c53cf34c8ecd4b1a2d1b67
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans and suites for sfc

Removed testplans and suites for sfc project.

JIRA: INTTEST-140
Change-Id: Iba7934a045d348a2ee23b462e5e66d74c916be42
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables for vpnservice

Removed variables for vpnservice project.

JIRA: INTTEST-140
Change-Id: Ie8d980b51b916b6198af1c3cb2f9780c9dbca4fc
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans and suites for vpnservice

Removed testplans and suites for vpnservice project.

JIRA: INTTEST-140
Change-Id: If537c4af19d015f484f1e77cb457d8846bee6d54
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables and libraries for groupbasedpolicy

Removed variables and libraries for groupbasedpolicy project.
Cleaned up remnants of the project.

JIRA: INTTEST-140
Change-Id: I7376b7899147cfc0047d841e2e22b2873ef7ac8e
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans for groupbasedpolicy

Removed testplans for groupbasedpolicy project.

JIRA: INTTEST-140
Change-Id: I5748c87d41c7fd905120e7c7a15b25e49eba21c9
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove suites for groupbasedpolicy

Removed suites for no more active groupbasedpolicy project.

JIRA: INTTEST-140
Change-Id: Ib08a6d12c705d9a1ad37ba8fa1a200e79111cf1a
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove suites for netvirt

Removed test suites for netvirt project.

JIRA: INTTEST-140
Change-Id: Iea59e2149ae2b2a51d017968ef2076dab9de3e6b
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove code for capwap

Removed code for no more active capwap project.

JIRA: INTTEST-140
Change-Id: I5fe8c87f146e0a41b67c92aa8e6c734ca5946baa
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables and scripts for netvirt

Removed variables and scripts for netvirt project.
Adapted all other projects that was afected by this.

JIRA: INTTEST-140
Change-Id: I6c54434d40531d690c93307d2c7daa817e35b3b1
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove variables for genius

Removed variables for genius project and cleaned up
code after.

JIRA: INTTEST-140
Change-Id: I36e22fe0be68c3d71622c50d56801942a570ff48
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove code for genius

Removed code for no more active genius project.

JIRA: INTTEST-140
Change-Id: Ia509dbd4c6faa5361c161c015adffbc70bb607f7
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove openstack integration

Removed openstack integration and cleaned up remnants of
no more active openstack project.

JIRA: INTTEST-140
Change-Id: Id76b2ae4da2142390c450fde23e7e4ddb2b99674
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove testplans for netvirt

Removed testplans for no more active netvirt project.

JIRA: INTTEST-140
Change-Id: I4527c5a7b1c6621ae75e5441b338b48082febf5f
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Remove scriptplans for tsdr

Removed scriptplans for tsdr project.

JIRA: INTTEST-140
Change-Id: I4ee162f9e6e7c5e8c2fcf18d4e8e9b627550b6a3
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Pin robotframework for robotidy

Latest version of robotframework (7.0) requires robotidy 4.8.0 and
above:

https://github.com/MarketSquare/robotframework-tidy/releases/tag/4.8.0

Pin robotframework at 6.1.1 until robotidy can be upgraded.

Change-Id: I43725954fa2e327282ed5595882e11270bae6b8b
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Remove code for backuprestore

Removed code for no more active backuprestore project.

JIRA: INTTEST-140
Change-Id: Ifd69475d6858c25c5437ae2a262d4e2ff4cdaaae
Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech>

Bump pre-commit flake8 to 6.1.0

Adopt the latest version of flake8, 6.1.0, and fix the issues detected
by the new version.

Change-Id: Iadaea2b02d80fe0cefb6322694f1988708b5daed
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Run gitlint with tox

Verification of git message is failing because of a pip installation
issue:
https://github.com/jorisroovers/gitlint/issues/535
https://github.com/pypa/pip/issues/12372

The issue has been addressed for pip v23.3.2:
https://github.com/pypa/pip/releases/tag/23.3.2

but the virtual environment for the pre-commit hook does not appear to
have the version available yet.

Run the gitlint with tox directly until the issue is resolved in the
Jenkins environment.

Change-Id: I033240f8f7bb5a14217dbc763687ac490ae4b3d0
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Support both empty data formats

Depending on the active XML library the output of empty NETCONF data
can be either

<data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"/>

or

<data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"></data>

Support both options to make the test results more stable.

Change-Id: I65fe5c428a4d8da14ddc6bce2f411e02692c2659
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Use new URI for OpenAPI API document

The URI for OpenAPI API document was updated for Potassium
(NETCONF-1032). Use the new URI for Potassium and above.

Change-Id: I7260a0edd5d659880b3f5b96571fd14dce5dca51
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Add potassium stream keywords

Add new stream keywords to support potassium, current development
stream. Also, add BGPCEP test variable files for potassium.

Change-Id: Ie1db896a120cb899724f47d63d125e06fe4f781a
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Add argon stream keywords

Argon stream keywords have not been added yet. Add the missing keywords.

Change-Id: If55516d627024556d8bc24c365a02c25e15ab4e4
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Support only Neon+ distributions

Fluorine is not supported anymore, remove the keywords and update
their keywords to work as if the distro is always at least Neon.
Also eliminate If_At_Least_Neon macros, as they evaluate to true.

JIRA: INTTEST-133
Change-Id: Ia66484a24fcda9278e7d0117848c6492479a00cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Support only Fluorine+ distributions

Oxygen is not supported anymore, remove the keywords and update
their keywords to work as if the distro is always at least Fluorine.
Also eliminate If_At_Least_Fluorine macros, as they evaluate to true.

JIRA: INTTEST-133
Change-Id: I3d46034a5d261ea8d2a6bf3c97194dd5081c08bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Support only Oxygen+ distributions

Nitrogen is not supported anymore, remove the keywords and update
their keywords to work as if the distro is always at least Oxygen.
Also eliminate If_At_Least_Oxygen macros, as they evaluate to true.

JIRA: INTTEST-133
Change-Id: Ic048e57558cdf86f9785be191b55f7bfbb32cfd8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Support only Nitrogen+ distributions

Carbon is not supported anymore and these keywords are not referenced,
remove them. Also remove If_At_Least_Nitrogen keywords, as these are
considered always-true now.

JIRA: INTTEST-133
Change-Id: I453fdd301ba85aebe0138131bedf71ece9e47f58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Remove RFC8040 test plans

RFC8040-specific netconf-userfeatures CSIT jobs have been removed.
Clean up unused userfeatures-rfc8040 test plans.

Change-Id: Iaf7acaaaf455141908b6c800f0b2e45d16fde053
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Eliminate USE_RFC8040

We no more need USE_RFC8040 in csit/libraries/Restconf.robot.
Therefore it and all related logic was deleted in this patch.

JIRA: INTTEST-135
Change-Id: Icf2ef4883d07e6e4eab5da41d49bd1e7357686e0
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>

Rename netconf-impl to netconf-api

Rename netconf-impl component to netconf-api to maintain:
- compatibility with changes made in NETCONF-945

- backward compatibility of test suite because netconf-api
is present in older and newer netconf code

JIRA: INTTEST-136
Change-Id: I33bf095c1153750b988a9a10a0886b2bd1e7c1ea
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Set USE_RFC8040 to True

Set USE_RFC8040 to True because we are no more using bierman restconf.

JIRA: INTTEST-134
Change-Id: I7dd761adb69b5c98442442cc1046c04fe0c6e186
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Update gitlint configuration

Update pre-commit configuration for gitlint to add gitlint-ci, a hook
for CI verification, and use it during tox verification.

Create separate testenvs for installation/uninstallation/update of
pre-commit hook scripts. And also add a testenv for gitlint to run
the command with tox.

Change-Id: I3842539a7ec8d2851ff1b48c2633d964017c70cf
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update StreamDict to include argon

Fixes a RF error:
 Setting variable '${odl_stream_check }' failed:
    Dictionary '${Stream_dict}' has no key 'argon'.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I721d99282251fb85ad79d84b4d10917b5378048e

Add CSIT variables for Argon

bgpcep-csit-1node-userfeatures-all-argon is failing due to not being
able to find variables for argon -- add symlinks to repair that.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: I88dbf55e56dcc2ab0b0386530e9aad65221c9bfe

Fix Get On Session errors

'Get On Session' has different arguments and requirements but some of
the conversions from 'Get Request' to 'Get On Session' didn't take those
into account.

To prevent confusion that '=' is used for parameters when it is in fact
part of the URL path, specify 'url' a keyword argument, instead of
positional, and separate parameters into 'params' when possible.

Also, set 'odl-pretty-print' parameter for Phosphorus or later since it
is not available before the version. Accept any status code when there
is a separate step to check valid status codes.

Change-Id: Ibd41fe31090eb0406abd16e80b3e6168d424bc74
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Get rid of deprecation warnings

First patch to replace deprecated RequestsLibrary keywords
{Get,Put,Post,Put,Delete}_Request with {Get,Put,Post,Delete}_On_Session.

Signed-off-by: gvrangan <gvrangan@gmail.com>
Change-Id: I2402538bb11be2f93f4157bdbd0ec8280a7eba7e

Replace robotframework-tidy-wrapper with robotidy

Built-in Robotframework Tidy tool has been deprecated and the pre-commit
hook (robotframework-tidy-wrapper) based on the tool has not been
updated for more than 2 years.

Replace the pre-commit hook with robotidy as recommended.

JIRA: INTTEST-132
Change-Id: I94f26ec87513c504f878069b787cdc0c6a6e34e6
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 18

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- tools/deployment

JIRA: INTTEST-132
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: Ib5094ed820f09fc0c426c6ac794d43520f924778

Update Robot Framework format - step 17

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/variables

JIRA: INTTEST-132
Change-Id: I9c29223fed6b2e9602fc3b9b1a139eda02077af0
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 16

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/unimgr
- csit/suites/usc
- csit/suites/vpnservice
- csit/suites/vtn
- csit/suites/yangtools

JIRA: INTTEST-132
Change-Id: I6d5ed935cde554663d5712895f7cab0a506c02f7
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 15

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/telemetry
- csit/suites/test
- csit/suites/topoprocessing
- csit/suites/tsdr

JIRA: INTTEST-132
Change-Id: I001176adf643a580336d52b23b00fb01d229a975
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 14

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/packetcable
- csit/suites/persistence
- csit/suites/sfc
- csit/suites/sxp

JIRA: INTTEST-132
Change-Id: I3fafc815aeda8bf74c4f12ae889102308d8b72dd
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 13

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/openstack
- csit/suites/ovsdb

JIRA: INTTEST-132
Change-Id: I52fb7223105498e40ed55869d70af255e216215b
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 12

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/openflowplugin

JIRA: INTTEST-132
Change-Id: Ia8a0c2dc6a2b51dbeb7b98a11452488f8bd9056c
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 11

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/netvirt
- csit/suites/ocpplugin
- csit/suites/odlmicro
- csit/suites/odltools

JIRA: INTTEST-132
Change-Id: Ie786027a441055fa7bd79bb3063213e725049b13
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 10

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/netconf

JIRA: INTTEST-132
Change-Id: Id6fc77ae951956e740382e9f74be998536fefeab
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 9

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/l2gw
- csit/suites/l2switch
- csit/suites/lacp
- csit/suites/lispflowmapping
- csit/suites/mdsal
- csit/suites/nemo

JIRA: INTTEST-132
Change-Id: Ic20919465e5fd30d73e84405548cc62115c951b9
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 8

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/integration
- csit/suites/iotdm
- csit/suites/jsonrpc

JIRA: INTTEST-132
Change-Id: Ic64caa05257df2e2fc603c63139f4c0eaa8ca173
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 7

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/groupbasedpolicy

JIRA: INTTEST-132
Change-Id: I3d2e96af277966bad31af48fb15ea591c84251ff
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 6

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/daexim
- csit/suites/didm
- csit/suites/distribution
- csit/suites/dluxapps
- csit/suites/examples
- csit/suites/genius

JIRA: INTTEST-132
Change-Id: I26e9e23b5e76c37fcdc2bbb779f42d8fe95e7a59
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 5

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/controller

JIRA: INTTEST-132
Change-Id: I91e3d42d4f234dc6e4204f30b8b846ea72850a15
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 4

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/bier
- csit/suites/capwap
- csit/suites/cardinal
- csit/suites/centinel

JIRA: INTTEST-132
Change-Id: I3296eb336d9473a2d86437461e65035787bd57ae
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 3

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/bgpcep

JIRA: INTTEST-132
Change-Id: I0f93c6efab9f10a433285fd3562e9fef29993cf2
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Update Robot Framework format - step 2

Robotidy has stricter formatting rules for line width, alignment,
section ordering & spacing, etc.

Update the format of Robot Framework files in the following directory
with Robotidy:

- csit/suites/aaa
- csit/suites/alto
- csit/suites/backuprestore

JIRA: INTTEST-132
Change-Id: Iba4d4dc8745a915faf94f4d0f45fe13881e33581
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>