From dc4457ef1ee6b1a5b8723265ec9bab885c069eb5 Mon Sep 17 00:00:00 2001 From: Jamo Luhrsen Date: Mon, 7 Jan 2019 11:27:48 -0800 Subject: [PATCH] Use $ for list arg passed in to builtIn kw If a list is passed in with the @ syntax, it's expanded first the first two elements are used for the BuiltIn keyword. So the result is not what we expect. I noticed it in this false failure: https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-1cmb-0ctl-0cmp-openstack-queens-upstream-stateful-snat-conntrack-fluorine/154/robot-plugin/log_full.html.gz#s1-s11-k1-k2-k6-k5 it needs to come in with the $ syntax so the keyword can use it internally to loop over, and compare to the 2nd argument. Change-Id: Iea8cda9f8f7357cac3399cf7756822cc743cc6cd Signed-off-by: Jamo Luhrsen --- csit/suites/netvirt/elan/elan_service_recovery.robot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/csit/suites/netvirt/elan/elan_service_recovery.robot b/csit/suites/netvirt/elan/elan_service_recovery.robot index 916a361f90..1dc2892db3 100644 --- a/csit/suites/netvirt/elan/elan_service_recovery.robot +++ b/csit/suites/netvirt/elan/elan_service_recovery.robot @@ -95,8 +95,8 @@ Create Nova VMs \ OpenStackOperations.Create Vm Instance With Port On Compute Node @{PORT_LIST}[${index + 2}] @{NET_2_VMS}[${index}] ${OS_CMP2_HOSTNAME} sg=${SECURITY_GROUP} @{NET_1_VM_IPS} ${NET_1_DHCP_IP} = OpenStackOperations.Get VM IPs @{NET_1_VMS} @{NET_2_VM_IPS} ${NET_2_DHCP_IP} = OpenStackOperations.Get VM IPs @{NET_2_VMS} - BuiltIn.Should Not Contain @{NET_1_VM_IPS} None - BuiltIn.Should Not Contain @{NET_2_VM_IPS} None + BuiltIn.Should Not Contain ${NET_1_VM_IPS} None + BuiltIn.Should Not Contain ${NET_2_VM_IPS} None BuiltIn.Should Not Contain ${NET_1_DHCP_IP} None BuiltIn.Should Not Contain ${NET_2_DHCP_IP} None -- 2.36.6