Code Review / mdsal.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: fe28fd1) | patch
Fix RPC method name conflict with JLS 66/86466/1
authormiroslav.kovac <miroslav.kovac@pantheon.tech>
Mon, 16 Dec 2019 16:28:41 +0000 (17:28 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 18 Dec 2019 07:50:39 +0000 (08:50 +0100)
commit42a49525a3b291a4af093090a54ab4c88a2313ca
tree3fb3bce8301bf071e99535c6178e8ec2bf56fdbctree | snapshot
parentfe28fd1721be937add6bd220c686ed023c6f0529commit | diff
Fix RPC method name conflict with JLS

When we are constructing the method name for use with the RPC
provider interface we need to pay attention to conflicts with
JLS reserved words.

If such a conflict occurs, append a single '$' to the name, so
that we have a valid method name.

JIRA: MDSAL-500
Change-Id: Ifb533e2daa71bc9d1780a5d8eb48da6ce3b2d209
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6e6ebc43866204667658f8bbf7cfb6233caffdc7)
binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingToNormalizedNodeCodec.java diff | blob | history
binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/test/Mdsal500Test.java [new file with mode: 0644] blob
binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/impl/AbstractTypeGenerator.java diff | blob | history
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/Mdsal500Test.java [new file with mode: 0644] blob
binding/mdsal-binding-generator-impl/src/test/resources/mdsal-500.yang [new file with mode: 0644] blob
binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/naming/BindingMapping.java diff | blob | history
binding/mdsal-binding-test-model/src/main/yang/mdsal-500.yang [new file with mode: 0644] blob
MD-SAL: Model-Driven Service Adaptation Layer