Code Review / mdsal.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: ab5f110) | patch
Refactor DataObjectCodecContext.getBindingChildValue() 23/77623/3
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 8 Nov 2018 14:01:07 +0000 (15:01 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 8 Nov 2018 14:30:33 +0000 (15:30 +0100)
commit5376803e1c41d25f4c8e6e2ca38dc5e4d9fc18fb
tree13151a51cb3b8d942b0d19468b9ee9cd0cd97a6ctree | snapshot
parentab5f1103fd61e62f21aa751f550f013c5ff40a3bcommit | diff
Refactor DataObjectCodecContext.getBindingChildValue()

Using instanceof checks is an OOP anti-pattern, which we do not
want here anyways. Generalize NodeCodecContext.defaultObject()
to return null by default and refactor decoding to rely on it,
with LeafNodeCodecContext returning whatever it has as a default
value.

Change-Id: I2b58bc7f1a16496cf6bc93fd7a33aec38f864597
JIRA: MDSAL-18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectCodecContext.java diff | blob | history
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/LeafNodeCodecContext.java diff | blob | history
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/NodeCodecContext.java diff | blob | history
MD-SAL: Model-Driven Service Adaptation Layer