From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 26 Apr 2022 16:10:52 +0000 (+0200)
Subject: Deprecate RpcServiceInvoker.from(Class)
X-Git-Tag: v10.0.0~86
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=mdsal.git;a=commitdiff_plain;h=32e17047b8c4d19a735534db25ddcce2937d0794

Deprecate RpcServiceInvoker.from(Class)

Invokers are considered an implementation detail and this particular
method is not used anywhere except tests. Schedule it for removal along
with ClassBasedRpcServiceInvoker it uses.

Change-Id: I4d8c57bbd982ea6eae21706d909af16495f29f56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvoker.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvoker.java
index 4cdfa94cc1..fdd395f752 100644
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvoker.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvoker.java
@@ -19,6 +19,7 @@ import org.opendaylight.mdsal.binding.spec.reflect.BindingReflections;
 import org.opendaylight.yangtools.yang.binding.RpcService;
 import org.opendaylight.yangtools.yang.common.QName;
 
+@Deprecated(forRemoval = true, since = "9.0.3")
 final class ClassBasedRpcServiceInvoker extends AbstractMappedRpcInvoker<String> {
     private static final LoadingCache<Class<? extends RpcService>, RpcServiceInvoker> INVOKERS =
             CacheBuilder.newBuilder().weakKeys()
diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvoker.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvoker.java
index d88e4d2c49..0b8016dbff 100644
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvoker.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvoker.java
@@ -37,7 +37,9 @@ public abstract class RpcServiceInvoker {
      *
      * @param type RpcService interface, which was generated from model.
      * @return Cached instance of {@link RpcServiceInvoker} for supplied RPC type.
+     * @deprecated This method is not used by the adapter and is scheduled for removal.
      */
+    @Deprecated(forRemoval = true, since = "9.0.3")
     public static RpcServiceInvoker from(final Class<? extends RpcService> type) {
         return ClassBasedRpcServiceInvoker.instanceFor(type);
     }
diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvokerTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvokerTest.java
index edca88fb83..65b909fb7f 100644
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvokerTest.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/ClassBasedRpcServiceInvokerTest.java
@@ -16,8 +16,8 @@ import org.opendaylight.yangtools.yang.binding.DataContainer;
 import org.opendaylight.yangtools.yang.binding.RpcService;
 import org.opendaylight.yangtools.yang.common.QName;
 
+@Deprecated(forRemoval = true, since = "9.0.3")
 public class ClassBasedRpcServiceInvokerTest {
-
     @Test
     public void qnameToKeyTest() throws Exception {
         final ClassBasedRpcServiceInvoker classBasedRpcServiceInvoker =
diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvokerTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvokerTest.java
index 8cdabe9530..7e3ac44c42 100644
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvokerTest.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/RpcServiceInvokerTest.java
@@ -32,6 +32,7 @@ public class RpcServiceInvokerTest {
             QName.create(QNameModule.create(XMLNamespace.of("testURI"), Revision.of("2017-10-26")), "test"), method)));
     }
 
+    @Deprecated(forRemoval = true)
     @Test(expected = IllegalArgumentException.class)
     public void fromWithExceptionTest() {
         RpcServiceInvoker.from(RpcService.class);