From: Robert Varga <robert.varga@pantheon.tech>
Date: Sat, 13 Jan 2024 18:07:09 +0000 (+0100)
Subject: Convert mdsal-common-api to bnd-parent
X-Git-Tag: v13.0.0~33
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=mdsal.git;a=commitdiff_plain;h=737deeaa5fa3441a3b215d09c5e3292ee3b333f1

Convert mdsal-common-api to bnd-parent

Introduce a bnd-parent, which does not use maven-bundle-plugin, and
convert mdsal-common-api to use it.

Change-Id: I74046224b85e70970914867b56b8bcb3d31680ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/bnd-parent/pom.xml b/bnd-parent/pom.xml
new file mode 100644
index 0000000000..ad961d961d
--- /dev/null
+++ b/bnd-parent/pom.xml
@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- vi: set et smarttab sw=4 tabstop=4: -->
+<!--
+ Copyright (c) 2024 PANTHEON.tech, s.r.o. and others.  All rights reserved.
+
+ This program and the accompanying materials are made available under the
+ terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ and is available at http://www.eclipse.org/legal/epl-v10.html
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.opendaylight.yangtools</groupId>
+        <artifactId>bnd-parent</artifactId>
+        <version>13.0.0</version>
+        <relativePath/>
+    </parent>
+
+    <groupId>org.opendaylight.mdsal</groupId>
+    <artifactId>bnd-parent</artifactId>
+    <version>13.0.0-SNAPSHOT</version>
+    <packaging>pom</packaging>
+    <name>${project.artifactId}</name>
+    <description>Bundle parent (bnd-based)</description>
+
+    <dependencyManagement>
+        <dependencies>
+            <dependency>
+                <groupId>org.opendaylight.mdsal</groupId>
+                <artifactId>mdsal-artifacts</artifactId>
+                <version>13.0.0-SNAPSHOT</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>
+            <dependency>
+                <groupId>net.bytebuddy</groupId>
+                <artifactId>byte-buddy</artifactId>
+                <version>1.14.11</version>
+            </dependency>
+        </dependencies>
+    </dependencyManagement>
+
+    <scm>
+        <connection>scm:git:ssh://git.opendaylight.org:29418/mdsal.git</connection>
+        <developerConnection>scm:git:ssh://git.opendaylight.org:29418/mdsal.git</developerConnection>
+        <tag>HEAD</tag>
+        <url>https://wiki.opendaylight.org/display/ODL/MD-SAL</url>
+    </scm>
+</project>
diff --git a/bundle-parent/pom.xml b/bundle-parent/pom.xml
index 6af795f2cc..5035d11215 100644
--- a/bundle-parent/pom.xml
+++ b/bundle-parent/pom.xml
@@ -28,16 +28,11 @@
         <dependencies>
             <dependency>
                 <groupId>org.opendaylight.mdsal</groupId>
-                <artifactId>mdsal-artifacts</artifactId>
+                <artifactId>bnd-parent</artifactId>
                 <version>13.0.0-SNAPSHOT</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
-            <dependency>
-                <groupId>net.bytebuddy</groupId>
-                <artifactId>byte-buddy</artifactId>
-                <version>1.14.11</version>
-            </dependency>
         </dependencies>
     </dependencyManagement>
 
diff --git a/common/mdsal-common-api/pom.xml b/common/mdsal-common-api/pom.xml
index 116acdda8c..5e888725d1 100644
--- a/common/mdsal-common-api/pom.xml
+++ b/common/mdsal-common-api/pom.xml
@@ -12,13 +12,18 @@
 
     <parent>
         <groupId>org.opendaylight.mdsal</groupId>
-        <artifactId>bundle-parent</artifactId>
+        <artifactId>bnd-parent</artifactId>
         <version>13.0.0-SNAPSHOT</version>
-        <relativePath>../../bundle-parent</relativePath>
+        <relativePath>../../bnd-parent</relativePath>
     </parent>
 
     <artifactId>mdsal-common-api</artifactId>
-    <packaging>bundle</packaging>
+    <packaging>jar</packaging>
+
+    <properties>
+        <!-- FIXME: fix these up and set maven.javadoc.failOnWarnings=true -->
+        <doclint>all,-missing</doclint>
+    </properties>
 
     <dependencies>
         <dependency>
@@ -47,11 +52,4 @@
             <artifactId>mockito-configuration</artifactId>
         </dependency>
     </dependencies>
-
-    <scm>
-        <connection>scm:git:http://git.opendaylight.org/gerrit/mdsal.git</connection>
-        <developerConnection>scm:git:ssh://git.opendaylight.org:29418/mdsal.git</developerConnection>
-        <tag>HEAD</tag>
-        <url>https://wiki.opendaylight.org/view/MD-SAL:Main</url>
-    </scm>
 </project>
diff --git a/common/mdsal-common-api/src/main/java/module-info.java b/common/mdsal-common-api/src/main/java/module-info.java
index 5aad096014..575934fe39 100644
--- a/common/mdsal-common-api/src/main/java/module-info.java
+++ b/common/mdsal-common-api/src/main/java/module-info.java
@@ -14,4 +14,5 @@ module org.opendaylight.mdsal.common.api {
 
     // Annotations
     requires static transitive org.eclipse.jdt.annotation;
+    requires static org.osgi.annotation.bundle;
 }
diff --git a/common/mdsal-common-api/src/main/java/org/opendaylight/mdsal/common/api/package-info.java b/common/mdsal-common-api/src/main/java/org/opendaylight/mdsal/common/api/package-info.java
new file mode 100644
index 0000000000..ef64dd907b
--- /dev/null
+++ b/common/mdsal-common-api/src/main/java/org/opendaylight/mdsal/common/api/package-info.java
@@ -0,0 +1,12 @@
+/*
+ * Copyright (c) 2024 PANTHEON.tech, s.r.o. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+/**
+ * Common MD-SAL concepts.
+ */
+@org.osgi.annotation.bundle.Export
+package org.opendaylight.mdsal.common.api;
diff --git a/pom.xml b/pom.xml
index 0890374399..fc07e2db60 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,6 +29,7 @@
 
     <modules>
         <module>artifacts</module>
+        <module>bnd-parent</module>
         <module>bundle-parent</module>
         <module>common</module>
         <module>docs</module>