From: Robert Varga <robert.varga@pantheon.tech>
Date: Sat, 21 Oct 2023 03:43:30 +0000 (+0200)
Subject: Make LambdaTarget a record
X-Git-Tag: v12.0.3~2
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=mdsal.git;a=commitdiff_plain;h=c71fc09c29e93c05e3f0aeb86809ddfdab3f60e7

Make LambdaTarget a record

We have a FIXME for efficiency improvement, address it.

Change-Id: If09bdb15b83b5e83114435456f4e4d1df4344e0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/LambdaDecoder.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/LambdaDecoder.java
index d5d5cd43da..9601d6233b 100644
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/LambdaDecoder.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/LambdaDecoder.java
@@ -7,10 +7,9 @@
  */
 package org.opendaylight.mdsal.binding.dom.adapter.query;
 
-import static com.google.common.base.Verify.verify;
 import static java.util.Objects.requireNonNull;
 
-import com.google.common.base.MoreObjects;
+import com.google.common.base.VerifyException;
 import com.google.common.cache.CacheBuilder;
 import com.google.common.cache.CacheLoader;
 import com.google.common.cache.LoadingCache;
@@ -21,8 +20,8 @@ import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
 import java.util.function.Function;
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.opendaylight.mdsal.binding.api.query.MatchBuilderPath.LeafReference;
-import org.opendaylight.yangtools.concepts.Immutable;
 
 /**
  * Utility class for forcing decoding lambda instances to the method being invoked. The theory here is that
@@ -49,44 +48,37 @@ import org.opendaylight.yangtools.concepts.Immutable;
  * messier, less type-safe and a perf-killer.
  */
 final class LambdaDecoder {
-    // FIXME: when we have JDK16: this should be a record
-    static final class LambdaTarget implements Immutable {
-        final String targetClass;
-        final String targetMethod;
-
-        LambdaTarget(final String targetClass, final String targetMethod) {
-            this.targetClass = requireNonNull(targetClass);
-            this.targetMethod = requireNonNull(targetMethod);
-        }
-
-        @Override
-        public String toString() {
-            return MoreObjects.toStringHelper(this).add("class", targetClass).add("method", targetMethod).toString();
+    @NonNullByDefault
+    record LambdaTarget(String targetClass, String targetMethod) {
+        LambdaTarget {
+            requireNonNull(targetClass);
+            requireNonNull(targetMethod);
         }
     }
 
     private static final LoadingCache<Class<?>, Method> REPLACE_CACHE = CacheBuilder.newBuilder()
-            .weakKeys().weakValues().build(new CacheLoader<Class<?>, Method>() {
-                @Override
-                public Method load(final Class<?> key) throws PrivilegedActionException {
-                    return AccessController.doPrivileged((PrivilegedExceptionAction<Method>) () -> {
-                        final Method method = key.getDeclaredMethod("writeReplace");
-                        method.setAccessible(true);
-                        return method;
-                    });
-                }
-            });
+        .weakKeys().weakValues().build(new CacheLoader<Class<?>, Method>() {
+            @Override
+            public Method load(final Class<?> key) throws PrivilegedActionException {
+                return AccessController.doPrivileged((PrivilegedExceptionAction<Method>) () -> {
+                    final var method = key.getDeclaredMethod("writeReplace");
+                    method.setAccessible(true);
+                    return method;
+                });
+            }
+        });
     private static final LoadingCache<LeafReference<?, ?>, LambdaTarget> LAMBDA_CACHE = CacheBuilder.newBuilder()
-            .weakKeys().build(new CacheLoader<LeafReference<?, ?>, LambdaTarget>() {
-                @Override
-                public LambdaTarget load(final LeafReference<?, ?> ref) throws Exception {
-                    final Object replaced = REPLACE_CACHE.get(ref.getClass()).invoke(ref);
-                    verify(replaced instanceof SerializedLambda, "Unexpected replaced object %s", replaced);
-                    final SerializedLambda serialized = (SerializedLambda) replaced;
+        .weakKeys().build(new CacheLoader<LeafReference<?, ?>, LambdaTarget>() {
+            @Override
+            public LambdaTarget load(final LeafReference<?, ?> ref) throws Exception {
+                final var replaced = REPLACE_CACHE.get(ref.getClass()).invoke(ref);
+                if (replaced instanceof SerializedLambda serialized) {
                     return new LambdaTarget(serialized.getImplClass().replace('/', '.'),
                         serialized.getImplMethodName());
                 }
-            });
+                throw new VerifyException("Unexpected replaced object " + replaced);
+            }
+        });
 
     private LambdaDecoder() {
         // Hidden on purpose
diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/QueryBuilderState.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/QueryBuilderState.java
index 65fd02ff53..3fc1316d81 100644
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/QueryBuilderState.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/query/QueryBuilderState.java
@@ -74,9 +74,9 @@ final class QueryBuilderState {
         verify(targetSchema instanceof DataNodeContainer, "Unexpected target schema %s", targetSchema);
 
         final LambdaTarget targetLeaf = LambdaDecoder.resolveLambda(ref);
-        verify(targetLeaf.targetClass.equals(bindingPath.getTargetType().getName()), "Mismatched target %s and path %s",
-            targetLeaf, bindingPath);
-        final NodeIdentifier childId = factory.findChild((DataNodeContainer) targetSchema, targetLeaf.targetMethod);
+        verify(targetLeaf.targetClass().equals(bindingPath.getTargetType().getName()),
+            "Mismatched target %s and path %s", targetLeaf, bindingPath);
+        final NodeIdentifier childId = factory.findChild((DataNodeContainer) targetSchema, targetLeaf.targetMethod());
         final YangInstanceIdentifier absTarget = fromBinding(bindingPath);
         final YangInstanceIdentifier relTarget = absTarget.relativeTo(absoluteSelect)
                 .orElseThrow(() -> new IllegalStateException(absoluteSelect + " is not an ancestor of " + absTarget));