From: Robert Varga <robert.varga@pantheon.tech>
Date: Sat, 16 Dec 2023 20:28:26 +0000 (+0100)
Subject: Modernize ListGenerator
X-Git-Tag: v13.0.0~74
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=mdsal.git;a=commitdiff_plain;h=dec1635b77bf6ef64c1d71db07bbcba69b736744

Modernize ListGenerator

Use local variable type inference. Also use local variables for keyGen
checking so as to eliminate false warnings.

Change-Id: Ic85f57228e42cfbc6cfe1f4a2dbd16b2798934b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-generator/src/main/java/org/opendaylight/mdsal/binding/generator/impl/reactor/ListGenerator.java b/binding/mdsal-binding-generator/src/main/java/org/opendaylight/mdsal/binding/generator/impl/reactor/ListGenerator.java
index c318b92a65..7e1ab88bfe 100644
--- a/binding/mdsal-binding-generator/src/main/java/org/opendaylight/mdsal/binding/generator/impl/reactor/ListGenerator.java
+++ b/binding/mdsal-binding-generator/src/main/java/org/opendaylight/mdsal/binding/generator/impl/reactor/ListGenerator.java
@@ -15,7 +15,6 @@ import org.opendaylight.mdsal.binding.generator.impl.rt.DefaultListRuntimeType;
 import org.opendaylight.mdsal.binding.model.api.GeneratedType;
 import org.opendaylight.mdsal.binding.model.api.MethodSignature.ValueMechanics;
 import org.opendaylight.mdsal.binding.model.api.Type;
-import org.opendaylight.mdsal.binding.model.api.type.builder.GeneratedTypeBuilder;
 import org.opendaylight.mdsal.binding.model.api.type.builder.GeneratedTypeBuilderBase;
 import org.opendaylight.mdsal.binding.model.api.type.builder.MethodSignatureBuilder;
 import org.opendaylight.mdsal.binding.model.ri.Types;
@@ -59,18 +58,19 @@ final class ListGenerator extends CompositeSchemaTreeGenerator<ListEffectiveStat
 
     @Override
     GeneratedType createTypeImpl(final TypeBuilderFactory builderFactory) {
-        final GeneratedTypeBuilder builder = builderFactory.newGeneratedTypeBuilder(typeName());
+        final var builder = builderFactory.newGeneratedTypeBuilder(typeName());
         addImplementsChildOf(builder);
         addAugmentable(builder);
         addUsesInterfaces(builder, builderFactory);
         addConcreteInterfaceMethods(builder);
 
-        final ModuleGenerator module = currentModule();
+        final var module = currentModule();
         module.addQNameConstant(builder, localName());
 
-        if (keyGen != null) {
+        final var local = keyGen;
+        if (local != null) {
             // Add yang.binding.Identifiable and its key() method
-            final GeneratedType keyType = keyGen.getGeneratedType(builderFactory);
+            final var keyType = local.getGeneratedType(builderFactory);
             builder.addImplementsType(keyAware(keyType));
             builder.addMethod(Naming.KEY_AWARE_KEY_NAME)
                 .setReturnType(keyType)
@@ -88,16 +88,17 @@ final class ListGenerator extends CompositeSchemaTreeGenerator<ListEffectiveStat
     }
 
     private @Nullable KeyRuntimeType keyRuntimeType() {
-        final var gen = keyGen;
-        return gen != null ? gen.runtimeType().orElseThrow() : null;
+        final var local = keyGen;
+        return local != null ? local.runtimeType().orElseThrow() : null;
     }
 
     @Override
     Type methodReturnType(final TypeBuilderFactory builderFactory) {
-        final Type generatedType = super.methodReturnType(builderFactory);
+        final var generatedType = super.methodReturnType(builderFactory);
         // We are wrapping the generated type in either a List or a Map based on presence of the key
-        if (keyGen != null && statement().ordering() == Ordering.SYSTEM) {
-            return Types.mapTypeFor(keyGen.getGeneratedType(builderFactory), generatedType);
+        final var local = keyGen;
+        if (local != null && statement().ordering() == Ordering.SYSTEM) {
+            return Types.mapTypeFor(local.getGeneratedType(builderFactory), generatedType);
         }
 
         return Types.listTypeFor(generatedType);
@@ -105,10 +106,9 @@ final class ListGenerator extends CompositeSchemaTreeGenerator<ListEffectiveStat
 
     @Override
     MethodSignatureBuilder constructGetter(final GeneratedTypeBuilderBase<?> builder, final Type returnType) {
-        final MethodSignatureBuilder ret = super.constructGetter(builder, returnType)
-            .setMechanics(ValueMechanics.NULLIFY_EMPTY);
+        final var ret = super.constructGetter(builder, returnType).setMechanics(ValueMechanics.NULLIFY_EMPTY);
 
-        final MethodSignatureBuilder nonnull = builder
+        final var nonnull = builder
             .addMethod(Naming.getNonnullMethodName(localName().getLocalName()))
             .setReturnType(returnType)
             .setDefault(true);