Clean up constant reference

We have two methods with the same name, make sure we use the right
constant when referencing it.

JIRA: MDSAL-852
Change-Id: I7628d2c997e3c62895984d6d85672c65ff9f0ce7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Override Rpc/Action invoke method

Add a plain @Override method for Rpc/Action's invoke method, so that it
is manifested in the generated type.

JIRA: MDSAL-852
Change-Id: I7db7c9036bdb3051ae48a903b66df933fb338fae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 078d561c79e3fcf57b2bfd5d6b50c4502288781a)
(cherry picked from commit ddd6615c50aa56f9a35c216b6ae71b6910ad4c2a)

Capture collection type class

Improve CodeHelpers safety by not losing Class type.

Change-Id: I585afdbda3328b018764627631dff7c8df372c01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2840f8a13a244834a831614d96a1411b3add3286)
(cherry picked from commit 6b33f21070f1fef0d42575290b439d52a4e74233)

Use Locale.ROOT for toUpperCase

We can just assert this is the root locale, not a some particular
language.

Change-Id: Ibce067abf252162740a9c6ed88a3beff99f455b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f2572480048c7d2017ee88f65a22b2eabe0dd46b)
(cherry picked from commit 8e29ff200b8be981d5ca602fda773fe6a81de60c)

Bump byte-buddy to 1.14.11

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.10
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.11

Change-Id: I14982abcc38545c72afce2abf9ffcd613534f5c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c3613aa89ab5619abc59ac6e0e6890a9041249c7)

Fix wrong annotation use

Use JDT annotation instead of SpotBugs, reducing our exposure.

Change-Id: I1fc1e13c5ae476a456a1ffd4db7182f118985945
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f052b186f3f1c7c314ab71a8cd0b4df4c00fda1e)
(cherry picked from commit e90a761128215f0f5520e6fb193ea081361a8044)

Move binding.model.api documentation

Package documentation resides in the wrong file, move it.

Change-Id: I77d1c5f3b411df7ebb855ccaeb6c7c8d9d1184cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e71e1be48c76398867c75d098e00b76ddf271cd8)
(cherry picked from commit c4514d83d892337289adc19d1e059085c416ee60)

Add (DOM)DataTreeIdentifier serialization proxies

Further evolution of these two classes will require allowing for two
distinct specializations.

In order to be able to do that, we need to disconnect them from their
serial form.

This patch instroduces serialization proxies, which know how to write
out and read in these objects without referencing their class name.

JIRA: MDSAL-845
Change-Id: I2b50d3aa5f752d6181dab991a5a8282b079b16df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9286037f2852d197c4384511fce97c551e2b8dc3)
(cherry picked from commit 9e23304d266d00210f1aeec57a99a1d8694caffe)

Use compareAndExchange() to set closeFuture

Java 9+ gives us a convenient way to ensure null-safety in this CAS
operation -- compareAndExchange() returns the witness value, i.e.
we get the value instead of a plain boolean false.

Change-Id: I636b0f084170d42bbd99490577917afefe5145e2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b61b30a4b2be38c8629bf9c5d66d05609db3be1c)
(cherry picked from commit aebfa4e09d2b35c8da3fb88d8a5883d84dab6b11)

Make sure listeners are immutable

We guarantee DOMNotificationRouter.listeners to be immutable. Make sure
the field has the correct type to prevent confusion.

Change-Id: Ia4b86c00bdd0517182d4ec0ad63b7f903d3c4ee7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6278245ab37ad9764d4a88c337e8a87631d2c5c9)
(cherry picked from commit 7bfdc19dabf61f0e84ebc02b57385b5912d51a0a)

Clean up DataTreeIdentifier a bit

Use a simple hashCode() implementation and instanceof pattern to
simplify equals().

Change-Id: I1312468eb97fad1991366f04970b3c2db27b6ff0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ccf116abaf3eb6615f9391344ab692fb9734f2ff)

Bump verions to 11.0.16-SNAPSHOT

This starts the next development iteration.

Change-Id: I4d922c44a17b0472ca0358073b46e7e5b0ca52e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release mdsal

Bump upstreams

Adopt:
- odlparent-12.0.10
- yangtools-10.0.12

Change-Id: Ib05b76ac21c3ee9d7d97d1bf8e0e7ad12eb12196
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.15-SNAPSHOT

This starts the next development iteration.

Change-Id: I6105936cb698d9865c6f0eece06cf01517127f40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release mdsal

Make LambdaTarget a record

We have a FIXME for efficiency improvement, address it.

Change-Id: If09bdb15b83b5e83114435456f4e4d1df4344e0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c71fc09c29e93c05e3f0aeb86809ddfdab3f60e7)

Bump upstreams

Adopt:
- odlparent-12.0.9
- yangtools-10.0.11

Change-Id: I7e7d4d3e48601ee9789326b223d2b129321cda89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.9

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.9

Change-Id: I254907a6467e8d3d76d165bd4f3c22a379545eb7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3a72d85e530e4f95afa6064edd0dd5b23030d956)

Bump versions to 11.0.14-SNAPSHOT

This starts the next development iteration.

Change-Id: I16084391ba22291efdd0dda0421808b06c0465d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release mdsal

Bump upstreams

Adopt:
- odlparent-12.0.8
- yangtools-10.0.10

Change-Id: I07a574f3b25b00742b1a78fcb7b4d29090e40ea6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make ClassToQNameLoader final

Upgraded checkstyle is flagging this class as a violation. Fix that.

Change-Id: Ibbf6321ada47e6f231ce042f166359850060a03a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.32.0

https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2023/08/27/version-2-32-0

Change-Id: I1179a8129e379fe833a6e6487d22d6c7abad5362
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5e812a0b5c7bd875bd14001e325de66497ee134b)

Fix NotificationListenerInvokerTest on Java 19+

We cannot mock MethodHandle, as it is a sealed class on Java 19+. Adjust
the test to use String.toString() as the source of the MH.

Change-Id: Ieab28fdec5c703c2fcad8b14cd95ea3f49bd2a21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d93606f3965764225a98da0f5dbb76fc43bdec06)

Bump byte-buddy to 1.14.8

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.8

Change-Id: Ica0c4632f81b6d11303409303ebe30245b63cc22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8eb242ce923886362cad478727f0c264d1c9fe53)

Make AbstractPingPongTransactionChain.close() idempotent

Expend one byte of state to track close() method, making sure it is
idempotent.

JIRA: MDSAL-838
Change-Id: Ie7bccb2c12ad9eadd948fc15244cc2b2b150a256
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 67c7314bd62883f9c7e1ae4daa1b6cf70fe3cd73)

Fix mdsal-binding-dom-adapter checkstyle

Upgraded checkstyle is finding a few issues, fix them up.

Change-Id: Ifdafb339f112749b891ef288420e28af124b306e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 77e364296fc00da513a7eb651ca90872c29d50c2)

Bump byte-buddy to 1.14.7

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.6
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.7

Change-Id: Ia547a6bc735f5efa6d0420dc0261442f077e815d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2cd76e58649321ed4b2943de1f49ffc882d13a31)

Bump byte-buddy to 1.14.5

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.5

Change-Id: Ic3fd18b67d32515a2a86acc5813141efab1f867b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0d1d9013f0dbafba44dd9ddc5c737fe327aaf2a6)

Bump versions to 11.0.13-SNAPSHOT

This starts the next development iteration.

Change-Id: If86f0f70c9eec4bf8213e2d081da024288bf9cb5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release mdsal

Bump upstreams

Adopt:
- odlparent-12.0.7
- yangtools-10.0.9

Change-Id: Ic477a5bbb65b85959d01845c1066c88a2b673a71
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.31.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2023/05/29/version-2-31-0

Change-Id: Icbb185327e80d55d0b8306ed786ccc2be6f1ef6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2c0216e47e6ec581bc5ba741cbb2bb6c741bd2db)

Bump xtend to 2.30.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2023/02/27/version-2-30-0

Change-Id: If861cb4f3148a2d7d40ec8bc47ea3f8f8cc21feb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0c7398e564ce539fef490f0f180f1d5aaa0331f2)

Fix code generation with leafrefs pointing to optional members

When we have a typedef which points to a location disabled by
if-feature, we need to accept this fact -- but do not allow that typedef
to be referenced.

JIRA: MDSAL-829
Change-Id: Ibde28faa2f96904dc16fcc6f5a922edc6bcffebb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 756d61f430ee651a06adb69138d25b5a2a3648a7)

Bump versions to 11.0.12-SNAPSHOT

This starts the next development iteration.

Change-Id: I7fb586593cd7a6dad78905e6e69f1ac346c0c606
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release mdsal

Bump yangtools to 10.0.8

Pick up parser fixes from upstream.

Change-Id: I56985cd9f994fadc538f02ec924cf5370b54260a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.11-SNAPSHOT

This starts the next development iteration.

Change-Id: Id92b54e2a8b7b69ac7c5fbf17b4401120a76173a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch use of LinkedList in BindingCodecContext

LinkedList is a rather ugly thing performance-wise, use an ArrayList
instead.

Change-Id: I6f40a24bc7b22dc07ea6c809a44a796f1cdb9b54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ba18fd76fe35bc40ab2136f0e7877a80e3614c62)

Remove BindingToNormalizedStreamWriter.create()

We have a lot of indirection going on for little real benefit. Reduce
the tangle by replacing calls to create() with plain constructor and
inlining callers.

Change-Id: Ibaac2f17d1c275e42ad281767ba8a50c6318c649
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 733da7ad2bfb1ad7e484291fa1e913ae8e8cd0bd)

CachingNormalizedNodeSerializer should not be instantiated

We only use this class to act as a delegate towards the rest of the
infrastructure. Remove its constructor.

Change-Id: I245fe5204dc3872703c19df320a77789d5a4c6bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1bccf8759b8e6280d3e744d719b809d6efd64a85)

Clean up CachingNormalizedNodeSerializer

Simplify the class by eliminating unneeded methods and lining
invariants. This makes things a tad clearer and eliminates a caller of
DataContainerCodecContext.createWriter().

Change-Id: Ie1ed39ac20477ff21ce51707c1631db1ec7acf65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 989b52ddf0e132c96b4043ace98339b64ee8452b)

Modernize BindingCodecContext

Use local variable type inference and instanceof patterns to make things
a tad clearer.

Change-Id: I4b0e2634a08edb2f73e4586356d380063520fc48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 32774c5a03f420904dbb487328db076f705f80d5)

Clean up DataContainerCodecContext exception handling

We are getting confused between immediate throws and returns. The
exception factory methods should be returning the exception and not
throwing it.

Fix this up and add a SpotBugs annotation so that throws are guarded.
Also mark IncorrectNestingException for evolution. Final improvement
that we now have a completely-static factory method.

Change-Id: I5262c0dbb31d6935f258909828aac5331c70801b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 469a57c3adac4b6ae0df0c6398d926096cca13e2)

Improve BindingCodecTree.getSubtreeCodec()

The only implementation we have returns non-null and throws exceptions.
Promote that behaviour to how the method is meant to operate.

Change-Id: I836ee8adb20d23b7b9938dbdeb827aa7a5443bc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 595e8b44f8fd85c6df1b09d05c8d807c02e41cc4)

Improve BindingCodecContext.getCodecContextNode()

This method always returns @NonNull, document that. Also improve the IAE
thrown on mismatched input and eliminate
SchemaRootCodecContext.create().

Change-Id: Icbd36df64fb5027698a80bd0ba0984b9f55777d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 28c3c15c18c9dd627e7815d1b9cbec4c284d255d)

Bump upstreams

Adopt:
- odlparent-12.0.6
- yangtools-10.0.7

Change-Id: I509da62c6d136ff66a12d99348389be0aa626b19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use an instanceof pattern

We have a simple check-and-cast, fold them into a instanceof pattern.

Change-Id: I60bb94091b739ced1f886f9c0c29d9b8f86ce49c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c5db9abac96b7769034c5f39bfe5c010f85cbd40)

Use instanceof pattern in AbstractBindingNormalizedNodeCacheHolder

Reduce casting and flatten unneeded if/else blocks with returns. Also
mark a FIXME to use a switch expression once we them with pattern
matching.

Change-Id: I45045e3b6e5957486f60887c0c4d074b8924077f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit bd389969d4344c8aeaea5da79c723936ab86fa54)

Load YangFeatureProviders in mdsal-dom-schema-osgi

YangModuleProvider provides a view into explicitly defined per-module
feature set. These are defined by applications implementing YANG
modules which provide if-feature'd contents and the application does
not support the full feature set.

This patch add the basic smarts to perform loading of providers, and
propagates them to ModuleInfoSnapshotResolver.

JIRA: MDSAL-790
Change-Id: Ib08915be7b5aba785a8a09ec28dd6e008b61db67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b6204276855d68bafad4aafadd291bf47d9e2d17)

Fix runtime type search

When searching for children, we should be cognizant of the fact that we
might be looking at an inherited contract -- such as 'output' of an
'action' inherited through 'uses'. Extend the runtime search algorithm
to also look at previous() axis.

JIRA: MDSAL-824
Change-Id: Ic2f57b266825c6121f7bd6156a86112abff4b67a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 53450b03cee1ad3eb8e065c17729bdd16decd574)

Bump versions to 11.0.10-SNAPSHOT

This starts the next development iteration.

Change-Id: Ie77de88f31bc44afdee5cfc12981a416c68b51d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate supported features from ModuleInfoSnapshotResolver

ModuleInfoSnapshotResolver should follow the same pattern as Builder to
allow users to add supported features -- except it talks to a different
backing entity.

JIRA: MDSAL-789
Change-Id: I901e188e33e2508e5c20d135fe57399bc3c81f68
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 184ac4d3b25d6f9ec21636ca25f943f81560ba71)

Propagate supported features from ModuleInfoSnapshotBuilder

Allow a FeatureSet to be created from a collected
Module/Set<YangFeature> mapping, allowing each reported module to be
registered in ModuleInfoSnapshotBuilder. These are then transformed
into a FeatureSet and passed down to parser.

JIRA: MDSAL-789
Change-Id: I7837fb1debf2ebff3382422b232f047ec05316c1
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9642f37f7a23be0206d2f04a7c160c245a0b43ed)

Hide extractYangModuleInfo()

This method is only used internally, hide it from the rest of the
package.

Change-Id: I77c47e5cff17d0602740823f68c53ff4a813d385
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b04f11335eb603dcb984a778f6d65de1ed2b013f)

Bump upstreams

Adopt:
- odlparent-12.0.5
- yangtools-10.0.6

Change-Id: I1e5cda11366b81e37628a518bd5432f244b3f26c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.9-SNAPSHOT

This starts the next development iteration.

Change-Id: I284f6cc33c2517ebb402f342ba36761383de569f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix DOMDataTreeCommitCohort

The cohort should be exposing EffectiveModelContext in order to provide
correct interactions with other utilities.

JIRA: MDSAL-822
Change-Id: I2b0a3ada8cb677cdbcf9c2fad0ca50d502f6d2e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a706a8e41d9fc17d52f5623bef3042eefb8847cb)

Bump byte-buddy to 1.14.4

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.4

Change-Id: I7bc3933c10dc7e947851df72ee28a3f029381582
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 4ed1667793f77cf1d4cd3c069725c8d84d98dfc7)

Bump byte-buddy to 1.14.3

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.3

Change-Id: I3cba45532c0380affd70fa2d1ec1bbb6c30ae0ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a16fe5cce6c326340d02936dfd23f7d80c2d169c)

Bump byte-buddy to 1.14.2

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.1
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.2

Change-Id: I1763b4314eead1f822d9cfee948d703aea9f9d51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e43058393f0f08037ae744659ec0302db1c14502)

Tag serialVersionUID with @Serial

Java 14+ allows tagging serialization-related constructs. While we do
not do anything fancy, make sure we tak serialVersionUID.

JIRA: MDSAL-821
Change-Id: I1b660df8fb5e7599d9d8b6658d8955251cc49870
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 67c534310831d06ba7c0341d8140c7c0c3c9f894)

Bump upstreams

Adopt:
- odlparent-12.0.4
- yangtools-10.0.5

Change-Id: If70cc51bda56c6129d359f6b548554ea41e6f696
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate Optional.get() callers

Use Optional.orElseThrow() instanced.

Change-Id: I6ffee0b3e92ddca92a659d0f67d0fda128c02258
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 46f29107bbb71b037f474346d2eb34d6d446c27e)

Remove explicit DataTreeChangeService

DataBroker always implements DataTreeChangeService, hence we do not need
to spell that out.

Change-Id: If8f3889358cd7d92c59d719b37de040abcb40831
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct InstanceIdentifier.trustedCreate()

The check for wildcard is not correct: we should just consider the last
item when deciding to create a KeyedInstanceIdentifier. Add an explicit
test and fix the checks.

JIRA: MDSAL-818
Change-Id: Ic6fedca7e182eaf0d983e3e39b49dd75d01f8ae8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2cb72f53bee4699dc32c004810d05b2187aed1e9)

Use mockito-subclass

Reduce the workaround here to use mockito-subclass instead of forcing an
old mockito version.

Change-Id: Ibcf45b9101133f2c7852e404081b58c25cd3b888
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add IdentityKeyTest

Add an explicit test for there/back conversion of identitiable items
with identity-bearing keys.

Change-Id: Iee6ef612aac91058dff658025fc6670c8b8b4f56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I80ca407339914e3c26aa72b30936c141625e1544
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate user of TypeDescription.OBJECT

Use TypeDescription.ForLoadedType.of() instead. Also shorten references
to TypeDescription.ForLoadedType, as we already have it imported.

Change-Id: I2e5531b8e0199d341ee943792369bafb7ab64dc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.3
- yangtools-10.0.4

Change-Id: I98d91e0dac8b396e6164c8b3820c57ba4c5304ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded declaration

junit-jupiter-params is pulled in by default, remove the declaration.

Change-Id: I8bed9db5e4b50d114357ed308cb9479ed29f1078
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use text blocks in BuilderGeneratorTest

Java 17 has text blocks, which we can use to make the test a lot more
readable.

Change-Id: Ifa4236e09f6e576b339be7fba0dd2c91469ce9a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce bindingEquals() verbosity

We are generating a cascade of checks, all of which must pass for us to
return 'true'. Rather that generating a number of 'if/return' blocks,
use a single expression to achieve the same result.

Change-Id: I13c7abe4ef81d2a2822b6b4d0456f277dd5ce288
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use {@code null} instead of plain null

We want to highlight null, make sure we do that.

Change-Id: I489c42a5e8f28bec5799ba22c78b960fc4e753cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up dependencies

We rely on rfc8040-model-api in generator, add that to dependencies to
supporess a warning.

Change-Id: I28f2a16b8eff90cc757a4ccebebe3940033a4739
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.0

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.20
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.21
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.22
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.23
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.13.0
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.0

Change-Id: I5fded158100395f841b15fba08245399d7973b85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I5220b28e9fd077c1b88acb89a25485fa16742f5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expand StatementNamespace

We are dealing with weird generated models in some cases. Expand
StatementNamespace to cover all the possible inter-statement conflicts
by dedicating suffixes.

JIRA: MDSAL-810
Change-Id: If5e99f89a03f1fa6287dc3516f193bed3de097e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move appendPrefix()

The decision to append a prefix is a policy decision, hence it should
live in NamingStrategy. StatementNamespace only provides the knobs.

Change-Id: I3439930b2f9978a157f03f7ca685250c010242f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update listeners in registerNotificationListeners

'registerNotificationListeners' does not include a step to replace the
the listener map with a new one. Make sure that the listener map is
actually updated. Also, add test cases for the registration methods.

JIRA: MDSAL-811
Change-Id: I469000b6f92e8d45186cafa1a3a2c737f642de01
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Bump versions to 11.0.6-SNAPSHOT

This starts the next development iteration.

Change-Id: Idf89c631cd7dcd33f4469c3a05c30f0da33d319e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add BindingRuntimeContext.getYangDataClass()

For runtime support we need the ability to load YangData classes, this
patch adds that ability.

JIRA: MDSAL-675
Change-Id: Ia318c2cd7b47e6477144938d9f67f69972e4d7c6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add BindingRuntimeTypes.findYangData()

BindingRuntimeTypes (as well as ModuleRuntimeType) need to expose the
ability to locate YangDataRuntimeTypes. This patch adds that capability.

JIRA: MDSAL-675
Change-Id: Ibb5da804ffa04750f6b450ace3a240b910fc7eac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern

Remove an explicit cast, making things a bit cleaner.

Change-Id: I5a06c7fcfa74dcca61e7c767cd9107fb926e7894
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

RFC8040 'rc:yang-data' support for mdsal binding generator

New naming strategy is introduced to generate artifact names out of
yang-data argument: if name is yang identifier compliant the camel-case
transformation used, otherwise non-compliant characters are encoded.

JIRA: MDSAL-675
JIRA: MDSAL-808
Change-Id: I6644f550a378cd176e5f53a201ee6e70b32c6410
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Separate out YangIdentifierClassNamingStrategy

Our current ClassNamingStrategies rely on the fact that each YANG
statement's argument provides an AbstractQName from which we can extract
a YANG identifier (i.e. AbstractQName.getLocalName()).

ietf-restconf:yang-data's argument is any non-empty String, so we just
cannot keep this contract.

Separate current handing into a separate class, which inherits the
notion of having a nodeIdentifier(), except that fact is purely internal
field. This also neatly re-joins Module and CamelCase to use the same
simpleClassName() method.

JIRA: MDSAL-675
Change-Id: Iaa1a43ba865ff78aa98ac69459e16373634eff40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Make CamelCaseWithNamespaceNamingStrategy reusable"

This reverts commit 74423fd58d3af3c3fcafd179be4b174aeace2230. As it
turns out we do not need fallback for yang-data after all.

JIRA: MDSAL-675
Change-Id: I3ecba0c7d93bc3e0d33479221b95adea40b4befe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move ClassNamingStrategy.simpleClassName()

Class name generation must not depend on YANG identifier, as there very
well may be other implementations. This results in a bit of duplicate
code, but that's fine.

JIRA: MDSAL-675
Change-Id: Iccbcf77ea68a7f6cf1c5cff18a218a27c04c40a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make CamelCaseWithNamespaceNamingStrategy reusable

Appending a suffix is usable for other strategies as well, rename this
class to AppendNamespaceNamingStrategy and extract the fact that a
strategy has a namespace to AppendNamespaceNamingStrategy, which
automatic fallback.

JIRA: MDSAL-675
Change-Id: Ib1614b84591b4c0349f81785846f7216e0e87ec4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add YangData base interface

RFC8040 defines a yang-data extension, which defines a piece of data,
which is yang-modeled, but does not tie to any of the RFC7950
constructs.

Add a baseline binding interface which captures its basic contract and
codegen generates interfaces on top of it.

JIRA: MDSAL-675
Change-Id: I6f93733ce15ad47294c7c04bc7de2d7aa22ac9cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.2
- yangtools-10.0.3

Change-Id: I557f7fab6650da3980109cde573bf509a27dd5f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: If57c4c2a776554c1892bf23e30b032966eabc059
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix typedef/bits code generation

bits/typedef seemed to be generating code which does not compile.

Add a test to check if the generated code contains desired method and
fix the check for bits type.

JIRA: MDSAL-807
Change-Id: I4618269fff1fc284b65e9efb1d49501248d233c3
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Augmentable.augmentationOrElseThrow()

A number of places assume, or check-or-throw on, presence of a
particular Augmentation. Add convenience methods to short-circuit
the equivalent of Optional.orElseThrow(), so users get more comfort
expressing this.

JIRA: MDSAL-806
Change-Id: I457a93ac1689087a7ceace57489e528b488ed207
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof patterns for argument checking

Eliminate the need for explicit casts by inlining verify(instanceof)
calls.

Change-Id: Ice2508ea44693bac4198b55779f82a9d51cbe514
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add FIXMEs to Rpc{Input,Output}

DataObject has implications which cover the possibility of being an
interior node of a structured data. RpcInput and RpcOutput are
explicitly excluded from that contract, similarly as BaseNotification
is.

Add FIXMEs to reconcile this modeling problem.

Change-Id: I84b6f5ca90cbfb685209559863f29634c5744772
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

More use of instanceof patterns

Reduce the number of explicit casts by integrating them into instanceof
patterns, which leads to reduction of nested if statements in some
cases.

Change-Id: I1255b4c9998faa1ec0de037fc54dc0d79544ed4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>