Perform partial modification matching

Now that we have a collector, we can assert a particular modification
state at any given moment.

Change-Id: I9f9f3436b0def8d3ddd8612343c41c4bfdd2c017
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractDataTreeChangeListenerTest

Rather than exposing the underlying DTCL implementation, expose only the
collector aspect, requiring the collector to be closed -- which also
tears down the listener.

This is a stepping stone to allowing step-by-step assertions, but the
notable change is that we await the initial synchronization before
giving out the collector.

Change-Id: I9337bc5b80eb9976ad9dec143b59ef75d742cbfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve BindingNormalizedNodeSerializer API

Allow users to specifically ask for an explicit dataobject or
augmentation serialization.

JIRA: MDSAL-820
Change-Id: Ic929620d2c23c8ac1ab7eb7a5f2f46d627833a73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up BindingAugmentationCodecTreeNode

We have two unused methods here, remove them.

JIRA: MDSAL-820
Change-Id: Ib1f1fc145f2a5d38cce40f1e1ddee6058d0860e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve BindingCodecTree interface

We have users which know statically that they are dealing with a plain
DataObject or an Augmentation. Add methods to help them to get the right
codec.

JIRA: MDSAL-820
Change-Id: Idf0209c9dc705cf8359688a0eef2dd2e9fa00df2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove binding.spec.util package

Deprecated DataObjectReadingUtil is not being used by anyone.

JIRA: MDSAL-801
Change-Id: I33d68733820c200155c99f0d0f703daff450e411
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Migrate users of NormalizedNode.getIdentifier()

We have a replacement, NormalizedNode.name(), use that instead.

Change-Id: Iebcca6dde477b7e5c8dd74dc577e68abbee07662
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate callers of IncorrectNestingException.create()

The static factory method is quite useless, migrate aware from it.

Change-Id: I386d8d13585b8a1627460615e8c84772fe9e21a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of YangInstanceIdentifier.{create,empty}()

We have of() methods to replace these, migrate users.

Change-Id: I041a20ee6dd0bbb56ee765ecf2788517bd6318d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt yangtools-11.0.0-SNAPSHOT

yangtools is finalizing its bits, which have reprecussions on MD-SAL
APIs. Synchronize with current snapshot so we can start addressing those
bits.

Change-Id: I7d331e28ace9c8b512f960f4452da1fa8d178d05
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Update binding-dom adaptation to remove AugmentationNode

AugmentationIdentifier and AugmentationNode are being removed from
yang-data-api.

This patch adapts mdsal-binding-dom-codec to reflect the
fact Augmentation no longer has one-to-one equivalent. This means that
users need to check whether the code tree node refers to an Augmentation
or to a regular DataObject.

One particular sore point is that toNormalized() can no longer return a
plain Entry of NormalizedNode, as Augmentations do not have a backing.
To solve this, we introduce NormalizedResult with two specializations,
NodeResult and AugmentationResult.

In order to deal with DTCL changes, we also memoize
dataBefore/dataAfter, as it guides LazyAugmentationModification's
correct identification whether the a node has appeared, was modified, or
disappeared.

JIRA: MDSAL-820
Change-Id: I0360fd8f74ddb6df82ba64f7a87f6d92ce855162
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve AbstractDataTreeChangeListenerTest

Add dedicated @FunctionalInterfaces instead of generic Function and make
sure we match each matcher in order an only once.

Change-Id: I9e597a6abc2c1545b5156e438e1ce94136aa68b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractDataTreeChangeListenerTest a bit

Use List for changes, along with local variable type inference. Also
make sure we complete whenever we have at least the number of expected
changes.

Change-Id: I4b05fbc9ee02315312d4e0ecaad0aa09f1b371f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.6
- yangtools-10.0.7

Change-Id: I509da62c6d136ff66a12d99348389be0aa626b19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 38664cbc750864dcffa8537b93ce4aa60b1cadb3)

Improve BindingCodecTree.getSubtreeCodec()

The only implementation we have returns non-null and throws exceptions.
Promote that behaviour to how the method is meant to operate.

Change-Id: I836ee8adb20d23b7b9938dbdeb827aa7a5443bc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve BindingCodecContext.getCodecContextNode()

This method always returns @NonNull, document that. Also improve the IAE
thrown on mismatched input and eliminate
SchemaRootCodecContext.create().

Change-Id: Icbd36df64fb5027698a80bd0ba0984b9f55777d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify LazyDataObjectModification.childCache

Simplify the signature of internal list. Also mark a FIXME for the case
which needs to be updated.

JIRA: MDSAL-820
Change-Id: I24be9cfc12bd0aed89568bf9f1ab453c51c54d1a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch use of LinkedList in BindingCodecContext

LinkedList is a rather ugly thing performance-wise, use an ArrayList
instead.

Change-Id: I6f40a24bc7b22dc07ea6c809a44a796f1cdb9b54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize BindingCodecContext

Use local variable type inference and instanceof patterns to make things
a tad clearer.

Change-Id: I4b0e2634a08edb2f73e4586356d380063520fc48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add CodecDataObjectAnalysis

We will be separating out DataObjectCodecContext into two classes, and
the new one will need to be able to create proxies.

Separate out all the analytics and indexing into a separate DTO, which
can be constructed externally, so the new classes can construct them
separately.

This also necessitates splitting out bindingChildArg() into a separate
class -- but we still want to migrate that to RuntimTypes at some point.

JIRA: MDSAL-820
Change-Id: I970b8f92443a9faf57c1786239e2f552f7ff938d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up DataContainerCodecContext exception handling

We are getting confused between immediate throws and returns. The
exception factory methods should be returning the exception and not
throwing it.

Fix this up and add a SpotBugs annotation so that throws are guarded.
Also mark IncorrectNestingException for evolution. Final improvement
that we now have a completely-static factory method.

Change-Id: I5262c0dbb31d6935f258909828aac5331c70801b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve DataContainerCodecPrototype safety

Before making any changes to the codec, make sure the prototype enforces
invariants, so things like nulls do not sneak in.

JIRA: MDSAL-820
Change-Id: I6c15f686bfde20b5f4516d9ad0b0f40007d689c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up NonCachingCodec

Use requireNonNull() and make the codec final, as it is only used as-is.

Change-Id: I59c25c4bcf795e193ac7af764cee9fa868c8435f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

isSubstitutionFor() should be final

Having a static final method guards against potential overlaps, which is
exactly what we want.

Change-Id: I557b80251f5472e57c0ba86853e30d498c515d8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BindingDataObjectCodecTreeNode.writeAsNormalizedNode()

This is a leak of implementation internals, not used anywhere but inside
the implementation.

JIRA: MDSAL-820
Change-Id: I3869dd490eb94f218ea86ff7b164ac05f2f5a9e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not mock YangInstanceIdentifier.PathArgument

Use a real NodeIdentifier instead of mocking, as PathArgument is getting
sealed.

Change-Id: I30a86490a4430226d14a5391ac13e1829fe4ebe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert ietf-type-util to a JPMS module

Correct the package and turn the artifact into an explicit module. Also
fix up dependencies on mdsal-binding-spec-util.

JIRA: MDSAL-826
Change-Id: Ib2ad5d82ae9350794d11e0fdf2853e55e8f755db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate AbstractIetfInetUtil

We have a single specialization, remove INSTANCE and make sure methods
are static.

JIRA: MDSAL-826
Change-Id: I051482f26837d216bbd68c3705beb0c6ec609b2d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unnecessary version declaration

We are inheriting version from project parent, hence there's no point in
overriding version.

Change-Id: I573a61364ab6ddeea9dad9a1e2a929c58b461ca4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make factories static

Factories are invariants: there is no point in storing them in instance
fields.

JIRA: MDSAL-826
Change-Id: Ic23a8439978fc872b18e2206bccaffffb463f3e2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove method specializations

AbstractIetfInetUtil is properly specialized, really, remove subclass
indirection.

JIRA: MDSAL-826
Change-Id: Ic60684d461fdf56896a3dffaf3d3ef92600994a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move AbstractIetfInetUtil

As a first step in eliminating IetfInetUtil, move AbstractIetfInetUtil
and its tests.

JIRA: MDSAL-826
Change-Id: If558e9fc17f801097b868e8bb5ff261b241c3a2e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate IetfYangUtil.INSTANCE

All methods are purely static, there is no point to indirect through a
particular instance.

JIRA: MDSAL-826
Change-Id: Ie4164ca8279e2809d72209340d91c595451008f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make IetfYangUtil factories static

These are instance-invariants, share them between instantiations.

JIRA: MDSAL-826
Change-Id: Ia025b3c9e0e382599829064e30752e5146e4becf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate AbstractIetfYangUtil

We have a superfluous abstract class, integrate it into IetfYangUtil.

JIRA: MDSAL-826
Change-Id: Idbd6c19fdb30cabb3a7852d94971d1c47e8fb1a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move AbstractIetfYangUtil

We are about to specialize AbstractIetfYangUtil, move it to its sole
user.

JIRA: MDSAL-826
Change-Id: I1d86382da66b0c6af2b4c76766fa48ea8014c27d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move IPv4 string utilities

AbstractIetfYangUtil depends on AbstractIetfInetUtil, which is not nice.
Move the two methods needed to Ipv4Utils, so we break that dependency.

JIRA: MDSAL-826
Change-Id: I097738ca75c03ebe4292149f353dfa0d29a4197d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move INET{4,6}_LENGTH constants

We have a few overlapping constants, make sure we co-locate them in
their respective utils, removing duplication as we go.

JIRA: MDSAL-826
Change-Id: Ib6302052388c9c196413fb7a44e32b8c69b1ed49
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expose Ipv{4,6}Util

These two utility classes form the common interface, expose them to
outside world.

JIRA: MDSAL-826
Change-Id: Iee050241e6ca52ae52c2f70abaecdd9077c6a400
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move addYangPathArgument()

This method is only used for DataContainerCodecContext, there is just no
reason to pollute NodeCodecContext with this method. Reduces coupling
towards YangInstanceIdentifier.PathArgument a tiny bit.

Change-Id: Iecbb7c11f28a49282d6224229890f63eab33b311
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-dom-schema-osgi to a JPMS module

mdsal-binding-dom-codec-osgi is a rather simple artifact.
Convert it to a JPMS module.

JIRA: MDSAL-748
Change-Id: I00e2e11047f4580ef7d443c4baefc036a1d0a58e
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>

Clean up IETF module names

The primary key is the IETF module name, make sure that is reflected in
packaging. The basic idea here is that differing revisions and up
reflecting diffent package names.

This patch allows for differing revisions to exist based on standard
names and the revision -- whereas previously we used the document as a
starting point for the namespace.

JIRA: MDSAL-752
Change-Id: I3ea3f910d2c07dad8396c54fa03044ac6a4ad62b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade IANA models

Adopt:
- iana-if-type@2023-01-26.yang
- iana-routing-types@2022-08-19.yang

Change-Id: I9ce147047714d8f8ee38fd6119fa47d5954acafc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Automatic-Module-Name declarations

Update all packaged models to include Automatic-Module-Name
with correct JPMS module naming.

JIRA: MDSAL-752
Change-Id: I7a8ee5081d97aed0a72570698c4ec729ab57a717
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove convenience model artifacts

Remove empty artifacts as they do not contribute anything to the actual
picture and act only as maven dependency shortcut.

JIRA: MDSAL-823
Change-Id: I01c83ae3e624582048a47d013082d62e983a2590
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix runtime type search

When searching for children, we should be cognizant of the fact that we
might be looking at an inherited contract -- such as 'output' of an
'action' inherited through 'uses'. Extend the runtime search algorithm
to also look at previous() axis.

JIRA: MDSAL-824
Change-Id: Ic2f57b266825c6121f7bd6156a86112abff4b67a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add tests for BindingObjects with List and LeafLists

These tests cover scenarios for ordered and unordered lists and leaf-lists,
including nested lists within containers.The tests also verify the correct
behavior of user, system-ordered and un-keyed lists.

Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Change-Id: Id9e85133fe767a22953970e96f9eb6b26a1bd068

Do not depend on binding-spec-util

With BindingNaming rehosted, mdsal-binding-java-api-generator has no
business with mdsal-binding-spec-util.

Change-Id: I009ca8eb4d8914480fc32e673c4d1044711b3042
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use an instanceof pattern

We have a simple check-and-cast, fold them into a instanceof pattern.

Change-Id: I60bb94091b739ced1f886f9c0c29d9b8f86ce49c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

CachingNormalizedNodeSerializer should not be instantiated

We only use this class to act as a delegate towards the rest of the
infrastructure. Remove its constructor.

Change-Id: I245fe5204dc3872703c19df320a77789d5a4c6bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expand BindingObject documentation

Enumerate the constructs we are representing.

Change-Id: Ifca6959868dd67080ca46f598cdc8d430c677138
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve BindingContract documentation

Enumerate the use allowed interfaces and explain how they relate to
BindingContract. This interface is sufficiently disconnect from
BindingObject, which has other implications.

Change-Id: I0f93781dbabb540596fc5ac37dfd1bdb509732e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve ChoiceIn documentation

We have a few typos and the javadoc contains HTML entities. Clean this
up.

Change-Id: Ia09a63d2f55e41c748eceadc3a4d471325ee714e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up BindingToNormalizedStreamWriter

Clarify field name: the rootNodeSchema is really a
DataContainerCodecContext the context corresponding to the root object,
hence it should be called rootSchema.

We have multiple calls to current(), which end talking to the Deque,
which is not necessary. We can just access it once, which makes type
checking more obvious.

Finally ditch checkArgument() calls and prefer instanceof patterns,
which makes the type checks more obvious (to the compiler at least).

Change-Id: I472f0f3eec1f83c1755c91c6cbd0b24b77ae9d9a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BindingToNormalizedStreamWriter.create()

We have a lot of indirection going on for little real benefit. Reduce
the tangle by replacing calls to create() with plain constructor and
inlining callers.

Change-Id: Ibaac2f17d1c275e42ad281767ba8a50c6318c649
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up CachingNormalizedNodeSerializer

Simplify the class by eliminating unneeded methods and lining
invariants. This makes things a tad clearer and eliminates a caller of
DataContainerCodecContext.createWriter().

Change-Id: Ie1ed39ac20477ff21ce51707c1631db1ec7acf65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern in AbstractBindingNormalizedNodeCacheHolder

Reduce casting and flatten unneeded if/else blocks with returns. Also
mark a FIXME to use a switch expression once we them with pattern
matching.

Change-Id: I45045e3b6e5957486f60887c0c4d074b8924077f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Load YangFeatureProviders in mdsal-dom-schema-osgi

YangModuleProvider provides a view into explicitly defined per-module
feature set. These are defined by applications implementing YANG
modules which provide if-feature'd contents and the application does
not support the full feature set.

This patch add the basic smarts to perform loading of providers, and
propagates them to ModuleInfoSnapshotResolver.

JIRA: MDSAL-790
Change-Id: Ib08915be7b5aba785a8a09ec28dd6e008b61db67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate supported features from ModuleInfoSnapshotResolver

ModuleInfoSnapshotResolver should follow the same pattern as Builder to
allow users to add supported features -- except it talks to a different
backing entity.

JIRA: MDSAL-789
Change-Id: I901e188e33e2508e5c20d135fe57399bc3c81f68
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Hide extractYangModuleInfo()

This method is only used internally, hide it from the rest of the
package.

Change-Id: I77c47e5cff17d0602740823f68c53ff4a813d385
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate supported features from ModuleInfoSnapshotBuilder

Allow a FeatureSet to be created from a collected
Module/Set<YangFeature> mapping, allowing each reported module to be
registered in ModuleInfoSnapshotBuilder. These are then transformed
into a FeatureSet and passed down to parser.

JIRA: MDSAL-789
Change-Id: I7837fb1debf2ebff3382422b232f047ec05316c1
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.5
- yangtools-10.0.6

Change-Id: I1e5cda11366b81e37628a518bd5432f244b3f26c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5f0db3b0d12ac15058d09fd4ad914265256b7e19)

Cleanup AbstractBindingAdapter

@NonNullByDefault does not quite work here, revert back to explicit
@NonNull annotations.

Change-Id: I4f2779f611316701be8bb41199d9a36f03d0b1d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct BindingTypes.yangFeature() javadoc

We are referencing 'notification', betraying our copy&paste source. Fix
that up.

Change-Id: I683d0964fe654ff4b1e9b327594f548fdef300d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.4

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.4

Change-Id: I7bc3933c10dc7e947851df72ee28a3f029381582
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix DOMDataTreeCommitCohort

The cohort should be exposing EffectiveModelContext in order to provide
correct interactions with other utilities.

JIRA: MDSAL-822
Change-Id: I2b0a3ada8cb677cdbcf9c2fad0ca50d502f6d2e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.3

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.3

Change-Id: I3cba45532c0380affd70fa2d1ec1bbb6c30ae0ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.4
- yangtools-10.0.5

Change-Id: If70cc51bda56c6129d359f6b548554ea41e6f696
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Tag serialVersionUID with @Serial

Java 14+ allows tagging serialization-related constructs. While we do
not do anything fancy, make sure we tak serialVersionUID.

JIRA: MDSAL-821
Change-Id: I1b660df8fb5e7599d9d8b6658d8955251cc49870
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate Optional.get() callers

Use Optional.orElseThrow() instanced.

Change-Id: I6ffee0b3e92ddca92a659d0f67d0fda128c02258
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove explicit DataTreeChangeService

DataBroker always implements DataTreeChangeService, hence we do not need
to spell that out.

Change-Id: If8f3889358cd7d92c59d719b37de040abcb40831
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ArgumentMatchers.anyCollection()

Remove type safety warnings by using a dedicated method for matching any
collection.

Change-Id: I4607cb370115ec375757cb15277c43890bf06b70
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename InstanceIdentifierBuilder

Turn the intermediate interface into a sealed abstract class, which
lowers verbosity significantly. We now have three builder classes, only
two of which are exposed.

JIRA: MDSAL-798
Change-Id: I45e23643e196d9d06112053d60b2e2fbf1544311
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Introduce InstanceIdentifier.KeyedBuilder

When we are dealing with the last idem being an identifiable, we should
expose that by producing KeyedInstanceIdentifier.

Introduced KeyedBuilder and switch to this interface whenever the last
item is an IdentifiableItem -- guaranteeing KeyedInstanceIdentifier
return from build() method.

JIRA: MDSAL-798
Change-Id: I404df6aa1f3c79f259ea705adedd58a9d466cb78
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up InstanceIdentifierTest

Add missing spaces and remove unneeded trailing comments.

Change-Id: I44c0db8aa27b145148fc86c3fb43b0d78769ce51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve InstanceIdentifierBuilderImpl.equals()

Use an instanceof pattern and perform direct comparison on hashcodes.

Change-Id: I345e68b9c29fe32ee68d12808f02446c4636388e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve InstanceIdentifierBuilderImpl safety

Add a constructor which explicitly takes (Identifiable)Item, removing the
need to use type arguments and hiding the intermediate empty constructor
as well as the methods to add items.

Change-Id: Ib45485b0ab3b10ab0666b4ad6797dc710cd00130
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify AbstractPathArgument.equals()

Use instanceof pattern to simplify the equals method.

Change-Id: I31eb8b095a701a43ece60008bc1b797a9ef6ebac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove internal callers of isWildcarded()

We have two internal callers who can just refer to the field, fix them
up.

Change-Id: Ia634c2f65b809dd719746bd85061feee14f44ec9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct InstanceIdentifier.trustedCreate()

The check for wildcard is not correct: we should just consider the last
item when deciding to create a KeyedInstanceIdentifier. Add an explicit
test and fix the checks.

JIRA: MDSAL-818
Change-Id: Ic6fedca7e182eaf0d983e3e39b49dd75d01f8ae8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rehost BindingMapping in yang.binding.contract.Naming

Preparation stage for further changes requested by MDSAL-804,
where all the constants and utility methods are moved to
yang.binding.contract.Naming.
Includes moving from BindingMappingTest to NamingTest.

JIRA: MDSAL-804
Change-Id: I8c34f4c4eef40f9c040a0eaeadd49fdfed6dca13
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.2

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.1
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.2

Change-Id: I1763b4314eead1f822d9cfee948d703aea9f9d51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.30.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2023/02/27/version-2-30-0

Change-Id: If861cb4f3148a2d7d40ec8bc47ea3f8f8cc21feb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve DOMMountPointServiceImpl error message

The checkState() we perform is rather ugly, as it does not provide
enough diagnostic information. We already have a nicer checkState()
in the register() path. Extract it to a common method and reuse it from
both places.

Also improve safety by checking for null path before anything and also
take the lock to ensure serialization with others.

JIRA: NETCONF-621
Change-Id: I55845f9bbd7b3f4dbfa06a91724abcb601dc4f7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 12.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: Iae454a79260f3633994976e086f45458a6240185
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use mockito-subclass

Reduce the workaround here to use mockito-subclass instead of forcing an
old mockito version.

Change-Id: Ibcf45b9101133f2c7852e404081b58c25cd3b888
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add IdentityKeyTest

Add an explicit test for there/back conversion of identitiable items
with identity-bearing keys.

Change-Id: Iee6ef612aac91058dff658025fc6670c8b8b4f56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I80ca407339914e3c26aa72b30936c141625e1544
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate user of TypeDescription.OBJECT

Use TypeDescription.ForLoadedType.of() instead. Also shorten references
to TypeDescription.ForLoadedType, as we already have it imported.

Change-Id: I2e5531b8e0199d341ee943792369bafb7ab64dc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.3
- yangtools-10.0.4

Change-Id: I98d91e0dac8b396e6164c8b3820c57ba4c5304ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded declaration

junit-jupiter-params is pulled in by default, remove the declaration.

Change-Id: I8bed9db5e4b50d114357ed308cb9479ed29f1078
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use text blocks in BuilderGeneratorTest

Java 17 has text blocks, which we can use to make the test a lot more
readable.

Change-Id: Ifa4236e09f6e576b339be7fba0dd2c91469ce9a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce bindingEquals() verbosity

We are generating a cascade of checks, all of which must pass for us to
return 'true'. Rather that generating a number of 'if/return' blocks,
use a single expression to achieve the same result.

Change-Id: I13c7abe4ef81d2a2822b6b4d0456f277dd5ce288
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use {@code null} instead of plain null

We want to highlight null, make sure we do that.

Change-Id: I489c42a5e8f28bec5799ba22c78b960fc4e753cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up dependencies

We rely on rfc8040-model-api in generator, add that to dependencies to
supporess a warning.

Change-Id: I28f2a16b8eff90cc757a4ccebebe3940033a4739
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.14.0

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.20
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.21
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.22
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.23
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.13.0
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.0

Change-Id: I5fded158100395f841b15fba08245399d7973b85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I5220b28e9fd077c1b88acb89a25485fa16742f5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expand StatementNamespace

We are dealing with weird generated models in some cases. Expand
StatementNamespace to cover all the possible inter-statement conflicts
by dedicating suffixes.

JIRA: MDSAL-810
Change-Id: If5e99f89a03f1fa6287dc3516f193bed3de097e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move appendPrefix()

The decision to append a prefix is a policy decision, hence it should
live in NamingStrategy. StatementNamespace only provides the knobs.

Change-Id: I3439930b2f9978a157f03f7ca685250c010242f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update listeners in registerNotificationListeners

'registerNotificationListeners' does not include a step to replace the
the listener map with a new one. Make sure that the listener map is
actually updated. Also, add test cases for the registration methods.

JIRA: MDSAL-811
Change-Id: I469000b6f92e8d45186cafa1a3a2c737f642de01
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>