Release mdsal

Bump upstreams

Adopt:
- odlparent-9.0.15
- yangtools-7.0.17

Change-Id: Ia47fb34d1711c6834af178d4aaddb08ea3e73cf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 8.0.15-SNAPSHOT

This starts the next development iteration.

Change-Id: I8a843f87ca68059c0acbf8a82eece9b3d8b395ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools to 9.0.14/7.0.16

Pick up latest fixes from upstream.

Change-Id: I7a9739d0f38693bf247f19853c8008a4a1d7e2b2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.12.9

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.9

Change-Id: Ied3ea31ab3181703fafc07b46133f9fce4056016
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.12.8

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.2
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.3
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.4
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.5
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.6
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.7
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.8

Change-Id: I660d0fff4a67b33202bdb70b56ee546d63ac15d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 53e612cb2ab76378c52aaf166e33088c2f4832a5)

Fix a minor typo

'wich' should be 'which'.

Change-Id: I20295881f28c139b0ec7a04678272e762969efe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d49eb84dc5c7ec6201660fa899b79c564242d275)
(cherry picked from commit b979eaf60bb38132963d68229f134a7b4120f231)

Fix lead transaction cancellation

We have a thinko around recording frontend transaction, which leads
to us always cancelling the entire chain. This is not correct, as
evidenced by existing tests.

Correct the book keeping and refactor cancelTransaction() to allow
returning correct result of operation and handle the case where backend
refuses to cancel.

JIRA: MDSAL-756
Change-Id: I553e4de2d09acedf67af63bc292fae0bb5dfed78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e781d0af7effb145dc69163744d1a7f02c200d8e)
(cherry picked from commit 5efad8eb9dec08e7a0eb00e105385c81598863c2)

Use Map.entry() in PingPongTransactionChain

Map.entry() is potentially more efficient, use that instead of a
SimpleImmutableEntry.

Change-Id: I26a27f5f36a4c57b2e21158af78e4b50a787c24c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit dc625cb737fd87e77dc3bd0e980266f7a1c0eaee)
(cherry picked from commit 1287f2e9e30390d651bb5711028d2c92f85bd73b)

Use VarHandles in PingPongTransactionChain

Most of our accesses are compareAndSwap() so we do not benefit all
that much from ARFU type safety. Switch to using VarHandles to access
our atomic fields. Provide an acquireReadyTx() to deal with the few
call sites which would require explicit cast due to using getAndSet().

VarHandles allow us to use compareAndExchange(), which exposes the
witness value -- hence our error paths report the correct object without
a possibility of a race.

Change-Id: I79d2791f6e0d6accb987e46d31415452f735a7f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 4a94fedbe24344b6dbe67287a560daba8b99eb84)
(cherry picked from commit 89dc97e6bdfa7afb5e9557c6b207b9f3bbd0c434)

Reduce volatile variable access

The checkState() and verify() calls are costing us a superfluous
access after we have already accessed the volatile field. Refactor
them to prevent that.

Change-Id: I07c552593a89fb8929985ac637c6fba576b4e659
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 18cb8f2e949db76fb72bfa08921ba6c73a707ec6)
(cherry picked from commit 221e59a1ffa68caff0ca09e124b20d084f4e8be9)

Fix a nullability warning in PingPongTransactionChain

Eclipse is flagging multiple accessed to the same field. The field
cannot move on us, but use a local variable to make the value invariant.

Change-Id: I81599fecc77861d5011e45fa336c554e412f87dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 069b1e6e991e6d6ebe99621d201984a01c36bab0)
(cherry picked from commit a5b5d9b7882531440d4c7335cd917b1e00075bc1)

Fix checkstyle

Updated checkstyle is finding a few violations, fix them up.

Change-Id: I7a9cb9a19dc20de08a856c7752af8f060585e342
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 53d50535b20340477f76e0998297b43430b2aacb)

Use StringBuilder fluently

This is just a bunch of appends, use the return value to chain them.

Change-Id: I7db1a134387ae6ac0b756886d06264cbb8ffa43b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 56029dd8a38725d8c5149646a9348e58e769583a)

Centralize MoreObjects import

We are importing MoreObjects through Class, let's go through
JavaTypeName, centralized in JavaFileTemplate. Also use 'var' to elide
the need to refer to it twice.

Change-Id: Id7fa0625e8d939195654b710e5f9847303c33861
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ed97b5f73617d930a1a9bbd75c0e0c4273568192)

Import java.lang.reflect.Type

Simplify references to make things a tad easier.

Change-Id: I920b633b48b496156eaca2e90ed388adeba41d7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c43270123f7df53786b913ea3172cfbbc54cd974)

Remove unused lines

We have commented-out imports and a superfluous empty line. Remove them.

Change-Id: I91b8dca0041b50baefa032ccff2e4d02a781605a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit eafc049a2d8063ba80ffc9bc17e6c7467f029214)

Import yang-binding

We are referencing a number of constructs here, make sure we also
import the module.

Change-Id: I8b1823046c762e33cc99e1471ee5965ab57e233b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ad3cd1cab61e631f6db296899372089ab51949f8)

Fix RetryingManagedNewTransactionRunner javadoc

JDK13+ requires H2, JDK11 does not care. Fix it up.

Change-Id: Id3898df1112797d8e026934fdc5cae20860871ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 735e0d5fb625a9227fa77954379ad0fc45f753dd)

Fix NotificationService javadoc

We have an invalid @param here, fix that up.

Change-Id: I737c78114863ab5ca5f3a3485dd38fb6c441b3ca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d8914a7d84797e9a2b0aee65003296020ab385ff)

Fixup BindingStreamEventWriter javadoc

JDK17 is picky and the class documentation is a mess anyway. Fix it up.

Change-Id: If7e656b9f3336b9a0cffcc9f64c17eb9853fc919
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f6de05a0afff675c1c5c2b7e49125f2f23905bf2)

Fix a few javadoc warnings

JDK17 is quite picky about these, fix them up.

Change-Id: Id24515f036ec89f24bfb5027ad5d17c37f4b8fa5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9e344b9902099daf029a8e9ea42727760b7b2a9e)

Suppress warning around pathArgument

For some strange reason SE_BAD_FIELD is triggered with JDK17. The
warning is a false positive, as we are handling serialization via
Externalizable proxy.

Change-Id: I4035194852f6b0a914d76929124d92ca8d3039fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7ffe4caeeaa4408aebd96b124639089fa25db594)

Fix javadoc warnings in mdsal-binding-util

We have a few undocumented generic parameters, fix that up.

Change-Id: Ifbe06d528b9333026c1bdc0bd6af73570940ade0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2775afbe5f2c82a6add571a35ad16f6521b72489)

Bump yangtools to 7.0.15

Pick up bugfixes and features from upstream.

Change-Id: I6868396d273302ec636430940ee0ff5e482ee545
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 8.0.14-SNAPSHOT

This starts the next development iteration.

Change-Id: I3864f9ef25176b037ad01e315fe1045fac9b375e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct ActionService generics

We need to allow for any Action, even for KeyedListAction. Make sure to
adjust generics accordingly and add a test.

JIRA: MDSAL-726
Change-Id: I04c8fdf1c8803647c8640bbdd10c19304336b915
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7496691fabeb9d3b1276476740045d17fe473641)

Fix identityref wildcards

Identityref use Class<? extends Target> for their return types, hence
we mask unmask the ParameterizedType to Target's JavaTypeName.

JIRA: MDSAL-732
Change-Id: I96fd0ffcffcd65aa7c658ab9d881a950ba41c6cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f735dcbc86962f6b51abecadec0c00f595649984)

Include namespace manipulations in error report

We need squashing information to make sense of what the requirement
is attempting to do, include it in toString().

Change-Id: Ieeb913680990acb5ccd8690b28c55e4a72f5836e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 14442dc3bf8df154bbe23b993694ed901144cc3b)

Improve information provided on failed linkage progress

Linkage algorithm seems to have a issue with a set of proprietary
models. Rather than throwing a simple exception, add debug logging
to track which items progress and report any remaining items as
suppressed exceptions.

Change-Id: Ia7f1efe498f1ac82de35facf0188d0a2972e2b09
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 46df82388d1f9bf7a939ccf9e26fbd71cd5193c2)

Remove an unneeded line

We are at the end of the loop, no need for a continue statement.

Change-Id: I79478fcbda4820c3923fae39dfec5fe7c47a0e70
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 4460442fba0d2efe0249a42b371ba21f1c898273)

Bump versions to 8.0.13-SNAPSHOT

This starts the next development iteration.

Change-Id: I4cfc4ce8bd020b2e3544b2f2bafc84867a487fbe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct ActionProviderService method definition

registerImplementation generics fail to account for KeyedListActions.
Fix that by making sure allow for KeyedInstanceIdentifiers as well as
InstanceIdentifiers.

JIRA: MDSAL-723
Change-Id: Iac402bb4390dbd1805fc930c2250b3c7c8343dc0
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
(cherry picked from commit 128c1abfb15284e16cdb471bcaacdf7cf6a60eb1)

Bump versions to 8.0.12-SNAPSHOT

This starts the next development iteration.

Change-Id: I57ee9dc7bc7d195b86ea7277e06419607ff31a45
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix uses/augment linkage

Our previous fix for MDSAL-715 switched the resolution logic to a unified
approach based on linked augmentation. Unfortunately it missed the fact
that linking the groupings also had the side-effect of setting the
augment target, which in turn populates 'augments' list.

Our failure to do so ends up wrecking lookups in the case where we have
an uses-augmented node further augmented by a module-augment.

Fix this by intertwining original and augment linkage, so that a subtree
root (such as module) pays attention to augments which need to resolve
before descending to recursive linkage.

JIRA: MDSAL-718
Change-Id: I7bd6cbed636267d35113888ddd35f0c6d9411043
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 7.0.14

Pick up fixes from upstream.

Change-Id: Ia4eccc01ba1a9655483e390b100a34d607cfad23
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct ActionSpec definition

ActionSpec's generics fail to account for KeyedListActions. Fix that
by making sure allow for KeyedInstanceIdentifiers as well as
InstanceIdentifiers.

JIRA: MDSAL-721
Change-Id: I520e23e0294c38c37c6a15dd4d7f05c937476357
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7c8af4914727a5343d0dfa2034e1f1c818ce6e35)

Clarify ActionSpec documentation

The documentation hints at wildcard InstanceIdentifier, but people have
trouble with the concept and what it means. Clarify that a bit.

JIRA: MDSAL-721
Change-Id: I9af71fbbfd2d27b4e4c4c12077975be1671647e3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 42919cabad6f17037fe40b7ab3954b7ffcaf0b34)

Fix an eclipse warning

<T extends Optional<?>> is not liked because of Optional being final.
Fix the warning by changing the prototype a bit.

Change-Id: I8864b695e4affa01913df83721c63ff4fe6d5015
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Examine supported features in yanglib

yang-model-library exposes the features that are actually supported from
a particular module. Process this information and pass it to
SchemaContextResolver so that it can create a correct
EffectiveModelContext.

JIRA: MDSAL-719
Change-Id: I32af4cdec4acb823ad90f2608036f0d71210910b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit cf58c213929bfe0f02649dae81e06a89b3cab75c)

Use 'var' for local variables

We need to use long qualifiers because various we have simple name
overlaps. Use 'var' consistently so that we shorten these.

Change-Id: Ib49fef64bb2ed61d96edbe28a42588deb7b239ad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 03a39718d931d49725ad83a95c56fac2fa156bb3)

Simplify original tracking

Rather that having a quad-state 'prev' field typed to Object, potentially
containing an OriginalLink, make its state logically tri-state typed
with AbstractExplicitGenerator. The resolved generator is then carried in
an explicit field.

JIRA: MDSAL-718
Change-Id: I357a1ad6037a9c5288bdf2ec84dd90882cbcf76a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce explicit generator linkage

We are keeping the original pointer as a simple nullable field. This can
result in us confusing an unresolved generator with an original, leading
to potential badness.

Refactor the AbstractExplicitGenerator to track incremental resolution,
catching invalid accesses.

JIRA: MDSAL-718
Change-Id: Ie67fa4d08d0887f301948e3d03d846ed9ee1d628
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve AugmentedTypeTest

Eclipse is warning of an always-false equality check in this test suite.
Fix this by performing a proper type comparison, eliminating use of
assertTrue().

Change-Id: Ib9e1de97f9263584f4fa484d8998e57c433e1971
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools to 9.0.13/7.0.13

Pick up latest fixes from upstream.

Change-Id: I36e9caf475128854abae451610e9c821d66d7c0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GeneratorReactor.linkOriginalGenerator() should be stateless

linkOriginalGenerator() does not need to modify GeneratorReactor, make
it static, so that we can disconnect the state manipulation.

JIRA: MDSAL-718
Change-Id: I6ef2b81f4645522e2c6388bfcde48c36527e421a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove GeneratorReactor.leafGenerators

This field is completely unused, remove it.

Change-Id: I6d7a923d27406ce062430428ddd3e75649ea54ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve GeneratorReactor timing

Parts of generation are not covered by timer, make sure we measure the
entire execution.

Change-Id: If1ac6fee65f7569bffc7f124551819d12d27f046
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions 8.0.11-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia52c3f9dda20b417c28665e026f186d03b301570
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools to 9.0.12/7.0.12

Pick up latest fixes from upstream.

Change-Id: I93a5848523b632ce9ef451ff896275b238a7cba6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 8.0.10-SNAPSHOT

This starts the next development iteration.

Change-Id: I23e50a7fc505c3eb0f25ad1b886de98eca2c1170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix DataObject builer javadoc references

We have a few mis-references generated in documentation, fix them up.

Change-Id: I3040adeb6ec10ca46395212324df29dbe292a82d
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit aa2ff80e8294ab1590bebcb4b8c60e36d266bda7)

Bump odlparent/yangtools to 9.0.10/7.0.11

Pick up latest fixes from upstream.

Change-Id: I8facba41b2019da8daeea754b78c96d586672aaf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump java-diff-utils to 4.11

https://github.com/java-diff-utils/java-diff-utils/blob/master/CHANGELOG.md#49
https://github.com/java-diff-utils/java-diff-utils/blob/master/CHANGELOG.md#410
https://github.com/java-diff-utils/java-diff-utils/blob/master/CHANGELOG.md#411

Change-Id: I5e4191c4993ac472ee33171fa4d2da604a7c7313
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 43200236635afacd16c0dffd3f31162d2077278d)

Deprecate AssertDataObjects

XtendBuilderExtensions class is proven to be unnecessary,
remove its usage and mark it for removal.

JIRA: MDSAL-716
Change-Id: I92cf5e060b41320b1d8b7b067c76e5bfdf61fc5c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1fbc15a384476ed652e45faa6e9dc4d41234aae0)

Bump versions to 8.0.9-SNAPSHOT

This starts the next development iteration.

Change-Id: Ie4a972f57108fb92e8668e1d255f27cf7b00386e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor augment generator linkage

The uses/augment and module/augment cases are quite different from
the perspective how we map their argument reference to generators.

The uses/augment case is quite simple, as it refers to grouping's nodes,
not augmentations. The only variation we need to account for is the
skip back to the defining grouping.

The module/augment case, on the other hand, is more complex, as it can
refer to augmentations -- hence it need to account for changes namespace
changes along uses/grouping as well as back from grouping child to
augmentations.

JIRA: MDSAL-715
Change-Id: I7425301afa6de566d985d19450ccfc64ea527119
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d601e4b48e111846c005b6f773634e7a5c28e89f)

Use Empty.value() instead of Empty.getInstance()

Empty..getInstance() is going away, do not generate references to it.

Change-Id: I9322032c8b4c6741d2608948fc98711f3ce2573c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 140fdfc2474786eb3b9cbf5217d39618597eeead)

Bump odlparent/yangtools to 9.0.9/7.0.10

Pick up latest fixes from upstream.

Change-Id: I90601e17bd7c2e502ad98077df6f52e401125f66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do no use reflection to obtain opaque value ctor

We can do all the lookups and access via java.lang.invoke, let's
not bring java.lang.reflect to the party.

Change-Id: I7528a469270d384fbbbd9680cffe227129cf4d39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c95e5240ca83def4357e8ca7c45b71ea33e9f973)

Use a shared type for Pattern

We are looking up the type here multiple times, which is not entirely
efficient. Add a constant to hold the type.

Change-Id: I5da339cd21c5944c13ed2eb66f15b9ae61d56b46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit bd63710ebd35fbda6eff024bb3bbc60f037eee9f)

Use BindingTypes instead of rollin input/output types

We have well-known constants covering ConcreteTypes for RpcInput and
RpcOutput. Use them directly, reducing startup time a bit.

Change-Id: I145c4de2db0d3769f6926200f8e8afe6461a445f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2db704e27af6f96b6cc7a37f86bd0b2ad378384e)

Fix action invocation and registration

Binding actions involving groupings are a bit more complicated when it
comes to DOM mapping. An instantiated Action can correspond to any
number of ActionEffectiveStatements, but we skimped that over and used
the SchemaPath (and after that, an invalid SchemaNodeIdentifier) to
identify them.

Correct this by requiring users to provide an ActionSpec, which is a
combination of an Action interface and a corresponding instantiation
path.

JIRA: MDSAL-712
Change-Id: I632c0f51b2e71fa1b0a04e43d5b1c50286430b21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 54cf838b1a16c1f911963e23e738b1eef753c421)

Another mdsal-dom-api module update

We are using annotations in interfaces, hence we need to require
them transitively.

Change-Id: Ibc6b02f5e02c3e7533a9272daa1090569234e11a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 54b2e91548e5121f9cc1ec8d1982f768dafe7ea5)

Update mdsal-dom-api module-info

Our users need access to both concepts and yang.common, reflect that.

Change-Id: I46f18e3a6057ff5407c3cfdde7dcea31baf54f62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7b91035d8c3cc1ed0ff401c546bbfb9a445a3290)

Clean up IMDS dependencies

Fix dependency declarations and make sure we do not need error-prone.

Change-Id: Ie015e508cf352fc0f28c03bb9b99879773fd0aba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.12.1

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.1
plus the preceding items.

Change-Id: Ie785b9e131369a35584f68a9c9b32ee536b5cead
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Map.entry() in BindingCodecContext

We are not using nulls, let's use an immutable entry.

Change-Id: I1d2fdd64b8396f991a267c429cf5822d9ada5fa1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve CompilationTestUtils

We can perform better asserts, let's do that.

Change-Id: I671e1a0425d74b2f87a398102fba9cd890b9efc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add missing requires on yang-common

We are referencing types from yang-common, make sure we require them
and not get them transitively.

Change-Id: Id93e890e3a303b4199e7ae2f2809e29b02f81b7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 8.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I55d485d6a4ad9de8147d2deee1ec56ca3f3b7e8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 9.0.8

We have mis-aligned versions view of odlparent with yangtools-7.0.9,
fix that.

JIRA: MDSAL-703
Change-Id: I3d772d956bacce0dfd8c398d2b7a9b1b49d2c1bf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup BindingTypesTest

Use assertThrows() instead of @Text(expected), not that it really
matters here.

Change-Id: I8c8ac3d0c5fc99eebaaaae9c5d0943244e9498f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require checker.qual

We are using the annotations here, but do not pull in the corresponding
module. Fix that.

Change-Id: Idc25a01c5ba0068763f45f11ddcdfb75a1aae3ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

DataTreeIdentifier is HierarchicalIdentifier

yangtools.concepts.Path is deprecated, use its replacement interface,
which actually fits here like a glove.

Change-Id: Ic3df2f95ce54334526444aeb28688bf70e14ed35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 8.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: Idd52a361f4d44df5bc4cac63d6f6b2b98797d4b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use HierarchicalIdentifier

We have a number of identifiers which do not actually implement
Identifier concept but rather Path. We have a replacement for Path,
so let's use it, improving contracts the process of doing so.

Change-Id: Idf506084d1b67993f4a7d37efd23b5fca234375f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools

Adopt odlparent-9.0.7, yangtools-7.0.9.

Change-Id: I5bafc485191739b184a46c4a3db532a00b50b554
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add NotificationService.registerListener()

We want to get rid of FooListener-based notifications, so that we
can use simple lambdas and proper composition. This takes the first
step towards that by allowing users to register a simple
@FunctionalInterface-based listener.

JIRA: MDSAL-700
Change-Id: Ica1ac23515c813366d5d66dc91c3183695f84ce7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve RoutedDOMRpcRoutingTableEntryTest

The only test we had here was exercising a warning path, expand
the test suite to properly cover routed RPCs.

Change-Id: Ic37cdc54b1406257408505b21cb65d6d0aa1cf35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use anonymous classes in PingPongTransactionChain

PingPongTransactionChain is quite complicated and it is not helpful
to have just anonymous subclasses, which may end up capturing more
than we want. Split them out to make Sonar happier.

Change-Id: I9995682091daf6b31c196fee5b89d8cfd19f016c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add basic PingPongTransactionChainTest

Covert the basics of behaviour, this still does not deal with various
race conditions.

JIRA: MDSAL-698
Change-Id: I53103cf3226ca8426dd12eed1f013052258ceb1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve DOMRpcRouterTest

The test is testing a router with no RPCs, add a simple test model
and use its constants to improve actual coverage.

Change-Id: Id2db74f5d321d2857ab3f1237711b4d654e4087b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve RoutedDOMRpcRoutingTableEntryTest

Add a few assertions around what we expect to happen.

Change-Id: I4fc56fb0f763a5b9cf6669444a8d1e3e442780c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

TestUtils is a utility class

We are subclassing TestUtils just to get at a few static methods and
constants. Turn it into a final class instead.

Change-Id: Ibb25b783b76429b9fca3ba44838e93f2755127d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fold OSGiDOMNotificationRouter

We have constructor injection, hence we can easily combine the two
implementations. Also add javax.inject annotations to allow easier
integration.

Change-Id: Id3604110522f73ef4e2f705cad74b31545eb27f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve OSGi RPC/Action component coverage

These are simple forwarders, add equally simple tests to cover their
basics.

Change-Id: I529253060122bcddc14a4c629de27d4c2d798af0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove useless throws

Utility test classes have to have a private constructor, but there
is no point in guarding it with an UOE.

Change-Id: I658835c9c6a93032637198d66f08f8d0e0d6b0b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve DOMRpcRouter coverage

The test suite could use a ton of improvements, add a few more
assertions and tests.

Change-Id: I4492dc352e65c5240c55bb730d4b0468669776dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve listener dispatch

Both RPC and action listeners should always be ImmutableLists, make sure
that is captured in their definition. This is an invariant useful for
JIT, as we bind directly to implementation -- and do not throw
Collections.emptyList() into the mix.

Change-Id: I7fe71819f11b80399734759bf774c629adfe12bf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup OSGi DOMRpcRouter services

We have constructor injection available, which allows us to make these
classes cleaner by making the delegate field final.

Change-Id: I7ed6aa2f5670fb80fb123957a1446ceb0f6aef7c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge (OSGi)DOMRpcRouter

We have contructor injection in OSGi DS, hence we can merge these
classes. Also add missing cleanup under javax.inject rules.

Change-Id: I3c580929f67e4f103707902706c9303221272cb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup mdsal-binding-generator packaging

We just ditched utilities depending on it, hence we do not need to
pull it anymore. Also adjust dependencies to silence warnings.

Change-Id: If09662e7a49d0df34aadf23a63193d48f3e75044
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove mdsal.binding.yang.types

This package is not exported by us and therefore not accessible by
anyone. We have just ditched its last user, ditch the package as well,
along with its test suite.

Change-Id: Ida72524105d0134395c06c48a994fc86893567d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ConfigTypeProvider tests

There are a few remaining tests, migrate them and inhume
AbstractTypeProvider et al.

Change-Id: I1aa96547dfa67ef7dc48f8ef948656fab0405ca4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove a chunk of AbstractTypeProvider

We now have no references to some of the code, remove it before
we proceed further. Also hide methods not called externally, so
they will be identified as unused.

Change-Id: I351355657eb8cd2e19c18d553c18a0590cef8a9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expand DefaultBindingGeneratorTest

We have fixed the test model (as it was invalid). Add an explicit test
for the now-unresovled grouping leaf type and also restore the original
negative test.

Change-Id: I14c0d734ee8990f9ad9ac8f8c58f37cafae34990
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RuntimeTypeProvider

Migrate all disabled tests which rely on it and remove it. This
increases our assertion coverage and reduces the amount of code we lug
around.

Change-Id: I5ecd83b953f021786a7fb9bd8a228c67e528ea7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce code duplication a tiny bit

The 'else' part of CaseNodeCodecContext's return is the same as
overridden method, hence call super instead of duplicating code.

Also add a few FIXMEs to guide our intent going forward.

JIRA: MDSAL-697
Change-Id: I7dd9576da217f1a186e9298346ee62aa2ede45d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a ModuleAugmentGenerator FIXME

Since we will be dealing with getOriginal(), it seems we had some
dead code from conversion. This might prove useful in what we need
to achieve here.

JIRA: MDSAL-696
Change-Id: I8af7f2277f5adc9c08b304d4f8693fc43ece6778
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>