From 02d183b718d11ac6cf8dbbd43b859218135ee8fe Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 6 Jan 2020 23:36:21 +0100 Subject: [PATCH] Eliminate shift variable We do not need to track shift amount, as we can can just shift the entire previous result, leading to more invariants in the loop. JIRA: MDSAL-509 Change-Id: I13a108be27cac2fe4498952f3f05437927c999c0 Signed-off-by: Robert Varga (cherry picked from commit 4b26656c945b9af5e67d28d10b014b0ed37cc510) --- .../org/opendaylight/mdsal/model/ietf/util/Ipv4Utils.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv4Utils.java b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv4Utils.java index 66a94ee09e..847b1914be 100644 --- a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv4Utils.java +++ b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv4Utils.java @@ -39,17 +39,16 @@ final class Ipv4Utils { static int addressBits(final String str, final int limit) { int prev = 0; int current = 0; - for (int i = 0, shift = 24; i < limit; ++i) { + for (int i = 0; i < limit; ++i) { final char c = str.charAt(i); if (c == '.') { - prev |= current << shift; - shift -= 8; + prev = prev << 8 | current; current = 0; } else { current = 10 * current + c - '0'; } } - return prev | current; + return prev << 8 | current; } static byte @NonNull[] addressBytes(final String str, final int limit) { -- 2.36.6