From 06c6f6b581b0d1526231d84cf0884142fc4f8a4c Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 19 Dec 2019 13:51:04 +0100 Subject: [PATCH] Use BindingTypes.identifiable() Instead of looking up Identifiable type each time we use it, use the convenience method exposed through BindingTypes, improving efficiency a bit. Change-Id: Ib8e7bf0385a51ee687484a2667905e284a90ab3a Signed-off-by: Robert Varga --- .../binding/java/api/generator/AbstractBuilderTemplate.xtend | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend index 923b78ff22..030bdacbde 100644 --- a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend +++ b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend @@ -22,9 +22,8 @@ import org.opendaylight.mdsal.binding.model.api.GeneratedProperty import org.opendaylight.mdsal.binding.model.api.GeneratedTransferObject import org.opendaylight.mdsal.binding.model.api.GeneratedType import org.opendaylight.mdsal.binding.model.api.Type -import org.opendaylight.mdsal.binding.model.util.Types +import org.opendaylight.mdsal.binding.model.util.BindingTypes import org.opendaylight.mdsal.binding.spec.naming.BindingMapping -import org.opendaylight.yangtools.yang.binding.Identifiable abstract class AbstractBuilderTemplate extends BaseTemplate { static val Comparator KEY_PROPS_COMPARATOR = [ p1, p2 | return p1.name.compareTo(p2.name) ] @@ -131,7 +130,7 @@ abstract class AbstractBuilderTemplate extends BaseTemplate { «generateCopyAugmentation(implType)» «ENDIF» «val allProps = new ArrayList(properties)» - «val isList = implementsIfc(targetType, Types.parameterizedTypeFor(Types.typeForClass(Identifiable), targetType))» + «val isList = implementsIfc(targetType, BindingTypes.identifiable(targetType))» «IF isList && keyType !== null» «val keyProps = new ArrayList((keyType as GeneratedTransferObject).properties)» «keyProps.sort(KEY_PROPS_COMPARATOR)» -- 2.36.6