From 53d50535b20340477f76e0998297b43430b2aacb Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 25 Apr 2022 21:11:44 +0200 Subject: [PATCH] Fix checkstyle Updated checkstyle is finding a few violations, fix them up. Change-Id: I7a9cb9a19dc20de08a856c7752af8f060585e342 Signed-off-by: Robert Varga --- .../mdsal/binding/api/MountPointService.java | 5 +--- .../binding/api/query/MatchBuilderPath.java | 30 +++++++++---------- .../NotificationListenerInvokerTest.java | 2 ++ .../api/EntityOwnershipChangeState.java | 4 +-- 4 files changed, 20 insertions(+), 21 deletions(-) diff --git a/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/MountPointService.java b/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/MountPointService.java index 7d7000e7c0..e5752124f9 100644 --- a/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/MountPointService.java +++ b/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/MountPointService.java @@ -18,13 +18,10 @@ public interface MountPointService extends BindingService { ListenerRegistration registerListener(InstanceIdentifier path, T listener); - - public interface MountPointListener extends EventListener { + interface MountPointListener extends EventListener { void onMountPointCreated(InstanceIdentifier path); void onMountPointRemoved(InstanceIdentifier path); - } - } diff --git a/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/query/MatchBuilderPath.java b/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/query/MatchBuilderPath.java index e50af0f26d..3a62661210 100644 --- a/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/query/MatchBuilderPath.java +++ b/binding/mdsal-binding-api/src/main/java/org/opendaylight/mdsal/binding/api/query/MatchBuilderPath.java @@ -202,7 +202,7 @@ public interface MatchBuilderPath ex * @param Child type */ @FunctionalInterface - public interface LeafReference extends Serializable { + interface LeafReference extends Serializable { /** * Dummy method to express the method signature of a typical getter. Due to this match we can match any Java * method reference which takes in {@code parent} and results in {@code child} -- expose the feature of using @@ -218,72 +218,72 @@ public interface MatchBuilderPath ex } @FunctionalInterface - public interface BooleanLeafReference

extends LeafReference { + interface BooleanLeafReference

extends LeafReference { } @FunctionalInterface - public interface Decimal64LeafReference

extends LeafReference { + interface Decimal64LeafReference

extends LeafReference { } @FunctionalInterface - public interface EmptyLeafReference

extends LeafReference { + interface EmptyLeafReference

extends LeafReference { } @FunctionalInterface - public interface StringLeafReference

extends LeafReference { + interface StringLeafReference

extends LeafReference { } @FunctionalInterface - public interface Int8LeafReference

extends LeafReference { + interface Int8LeafReference

extends LeafReference { } @FunctionalInterface - public interface Int16LeafReference

extends LeafReference { + interface Int16LeafReference

extends LeafReference { } @FunctionalInterface - public interface Int32LeafReference

extends LeafReference { + interface Int32LeafReference

extends LeafReference { } @FunctionalInterface - public interface Int64LeafReference

extends LeafReference { + interface Int64LeafReference

extends LeafReference { } @FunctionalInterface - public interface Uint8LeafReference

extends LeafReference { + interface Uint8LeafReference

extends LeafReference { } @FunctionalInterface - public interface Uint16LeafReference

extends LeafReference { + interface Uint16LeafReference

extends LeafReference { } @FunctionalInterface - public interface Uint32LeafReference

extends LeafReference { + interface Uint32LeafReference

extends LeafReference { } @FunctionalInterface - public interface Uint64LeafReference

extends LeafReference { + interface Uint64LeafReference

extends LeafReference { } @FunctionalInterface - public interface IdentityLeafReference extends LeafReference { + interface IdentityLeafReference extends LeafReference { } @FunctionalInterface - public interface TypeObjectLeafReference extends LeafReference { + interface TypeObjectLeafReference extends LeafReference { } } diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/NotificationListenerInvokerTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/NotificationListenerInvokerTest.java index e8880d3667..e8936f9182 100644 --- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/NotificationListenerInvokerTest.java +++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/invoke/NotificationListenerInvokerTest.java @@ -53,11 +53,13 @@ public class NotificationListenerInvokerTest { public interface TestInterface extends NotificationListener, Augmentation { QName QNAME = QName.create("test", "test"); + void onTestNotificationInterface(TestNotificationInterface notif); } private interface TestPrivateInterface extends NotificationListener, Augmentation { QName QNAME = QName.create("test", "test"); + void onTestNotificationInterface(TestNotificationInterface notif); } diff --git a/entityownership/mdsal-eos-common-api/src/main/java/org/opendaylight/mdsal/eos/common/api/EntityOwnershipChangeState.java b/entityownership/mdsal-eos-common-api/src/main/java/org/opendaylight/mdsal/eos/common/api/EntityOwnershipChangeState.java index 1623790087..b9d4c9ebc5 100644 --- a/entityownership/mdsal-eos-common-api/src/main/java/org/opendaylight/mdsal/eos/common/api/EntityOwnershipChangeState.java +++ b/entityownership/mdsal-eos-common-api/src/main/java/org/opendaylight/mdsal/eos/common/api/EntityOwnershipChangeState.java @@ -51,9 +51,9 @@ public enum EntityOwnershipChangeState { REMOTE_OWNERSHIP_LOST_NO_OWNER(false, false, false); private static final Map BY_KEY; + static { - final Builder builder - = ImmutableMap.builder(); + final Builder builder = ImmutableMap.builder(); for (final EntityOwnershipChangeState e: values()) { builder.put(new Key(e.wasOwner, e.isOwner, e.hasOwner), e); } -- 2.36.6