From d00ac714099143588faa58582f1d3bedb5b34532 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 21 Oct 2019 18:52:35 +0200 Subject: [PATCH] Fix spotbugs complaints around logging Spotbugs is very much correct about warning about non-constant format strings. This patch fixes that up. Change-Id: I8df61b64be1478510e60af99dd2cd2365a98f2c1 Signed-off-by: Robert Varga (cherry picked from commit 89ffe8626f4addebedc19f4c85e12d35d047b2e0) --- .../binding/maven/api/gen/plugin/CodeGeneratorImpl.java | 6 +++--- .../binding/yang/unified/doc/generator/GeneratorImpl.xtend | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/maven/api/gen/plugin/CodeGeneratorImpl.java b/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/maven/api/gen/plugin/CodeGeneratorImpl.java index 9108d318d2..62c80d46cb 100644 --- a/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/maven/api/gen/plugin/CodeGeneratorImpl.java +++ b/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/maven/api/gen/plugin/CodeGeneratorImpl.java @@ -162,7 +162,7 @@ public final class CodeGeneratorImpl implements BasicCodeGenerator, BuildContext File outputBaseDir; outputBaseDir = new File(DEFAULT_OUTPUT_BASE_DIR_PATH); setOutputBaseDirAsSourceFolder(outputBaseDir, mavenProject); - LOG.debug("Adding " + outputBaseDir.getPath() + " as compile source root"); + LOG.debug("Adding {} as compile source root", outputBaseDir.getPath()); return outputBaseDir; } @@ -233,10 +233,10 @@ public final class CodeGeneratorImpl implements BasicCodeGenerator, BuildContext bw.write(source); } } catch (Exception e) { - LOG.error("Could not write file: {}",file,e); + LOG.error("Could not write file: {}", file, e); } } catch (Exception e) { - LOG.error("Could not create file: {}",file,e); + LOG.error("Could not create file: {}", file, e); } return file; } diff --git a/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/yang/unified/doc/generator/GeneratorImpl.xtend b/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/yang/unified/doc/generator/GeneratorImpl.xtend index 188be43d8b..2def6cb2a2 100644 --- a/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/yang/unified/doc/generator/GeneratorImpl.xtend +++ b/binding/maven-sal-api-gen-plugin/src/main/java/org/opendaylight/mdsal/binding/yang/unified/doc/generator/GeneratorImpl.xtend @@ -99,7 +99,7 @@ class GeneratorImpl { bw.close(); fw.close(); } catch (IOException e) { - LOG.error(e.getMessage()); + LOG.error("Failed to emit file {}", destination, e); } return destination; } -- 2.36.6