From d613481dfab5abd014e36fc8f77b291743c57dbf Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 15 Jul 2020 17:43:28 +0200 Subject: [PATCH] Speed up BuilderGenerator matcher We do not need to establish FQCN, as we can compare just JavaTypeNames, which is faster. Change-Id: I3c387e841fbf2d450195d864a928608bab8128ad Signed-off-by: Robert Varga --- .../binding/java/api/generator/BuilderGenerator.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderGenerator.java b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderGenerator.java index ab5944b573..3bada347ea 100644 --- a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderGenerator.java +++ b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderGenerator.java @@ -41,6 +41,9 @@ import org.opendaylight.yangtools.yang.binding.Augmentation; * class. For generation of the source code is used the template written in XTEND language. */ public final class BuilderGenerator implements CodeGenerator { + private static final JavaTypeName AUGMENTABLE = JavaTypeName.create(Augmentable.class); + private static final JavaTypeName AUGMENTATION = JavaTypeName.create(Augmentation.class); + private static final Comparator METHOD_COMPARATOR = new AlphabeticallyTypeMemberComparator<>(); private static final Type AUGMENTATION_RET_TYPE; @@ -66,12 +69,10 @@ public final class BuilderGenerator implements CodeGenerator { if (type instanceof GeneratedType && !(type instanceof GeneratedTransferObject)) { for (Type t : ((GeneratedType) type).getImplements()) { // "rpc" and "grouping" elements do not implement Augmentable - if (t.getFullyQualifiedName().equals(Augmentable.class.getName())) { - return true; - } else if (t.getFullyQualifiedName().equals(Augmentation.class.getName())) { + final JavaTypeName name = t.getIdentifier(); + if (name.equals(AUGMENTABLE) || name.equals(AUGMENTATION)) { return true; } - } } return false; -- 2.36.6