Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 647dd26) | patch
Fix unsafe global config access 86/82186/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 21 May 2019 11:27:02 +0000 (13:27 +0200)
committerRobert Varga <nite@hq.sk>
Tue, 21 May 2019 11:32:07 +0000 (11:32 +0000)
commit268bde77fa1196a742565202783d5071afa833bf
tree0edd209dd40cc61fe2205e26bc9b6b4cbc4a1129tree | snapshot
parent647dd26b689d585bb84166fb5562bde711324a9fcommit | diff
Fix unsafe global config access

Current global config is a volatile variable, hence it must be
acquired into a local variable for proper nullness checks --
otherwise it is open to TOCTOU race conditions leading to NPEs.

Change-Id: I9316b3ed976575726da7a065668c507e15fe0ddf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
netconf/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java diff | blob | history
Netconf