Fix findbugs violations in restconf-nb-bierman02 56/68556/4
authorTom Pantelis <tompantelis@gmail.com>
Fri, 23 Feb 2018 16:55:18 +0000 (11:55 -0500)
committerJakubToth <jakub.toth@pantheon.tech>
Tue, 27 Feb 2018 20:34:44 +0000 (20:34 +0000)
commit86e8b0bb2c9e0f10f7d679cf70495c3d4249e547
tree5484cb35f0343d0898bff69359d054b535039fa7
parentab99fd44ddf84e474491005ea2db7e4282ad3966
Fix findbugs violations in restconf-nb-bierman02

- Possible null pointer dereference
- Method call passes null for non-null parameter
- Nullcheck of value previously dereferenced
- Consider using Locale parameterized version of invoked method
- Reliance on default encoding
- Inefficient use of keySet iterator instead of entrySet iterator
- Private method is never called
- Boxing/unboxing to parse a primitive
- Method concatenates strings using + in a loop
- Unchecked/unconfirmed cast of return value from method
- Method uses the same code for two switch clauses
- Parameter must be non-null but is marked as nullable
- Redundant nullcheck of value known to be non-null
- Exception is caught when Exception is not thrown
- Useless control flow

Change-Id: Ifd737d8c54532d98dd162db8d2a5915e38b13ff1
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
12 files changed:
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/rest/impl/JsonNormalizedNodeBodyReader.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/rest/impl/JsonToPatchBodyReader.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/rest/impl/RestconfDocumentedExceptionMapper.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/rest/impl/XmlToPatchBodyReader.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/BatchedExistenceCheck.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/BrokerFacade.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/JSONRestconfServiceImpl.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/QueryParametersParser.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestCodec.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestconfImpl.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/streams/listeners/ListenerAdapter.java
restconf/restconf-nb-bierman02/src/main/java/org/opendaylight/netconf/sal/streams/websockets/WebSocketServerHandler.java