Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a01dad8) | patch
Fix findbugs violations in sal-rest-docgen 46/68946/2
authorTom Pantelis <tompantelis@gmail.com>
Thu, 1 Mar 2018 14:15:53 +0000 (09:15 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Mon, 5 Mar 2018 19:26:28 +0000 (14:26 -0500)
commit9d4f66971356d2ab3769b172e8b968ec36f894c2
tree101c91aa81cad10ceff597ec359781f05c2cac66tree | snapshot
parenta01dad851768102b3182033c10d860f5245d7d26commit | diff
Fix findbugs violations in sal-rest-docgen

- Reliance on default encoding
- Field is a mutable collection
- Write to static field from instance method
- Exception is caught when Exception is not thrown
- Field not initialized in constructor but dereferenced without null check
- Useless object created

Change-Id: Iff717b38d3a5bee082e7a9fb30969a0d755bf4c2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/impl/ApiDocGenerator.java diff | blob | history
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/impl/ApiDocServiceImpl.java diff | blob | history
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/impl/BaseYangSwaggerGenerator.java diff | blob | history
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/model/builder/OperationBuilder.java diff | blob | history
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/mountpoints/MountPointSwagger.java diff | blob | history
Netconf